[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655584#comment-17655584
]
Noble Paul edited comment on SOLR-16531 at 1/6/23 9:25 PM:
-----------------------------------------------------------
{quote}shows enough promise that it'd make sense to extend the deadline a bit
further,
{quote}
I think we should revert the changes and work on a branch. The problem is, as
there is a known perf degradation , nobody can do any test of perf on any
commits. So we are in the dark regarding perf degradations that might have
happened due to other changes. for instance, we have upgraded jetty recently
and we do not know if that is an improvement or degradation because the
benchmarks are not run
ideally , if there is a perf issue between 9.1 and 9.2 , we should be able to
pin point it to a single commit. We are not unable to do that because of this .
9x branch should *always* have performance closer to 9.1.
was (Author: noble.paul):
{quote}shows enough promise that it'd make sense to extend the deadline a bit
further,
{quote}
I think we should revert the changes and work on a branch. The problem is, as
there is a known perf degradation , nobody can do any test of perf on any
commits. So we are in the dark regarding perf degradations that might have
happened due to other changes.
ideally , if there is a perf issue between 9.1 and 9.2 , we should be able to
pin point it to a single commit. We are not unable to do that because of this .
9x branch should *always* have performance closer to 9.1
> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
> Key: SOLR-16531
> URL: https://issues.apache.org/jira/browse/SOLR-16531
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Priority: Blocker
> Fix For: 9.2
>
> Attachments: Screenshot from 2022-11-09 11-20-44.png,
> jaxrs-integration-with-app-per-configset-flamegraph.html,
> results-with-patch.tar.gz, vanilla-jaxrs-integration-flamegraph.html
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here:
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
> This suite was run after retro-actively applying the parallelStream patch
> from SOLR-16414:
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
