[jira] [Resolved] (SOLR-16580) Avoid making copies of DocCollection for PRS updates

2023-02-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16580. --- Fix Version/s: 9.2 Resolution: Fixed > Avoid making copies of DocCollection for PRS updates >

[jira] [Resolved] (SOLR-16636) ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-05 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16636. --- Fix Version/s: 9.2 Resolution: Fixed > ZkStateReader.waitForState should not register a watch

[jira] [Commented] (SOLR-16608) Enable ability to compress state.json in Zookeeper

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684484#comment-17684484 ] ASF subversion and git services commented on SOLR-16608: Commit

[jira] [Commented] (SOLR-16608) Enable ability to compress state.json in Zookeeper

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684483#comment-17684483 ] ASF subversion and git services commented on SOLR-16608: Commit

[GitHub] [solr] noblepaul merged pull request #1267: SOLR-16608: Ability to compress the collection state

2023-02-05 Thread via GitHub
noblepaul merged PR #1267: URL: https://github.com/apache/solr/pull/1267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] mkhludnev commented on a diff in pull request #1324: SOLR-16643: Add multiplying boost option to rerank query parser

2023-02-05 Thread via GitHub
mkhludnev commented on code in PR #1324: URL: https://github.com/apache/solr/pull/1324#discussion_r1096982867 ## solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java: ## @@ -72,25 +74,33 @@ public Query parse() throws SyntaxError { double reRankWeight =

[jira] [Commented] (SOLR-16636) ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684435#comment-17684435 ] ASF subversion and git services commented on SOLR-16636: Commit

[jira] [Commented] (SOLR-16636) ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684434#comment-17684434 ] ASF subversion and git services commented on SOLR-16636: Commit

[GitHub] [solr] noblepaul merged pull request #1318: SOLR-16636: ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-05 Thread via GitHub
noblepaul merged PR #1318: URL: https://github.com/apache/solr/pull/1318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684424#comment-17684424 ] ASF subversion and git services commented on SOLR-16629: Commit

[jira] [Commented] (SOLR-16580) Avoid making copies of DocCollection for PRS updates

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684407#comment-17684407 ] ASF subversion and git services commented on SOLR-16580: Commit

[jira] [Commented] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684401#comment-17684401 ] ASF subversion and git services commented on SOLR-16629: Commit

[GitHub] [solr] dsmiley merged pull request #1313: SOLR-16629 Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-02-05 Thread via GitHub
dsmiley merged PR #1313: URL: https://github.com/apache/solr/pull/1313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-16580) Avoid making copies of DocCollection for PRS updates

2023-02-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684400#comment-17684400 ] ASF subversion and git services commented on SOLR-16580: Commit

[GitHub] [solr] noblepaul merged pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-02-05 Thread via GitHub
noblepaul merged PR #1242: URL: https://github.com/apache/solr/pull/1242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] noblepaul commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-02-05 Thread via GitHub
noblepaul commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1096908318 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -488,4 +494,27 @@ public interface CollectionStateProps { String SHARDS = "shards";

[GitHub] [solr] cesnietor opened a new pull request, #1337: Solve FIXME in tutorial-five-minutes

2023-02-05 Thread via GitHub
cesnietor opened a new pull request, #1337: URL: https://github.com/apache/solr/pull/1337 # Description Adds basic search example in tutorial-five-minutes file. # Solution Added an example on how to search a document. Output comes like: ``` curl

[GitHub] [solr] epugh commented on pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on PR #1218: URL: https://github.com/apache/solr/pull/1218#issuecomment-1418240952 This is really exciting.. I love seeing this effort to simplify how our tests are written. I have found them at times to be quite difficult to understand, so this is a great step. --

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096791114 ## solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java: ## @@ -34,17 +38,26 @@ * @since solr 1.3 */ public class

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096791009 ## solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java: ## @@ -34,17 +38,26 @@ * @since solr 1.3 */ public class

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096790762 ## solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java: ## @@ -31,18 +30,18 @@ public class SolrPingTest extends EmbeddedSolrServerTestBase {

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096790167 ## solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java: ## @@ -31,18 +30,18 @@ public class SolrPingTest extends EmbeddedSolrServerTestBase {

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096789742 ## solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java: ## @@ -16,12 +16,17 @@ */ package org.apache.solr.client.solrj.embedded;

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096789692 ## solr/solrj/src/test/org/apache/solr/client/solrj/embedded/AbstractEmbeddedSolrServerTestCase.java: ## @@ -104,4 +110,8 @@ protected SolrClient getSolrCore1() {

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096789163 ## solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java: ## @@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096788848 ## solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java: ## @@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase { @BeforeClass

[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
epugh commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1096788578 ## solr/core/src/java/org/apache/solr/update/UpdateShardHandlerConfig.java: ## @@ -32,6 +32,15 @@ public class UpdateShardHandlerConfig {

[GitHub] [solr] dsmiley commented on pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-02-05 Thread via GitHub
dsmiley commented on PR #1218: URL: https://github.com/apache/solr/pull/1218#issuecomment-1418184560 This is ready! I'm looking to commit this Tuesday if I don't hear feedback to the contrary. Suggested CHANGES.txt: - SOLR-16573: Introduce EmbeddedSolrServerTestRule, a

[GitHub] [solr] dsmiley commented on a diff in pull request #1334: SOLR-16590: Standardize Builder method names in solr clients

2023-02-05 Thread via GitHub
dsmiley commented on code in PR #1334: URL: https://github.com/apache/solr/pull/1334#discussion_r1096738876 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1096,38 +1096,89 @@ public Builder withTheseParamNamesInTheUrl(Set urlParamNames) {

[GitHub] [solr] epugh commented on pull request #1336: what happens if we remove SSL annotation?

2023-02-05 Thread via GitHub
epugh commented on PR #1336: URL: https://github.com/apache/solr/pull/1336#issuecomment-1417780786 umm... getting into the weeds...And saw some other comments about OS X not working maybe too... humm... -- This is an automated message from the Apache Git Service. To respond to