[jira] [Resolved] (SOLR-16685) Gradle erroring out with JDK17

2023-03-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-16685. - Resolution: Invalid > Gradle erroring out with JDK17 > --

[jira] [Commented] (SOLR-16685) Gradle erroring out with JDK17

2023-03-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697270#comment-17697270 ] Ishan Chattopadhyaya commented on SOLR-16685: - Here's how it looks. {code} [i

[GitHub] [solr] dsmiley commented on a diff in pull request #1412: SOLR-16372: Migrate collection listing, deletion to JAX-RS

2023-03-06 Thread via GitHub
dsmiley commented on code in PR #1412: URL: https://github.com/apache/solr/pull/1412#discussion_r1127377657 ## solr/core/src/java/org/apache/solr/jersey/SolrJacksonMapper.java: ## @@ -18,15 +18,44 @@ package org.apache.solr.jersey; import com.fasterxml.jackson.annotation.Jso

[GitHub] [solr] dsmiley commented on a diff in pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
dsmiley commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127371987 ## solr/CHANGES.txt: ## @@ -236,6 +236,8 @@ Bug Fixes * SOLR-16656: rid parameter missing from query logs (Alex Deparvu) +* SOLR-16676: Http2SolrClient loss of MDC co

[GitHub] [solr] stillalex commented on pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
stillalex commented on PR #1410: URL: https://github.com/apache/solr/pull/1410#issuecomment-1457520914 I think all feedback was covered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [solr] stillalex commented on a diff in pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
stillalex commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127332650 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -447,21 +450,42 @@ public Cancellable asyncRequest( @Override

[GitHub] [solr] dsmiley commented on a diff in pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
dsmiley commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127330844 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -447,21 +450,42 @@ public Cancellable asyncRequest( @Override

[GitHub] [solr-operator] panther999 commented on issue #528: Indexing using external Zookeeper - SolrJ

2023-03-06 Thread via GitHub
panther999 commented on issue #528: URL: https://github.com/apache/solr-operator/issues/528#issuecomment-1457502520 Thank you both. Combining both the solutions - worked for me. I used solr-common-service baseurl with Http2Client. Indexing runs fine now from outside of kubernetes cluster.

[GitHub] [solr] stillalex commented on a diff in pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
stillalex commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127202872 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java: ## @@ -469,6 +474,43 @@ public void testGetById() throws Exception { } } +

[GitHub] [solr] stillalex commented on a diff in pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
stillalex commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127202620 ## solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] stillalex commented on a diff in pull request #1410: SOLR-16676 Http2SolrClient loss of MDC context

2023-03-06 Thread via GitHub
stillalex commented on code in PR #1410: URL: https://github.com/apache/solr/pull/1410#discussion_r1127114676 ## solr/core/src/test/org/apache/solr/handler/TestHttpRequestId.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Assigned] (SOLR-15493) Feature extraction for learning to rank not arising any error if the feature store doesn't exists

2023-03-06 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti reassigned SOLR-15493: --- Assignee: Alessandro Benedetti > Feature extraction for learning to rank not

[jira] [Assigned] (SOLR-16393) Cosmetic, REST-fulness improvements to v2 alias, alias-prop CRUD APIs

2023-03-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16393: -- Assignee: Jason Gerlowski > Cosmetic, REST-fulness improvements to v2 alias, alias-pro

[jira] [Commented] (SOLR-16393) Cosmetic, REST-fulness improvements to v2 alias, alias-prop CRUD APIs

2023-03-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697150#comment-17697150 ] ASF subversion and git services commented on SOLR-16393: Commit e

[GitHub] [solr] gerlowskija merged pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
gerlowskija merged PR #1332: URL: https://github.com/apache/solr/pull/1332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-16686) When using bin/solr zk cp, a non-zk destination requires a path, won't work with bare filename

2023-03-06 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697135#comment-17697135 ] Shawn Heisey commented on SOLR-16686: - Haven't looked at the code yet.  I ran into th

[jira] [Created] (SOLR-16686) When using bin/solr zk cp, a non-zk destination requires a path, won't work with bare filename

2023-03-06 Thread Shawn Heisey (Jira)
Shawn Heisey created SOLR-16686: --- Summary: When using bin/solr zk cp, a non-zk destination requires a path, won't work with bare filename Key: SOLR-16686 URL: https://issues.apache.org/jira/browse/SOLR-16686

[GitHub] [solr] andywebb1975 commented on a diff in pull request #1431: SOLR-16643: Add reRankOperator=multiply/replace options to ReRank query parser

2023-03-06 Thread via GitHub
andywebb1975 commented on code in PR #1431: URL: https://github.com/apache/solr/pull/1431#discussion_r1126991270 ## solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java: ## @@ -68,29 +71,51 @@ public Query parse() throws SyntaxError { Query reRankQuery = reR

[GitHub] [solr] stillalex commented on a diff in pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
stillalex commented on code in PR #1332: URL: https://github.com/apache/solr/pull/1332#discussion_r1126981620 ## solr/core/src/java/org/apache/solr/handler/admin/api/ListAliasesAPI.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [solr] gerlowskija commented on a diff in pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
gerlowskija commented on code in PR #1332: URL: https://github.com/apache/solr/pull/1332#discussion_r1126924886 ## solr/core/src/java/org/apache/solr/handler/admin/api/ListAliasesAPI.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1456812218 Force-pushes also break this really nice UI feature that Github has of, "Only show me what's changed since the last time I posted a review", fwiw. https://user-images.githubusercontent

[GitHub] [solr] gerlowskija commented on pull request #1412: SOLR-16372: Migrate collection listing, deletion to JAX-RS

2023-03-06 Thread via GitHub
gerlowskija commented on PR #1412: URL: https://github.com/apache/solr/pull/1412#issuecomment-1456790149 Alright, this should be ready to go. I'll plan on merging midweek and then backporting later on pending any feedback from folks. -- This is an automated message from the Apache Git Se

[jira] [Commented] (SOLR-16397) Cosmetic, REST-fulness improvements to v2 "core" APIs

2023-03-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697105#comment-17697105 ] Jason Gerlowski commented on SOLR-16397: bq. the Solr tests fail. Not because of

[GitHub] [solr] gerlowskija commented on pull request #1332: SOLR-16393 Cosmetic, REST-fulness improvements to v2 alias, alias-prop

2023-03-06 Thread via GitHub
gerlowskija commented on PR #1332: URL: https://github.com/apache/solr/pull/1332#issuecomment-1456769251 Hey, sorry for the delay in circling back to this @stillalex - will take a look shortly with a mind to commit. https://user-images.githubusercontent.com/9030708/223204161-5349de59-

[GitHub] [solr] gerlowskija closed pull request #1144: SOLR-16488: Create a v2 equivalent for /admin/zookeeper v1 APIs

2023-03-06 Thread via GitHub
gerlowskija closed pull request #1144: SOLR-16488: Create a v2 equivalent for /admin/zookeeper v1 APIs URL: https://github.com/apache/solr/pull/1144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [solr] gerlowskija commented on pull request #1144: SOLR-16488: Create a v2 equivalent for /admin/zookeeper v1 APIs

2023-03-06 Thread via GitHub
gerlowskija commented on PR #1144: URL: https://github.com/apache/solr/pull/1144#issuecomment-1456756246 Alright, closing this out based on its successor PR (#1358) landing and being backported. Thanks for digging in here Josh! -- This is an automated message from the Apache Git Se

[jira] [Resolved] (SOLR-16680) Add JMH benchmark for Solr Startup

2023-03-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16680. Fix Version/s: main (10.0) 9.2 Resolution: Fixed > Add JMH benchm

[jira] [Assigned] (SOLR-16680) Add JMH benchmark for Solr Startup

2023-03-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-16680: -- Assignee: Jason Gerlowski > Add JMH benchmark for Solr Startup > -

[jira] [Commented] (SOLR-16680) Add JMH benchmark for Solr Startup

2023-03-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697098#comment-17697098 ] ASF subversion and git services commented on SOLR-16680: Commit 7

[jira] [Resolved] (SOLR-16488) Migrate ZookeeperReadAPI to JAX-RS

2023-03-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16488. Fix Version/s: main (10.0) 9.2 Resolution: Fixed Thanks all for t

[jira] [Commented] (SOLR-16488) Migrate ZookeeperReadAPI to JAX-RS

2023-03-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697095#comment-17697095 ] ASF subversion and git services commented on SOLR-16488: Commit 8

[jira] [Commented] (SOLR-16462) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2023-03-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697090#comment-17697090 ] ASF subversion and git services commented on SOLR-16462: Commit d

[jira] [Commented] (SOLR-16685) Gradle erroring out with JDK17

2023-03-06 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697069#comment-17697069 ] Kevin Risden commented on SOLR-16685: - What is the output of `./gradlew --version`?

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126768208 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[jira] [Commented] (SOLR-16462) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2023-03-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697035#comment-17697035 ] ASF subversion and git services commented on SOLR-16462: Commit c

[GitHub] [solr] cpoerschke commented on a diff in pull request #1431: SOLR-16643: Add reRankOperator=multiply/replace options to ReRank query parser

2023-03-06 Thread via GitHub
cpoerschke commented on code in PR #1431: URL: https://github.com/apache/solr/pull/1431#discussion_r1126644129 ## solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java: ## @@ -68,29 +71,51 @@ public Query parse() throws SyntaxError { Query reRankQuery = reRan

[GitHub] [solr-operator] HoustonPutman commented on issue #528: Indexing using external Zookeeper - SolrJ

2023-03-06 Thread via GitHub
HoustonPutman commented on issue #528: URL: https://github.com/apache/solr-operator/issues/528#issuecomment-1456355594 So there are three possible solutions here. - You run your indexing code in Kubernetes as well, that way `http://core-solrcloud-0.core-solrcloud-headless.default:8983

[GitHub] [solr-operator] panther999 commented on issue #528: Indexing using external Zookeeper - SolrJ

2023-03-06 Thread via GitHub
panther999 commented on issue #528: URL: https://github.com/apache/solr-operator/issues/528#issuecomment-1456301467 I just tried it - Instead of giving zookeeper I passed service url - but it seems it is internally trying to connect through hostname and throwing below error. `2023-03

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126525931 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType != n

[GitHub] [solr] dsmiley commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
dsmiley commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126492302 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExceptio

[GitHub] [solr-operator] janhoy commented on issue #528: Indexing using external Zookeeper - SolrJ

2023-03-06 Thread via GitHub
janhoy commented on issue #528: URL: https://github.com/apache/solr-operator/issues/528#issuecomment-1456192137 When you are in Kubernetes, your SolrJ won't need to talk to ZK at all, since the URL for Solr is well defined as the Service URL. So try to use the other constructor on `CloudSol

[GitHub] [solr-operator] panther999 opened a new issue, #528: Indexing using external Zookeeper - SolrJ

2023-03-06 Thread via GitHub
panther999 opened a new issue, #528: URL: https://github.com/apache/solr-operator/issues/528 Hello, We are planning to move away from our old solr cluster - and we found this tool. Using Solr-Operator, we were able to deploy solrcluster on aws EKS cluster with external zookeepers. We

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126325809 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126325809 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126325809 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -505,6 +505,9 @@ private NamedList processErrorsAndResponse( if (contentType !=

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126310561 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -268,19 +270,21 @@ public Map getPackagesDeployedAsClusterLevelPlugins MultiValuedMa

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126305516 ## solr/core/src/test/org/apache/solr/cloud/SolrCloudExampleTest.java: ## @@ -222,109 +217,111 @@ protected void doTestDeleteAction(String testCollectionName, String sol

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2023-03-06 Thread via GitHub
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1126287118 ## solr/core/src/java/org/apache/solr/packagemanager/DefaultPackageRepository.java: ## @@ -101,16 +106,21 @@ public Path download(String artifactName) throws SolrExcepti