[GitHub] [solr] solrbot opened a new pull request, #1531: Update io.grpc:grpc-* to v1.54.0

2023-04-01 Thread via GitHub
solrbot opened a new pull request, #1531: URL: https://github.com/apache/solr/pull/1531 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.grpc:grpc-xds](https://togithub.com/grpc/grpc-java) | dependencies | minor | `1.53.0` ->

[GitHub] [solr] solrbot opened a new pull request, #1530: Update dependency org.apache.commons:commons-configuration2 to v2.9.0

2023-04-01 Thread via GitHub
solrbot opened a new pull request, #1530: URL: https://github.com/apache/solr/pull/1530 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| |

[GitHub] [solr] solrbot opened a new pull request, #1529: Update dependency com.jayway.jsonpath:json-path to v2.8.0

2023-04-01 Thread via GitHub
solrbot opened a new pull request, #1529: URL: https://github.com/apache/solr/pull/1529 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.jayway.jsonpath:json-path](https://togithub.com/jayway/JsonPath) | dependencies | minor

[GitHub] [solr] solrbot opened a new pull request, #1528: Update dependency joda-time:joda-time to v2.12.4

2023-04-01 Thread via GitHub
solrbot opened a new pull request, #1528: URL: https://github.com/apache/solr/pull/1528 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [joda-time:joda-time](https://www.joda.org/joda-time/)

[GitHub] [solr] solrbot opened a new pull request, #1527: Update dependency io.swagger.core.v3:swagger-annotations to v2.2.9

2023-04-01 Thread via GitHub
solrbot opened a new pull request, #1527: URL: https://github.com/apache/solr/pull/1527 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.swagger.core.v3:swagger-annotations](https://togithub.com/swagger-api/swagger-core) |

[GitHub] [solr] stillalex commented on pull request #1504: SOLR-7609 ShardSplitTest NPE investigation

2023-04-01 Thread via GitHub
stillalex commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1493173156 updated the patch with a better fix. I'm now using the `isSubShardLeader` flag which seems to have been introduced for the split shard scenario (not sure). will be running some more tests

[jira] [Commented] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707595#comment-17707595 ] ASF subversion and git services commented on SOLR-16649: Commit

[GitHub] [solr] janhoy merged pull request #1526: SOLR-16649 Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread via GitHub
janhoy merged PR #1526: URL: https://github.com/apache/solr/pull/1526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] solrbot commented on pull request #1522: Update dependency org.mockito:mockito-core to v3.12.4

2023-04-01 Thread via GitHub
solrbot commented on PR #1522: URL: https://github.com/apache/solr/pull/1522#issuecomment-1493140985 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

[GitHub] [solr] dsmiley commented on pull request #1450: SOLR-16693: timeAllowed: use more efficient TimeLimitingBulkScorer

2023-04-01 Thread via GitHub
dsmiley commented on PR #1450: URL: https://github.com/apache/solr/pull/1450#issuecomment-1493135072 I plan to merge end of Monday or so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] dsmiley commented on a diff in pull request #1360: SOLR 16642 : upgrade Solr to use Lucene 9.5.0

2023-04-01 Thread via GitHub
dsmiley commented on code in PR #1360: URL: https://github.com/apache/solr/pull/1360#discussion_r1155160754 ## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ## @@ -370,6 +380,12 @@ public TopDocs searchNearestVectors( return null; } +

[GitHub] [solr] janhoy opened a new pull request, #1526: SOLR-16649 Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread via GitHub
janhoy opened a new pull request, #1526: URL: https://github.com/apache/solr/pull/1526 https://issues.apache.org/jira/browse/SOLR-16649 Backport... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16649: --- Fix Version/s: 9.3 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707578#comment-17707578 ] ASF subversion and git services commented on SOLR-16649: Commit

[GitHub] [solr] janhoy merged pull request #1514: SOLR-16649 Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread via GitHub
janhoy merged PR #1514: URL: https://github.com/apache/solr/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (SOLR-16732) Misc SonarQube findings

2023-04-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16732: Status: Patch Available (was: Open) > Misc SonarQube findings > --- > >

[jira] [Comment Edited] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707566#comment-17707566 ] Thomas Wöckinger edited comment on SOLR-16728 at 4/1/23 4:55 PM: - I

[jira] [Commented] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707566#comment-17707566 ] Thomas Wöckinger commented on SOLR-16728: - I search for a different

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1525: SOLR-16732: misc sonar fixes

2023-04-01 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1525: URL: https://github.com/apache/solr/pull/1525#discussion_r1155139851 ## solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java: ## @@ -190,7 +190,7 @@ public static void clearSolrDisableShardsWhitelist()

[jira] [Commented] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707565#comment-17707565 ] Thomas Wöckinger commented on SOLR-16728: - Removing them from the WEB-INF/lib directory will

[GitHub] [solr] solrbot commented on pull request #1519: Update dependency net.bytebuddy:byte-buddy to v1.14.2

2023-04-01 Thread via GitHub
solrbot commented on PR #1519: URL: https://github.com/apache/solr/pull/1519#issuecomment-1493036839 ### Renovate Ignore Notification As this PR has been closed unmerged, Renovate will now ignore this update (1.14.2). You will still receive a PR once a newer version is released, so

[jira] [Comment Edited] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707563#comment-17707563 ] Thomas Wöckinger edited comment on SOLR-16728 at 4/1/23 4:03 PM: - i was

[jira] [Commented] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707563#comment-17707563 ] Thomas Wöckinger commented on SOLR-16728: - i was doing a quick search with find -name "*alpn*"

[jira] [Comment Edited] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707562#comment-17707562 ] Thomas Wöckinger edited comment on SOLR-16728 at 4/1/23 3:55 PM: - No,

[jira] [Commented] (SOLR-16728) ClassCastException while creating new collection using JDK17

2023-04-01 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707562#comment-17707562 ] Thomas Wöckinger commented on SOLR-16728: - No, just downloaded the tgz after release, extracted

[GitHub] [solr] risdenk closed pull request #1519: Update dependency net.bytebuddy:byte-buddy to v1.14.2

2023-04-01 Thread via GitHub
risdenk closed pull request #1519: Update dependency net.bytebuddy:byte-buddy to v1.14.2 URL: https://github.com/apache/solr/pull/1519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] risdenk commented on pull request #1522: Update dependency org.mockito:mockito-core to v3.12.4

2023-04-01 Thread via GitHub
risdenk commented on PR #1522: URL: https://github.com/apache/solr/pull/1522#issuecomment-1493004423 Remove byte-buddy from versions.props - https://github.com/apache/solr/pull/1519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] risdenk opened a new pull request, #1525: SOLR-16732: misc sonar fixes

2023-04-01 Thread via GitHub
risdenk opened a new pull request, #1525: URL: https://github.com/apache/solr/pull/1525 https://issues.apache.org/jira/browse/SOLR-16732 * String non regex replaceAll with replace * indexOf -> contains * NBSP in log * unindented if statements missing {} * Use && instead of

[jira] [Updated] (SOLR-16732) Misc SonarQube findings

2023-04-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16732: Description: I have been running SonarQube against the Solr project and there are some low

[jira] [Updated] (SOLR-16732) Misc SonarQube findings

2023-04-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16732: Description: I have been running SonarQube against the Solr project and there are some low

[jira] [Updated] (SOLR-16732) Misc SonarQube findings

2023-04-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16732: Description: I have been running SonarQube against the Solr project and there are some low

[jira] [Created] (SOLR-16732) Misc SonarQube findings

2023-04-01 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16732: --- Summary: Misc SonarQube findings Key: SOLR-16732 URL: https://issues.apache.org/jira/browse/SOLR-16732 Project: Solr Issue Type: Task Security Level:

[jira] [Updated] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-04-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16649: Status: Patch Available (was: Open) > Http2SolrClient.processErrorsAndResponse uses wrong

[GitHub] [solr] risdenk commented on a diff in pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-04-01 Thread via GitHub
risdenk commented on code in PR #1501: URL: https://github.com/apache/solr/pull/1501#discussion_r1155113686 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/MinimizeCoresPlacementFactory.java: ## @@ -123,20 +123,23 @@ public List computePlacements( //

[GitHub] [solr] risdenk commented on a diff in pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-04-01 Thread via GitHub
risdenk commented on code in PR #1501: URL: https://github.com/apache/solr/pull/1501#discussion_r1155113182 ## solr/solrj/src/java/org/apache/solr/common/util/StrUtils.java: ## @@ -363,4 +366,16 @@ public static String formatString(String pattern, Object... args) { public

[GitHub] [solr] risdenk commented on pull request #1513: SOLR-15703: replace all SolrException.log usage in Solr to just call log.error(...) directly

2023-04-01 Thread via GitHub
risdenk commented on PR #1513: URL: https://github.com/apache/solr/pull/1513#issuecomment-1492972186 There are a bunch of outstanding no error message logs as well: ``` # git grep -F 'log.error(""' solr/core/src/java/org/apache/solr/cloud/Overseer.java: log.error("",