[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2023-06-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731916#comment-17731916 ] ASF subversion and git services commented on SOLR-16812: Commit 2

[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2023-06-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731915#comment-17731915 ] ASF subversion and git services commented on SOLR-16812: Commit 8

[GitHub] [solr] noblepaul closed pull request #1703: Support CBOR format

2023-06-12 Thread via GitHub
noblepaul closed pull request #1703: Support CBOR format URL: https://github.com/apache/solr/pull/1703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2023-06-12 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731883#comment-17731883 ] Noble Paul commented on SOLR-16812: --- I think we should just comment out these assertion

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1705: SOLR-16841 QueryResponseWriter benchmarks

2023-06-12 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1705: URL: https://github.com/apache/solr/pull/1705#discussion_r1227530835 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/NoOpResponseParser.java: ## @@ -66,7 +66,7 @@ public NamedList processResponse(Reader reader) { publ

[jira] [Commented] (SOLR-16841) QueryResponseWriter benchmarks

2023-06-12 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731859#comment-17731859 ] Alex Deparvu commented on SOLR-16841: - [~ichattopadhyaya] I pushed the benckmars prop

[GitHub] [solr] stillalex opened a new pull request, #1705: SOLR-16841 QueryResponseWriter benchmarks

2023-06-12 Thread via GitHub
stillalex opened a new pull request, #1705: URL: https://github.com/apache/solr/pull/1705 https://issues.apache.org/jira/browse/SOLR-16841 Proposing some benchmarks for the various QueryResponseWriter options Running benchmark ``` ./jmh.sh QueryResponseWriters ```

[GitHub] [solr] solrbot closed pull request #1700: Update dependency org.xerial.snappy:snappy-java to v1.1.10.0 - autoclosed

2023-06-12 Thread via GitHub
solrbot closed pull request #1700: Update dependency org.xerial.snappy:snappy-java to v1.1.10.0 - autoclosed URL: https://github.com/apache/solr/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (SOLR-16812) Support CBOR format for update/query

2023-06-12 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731807#comment-17731807 ] Chris M. Hostetter commented on SOLR-16812: --- {{TestCborDataFormat}} has been fa

[jira] [Created] (SOLR-16844) Optionally skip backup of Configset files

2023-06-12 Thread Tomas Eduardo Fernandez Lobbe (Jira)
Tomas Eduardo Fernandez Lobbe created SOLR-16844: Summary: Optionally skip backup of Configset files Key: SOLR-16844 URL: https://issues.apache.org/jira/browse/SOLR-16844 Project: Solr

[GitHub] [solr] HoustonPutman commented on pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on PR #1650: URL: https://github.com/apache/solr/pull/1650#issuecomment-1588135823 Thanks for the review Radu! > I saw a "parallel" flag, but I think replicas are moved one at a time, correct? If so, it will likely prove to be a bottleneck down the road.

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1692: SOLR-16827: Add min/max scaling to the reranker

2023-06-12 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1692: URL: https://github.com/apache/solr/pull/1692#discussion_r1227251140 ## solr/core/src/java/org/apache/solr/search/ReRankWeight.java: ## @@ -24,24 +24,65 @@ import org.apache.lucene.search.Query; import org.apache.lucene.search.

[jira] [Commented] (SOLR-16827) Add min/max scaling to the reranker

2023-06-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731768#comment-17731768 ] ASF subversion and git services commented on SOLR-16827: Commit 7

[GitHub] [solr] mlbiscoc commented on pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-12 Thread via GitHub
mlbiscoc commented on PR #1704: URL: https://github.com/apache/solr/pull/1704#issuecomment-1587870428 @gerlowskija Could you take a look at this PR when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] mlbiscoc opened a new pull request, #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: Get Filelist

2023-06-12 Thread via GitHub
mlbiscoc opened a new pull request, #1704: URL: https://github.com/apache/solr/pull/1704 https://issues.apache.org/jira/browse/SOLR-16470 # Description Create a V2 equivalent API for the replication "GET filelist" V1 `/solr/{coreName}/replication?command=fi

[GitHub] [solr] radu-gheorghe commented on pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
radu-gheorghe commented on PR #1650: URL: https://github.com/apache/solr/pull/1650#issuecomment-1587759700 Awesome stuff, @HoustonPutman! Unfortunately, I think it's too much for me to really understand everything your code does, so I'll add some higher-level comments here instead. I hope t

[GitHub] [solr-sandbox] markrmiller merged pull request #61: Add additional unsupported options for delete-by-query.

2023-06-12 Thread via GitHub
markrmiller merged PR #61: URL: https://github.com/apache/solr-sandbox/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226903265 ## solr/core/src/java/org/apache/solr/cluster/placement/impl/BalancePlanFactoryImpl.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr-sandbox] markrmiller commented on pull request #61: Add additional unsupported options for delete-by-query.

2023-06-12 Thread via GitHub
markrmiller commented on PR #61: URL: https://github.com/apache/solr-sandbox/pull/61#issuecomment-1587643820 I'm not going to factor out a common base test class in this wip branch, we can do that in main. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226897201 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226896752 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226892527 ## solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java: ## @@ -85,5 +104,80 @@ List computePlacements( */ default void verifyAllowedModi

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226879953 ## solr/core/src/test/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactoryTest.java: ## @@ -1443,60 +1445,6 @@ private void testSpreadDomains(boolean

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226879328 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -451,6 +451,21 @@ List assign( SolrCloudManager solrCloudManager, List assign

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226878099 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -0,0 +1,604 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226878640 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -0,0 +1,604 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226875203 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -0,0 +1,604 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226874002 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/SimplePlacementFactory.java: ## @@ -53,118 +43,116 @@ public PlacementPlugin createPluginInstance() {

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1703: Support CBOR format

2023-06-12 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1703: URL: https://github.com/apache/solr/pull/1703#discussion_r1226866875 ## dev-tools/scripts/smokeTestRelease.py: ## @@ -537,106 +521,97 @@ def getDirEntries(urlString): return l else: links = getHREFs(urlString) -f

[GitHub] [solr] gerlowskija commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
gerlowskija commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224352496 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [solr] noblepaul opened a new pull request, #1703: Support CBOR format

2023-06-12 Thread via GitHub
noblepaul opened a new pull request, #1703: URL: https://github.com/apache/solr/pull/1703 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[jira] [Created] (SOLR-16843) timestamp issue with autoscaling framework

2023-06-12 Thread Pierre Salagnac (Jira)
Pierre Salagnac created SOLR-16843: -- Summary: timestamp issue with autoscaling framework Key: SOLR-16843 URL: https://issues.apache.org/jira/browse/SOLR-16843 Project: Solr Issue Type: Bug

[GitHub] [solr] janhoy commented on pull request #1670: SOLR-16829: Delegate arg parsing and help usage to java. (Round 1)

2023-06-12 Thread via GitHub
janhoy commented on PR #1670: URL: https://github.com/apache/solr/pull/1670#issuecomment-1587234842 > So... I'm starting to think this is a Solr 10 only change... There are so many small cleanups and other awkwardnesses in the CLI, that making it work in Solr 9 is going to cause a LOT of fo

[GitHub] [solr] epugh commented on pull request #1670: SOLR-16829: Delegate arg parsing and help usage to java. (Round 1)

2023-06-12 Thread via GitHub
epugh commented on PR #1670: URL: https://github.com/apache/solr/pull/1670#issuecomment-1587223833 So... I'm starting to think this is a Solr 10 only change... There are so many small cleanups and other awkwardnesses in the CLI, that making it work in Solr 9 is going to cause a LOT of f

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

2023-06-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731580#comment-17731580 ] ASF subversion and git services commented on SOLR-16507: Commit d

[GitHub] [solr] noblepaul merged pull request #1702: SOLR-16507:Remove NodeStateProvider & Snitch ported to 9x

2023-06-12 Thread via GitHub
noblepaul merged PR #1702: URL: https://github.com/apache/solr/pull/1702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] janhoy commented on pull request #1650: SOLR-16806: Create a BalanceReplicas API

2023-06-12 Thread via GitHub
janhoy commented on PR #1650: URL: https://github.com/apache/solr/pull/1650#issuecomment-1587155169 Excited to see this balance API taking shape. Won't have a chance to review now, but following along from the sideline. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [solr] noblepaul opened a new pull request, #1702: SOLR-16507:Remove NodeStateProvider & Snitch ported to 9x

2023-06-12 Thread via GitHub
noblepaul opened a new pull request, #1702: URL: https://github.com/apache/solr/pull/1702 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

2023-06-12 Thread via GitHub
alessandrobenedetti commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1226373016 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field) throws Solr