[
https://issues.apache.org/jira/browse/SOLR-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752547#comment-17752547
]
Eric Pugh commented on SOLR-16876:
--
I am not sure how to handle the logic in bin/solr ar
epugh opened a new pull request, #1833:
URL: https://github.com/apache/solr/pull/1833
https://issues.apache.org/jira/browse/SOLR-16876
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a
[
https://issues.apache.org/jira/browse/SOLR-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752538#comment-17752538
]
Eric Pugh commented on SOLR-16821:
--
The AuthTool has ensureArgumentIsValidBooleanIfPrese
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752529#comment-17752529
]
David Smiley commented on SOLR-16415:
-
If you are running Solr 8, then furthermore lo
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752527#comment-17752527
]
David Smiley commented on SOLR-16415:
-
There is a PR; peer-review would be helpful.
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752526#comment-17752526
]
Rajeswari Natarajan commented on SOLR-16415:
[~dsmiley] , is it possible to c
[
https://issues.apache.org/jira/browse/SOLR-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16876:
Assignee: Eric Pugh
> Delegate Arg parsing for AuthTool to SolrCLI
> -
mkhludnev commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-1672151355
Hi, @epugh.
I started to explore this branch. Here we go:
```
\dev-slim>bin\solr
...
Pass -help after any COMMAND to see command-specific usage information,
such as:
[
https://issues.apache.org/jira/browse/SOLR-16910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752513#comment-17752513
]
David Smiley commented on SOLR-16910:
-
{quote} * new class wouldn't do any actual log
[
https://issues.apache.org/jira/browse/SOLR-16923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16923.
-
Resolution: Invalid
When you created this issue, I think you missed the bold red text at the top:
dsmiley commented on PR #1832:
URL: https://github.com/apache/solr/pull/1832#issuecomment-1672091470
Confusingly, we don't use the Java SecurityManager in tests for "Security".
We use it to enforce file system rules in our tests to enforce best-practices.
This ensures we don't waste time
dsmiley commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1289128149
##
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##
@@ -506,30 +507,23 @@ private static NamedList
waitForCoreAdminAsyncCallToCom
dsmiley commented on PR #1761:
URL: https://github.com/apache/solr/pull/1761#issuecomment-1671963201
I like Alex's idea of a second thread pool / executor; I think it would mean
we would not need the explicit expensiveTaskQueue that is fiddly to work with
and could rely on the more familiar
psalagnac commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1289053033
##
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##
@@ -506,30 +507,23 @@ private static NamedList
waitForCoreAdminAsyncCallToC
dsmiley commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1289046189
##
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##
@@ -506,30 +507,23 @@ private static NamedList
waitForCoreAdminAsyncCallToCom
risdenk commented on PR #1832:
URL: https://github.com/apache/solr/pull/1832#issuecomment-1671908610
> "false sense of security" thing
false sense of security - My poor wording since we are working around
security manager. I mean that we shouldn't even run the tests at all. Disabling
gerlowskija commented on PR #1832:
URL: https://github.com/apache/solr/pull/1832#issuecomment-1671886686
> this just seems like a terrible way to do this. We shouldn't even run
tests this way on Mac. It gives a false sense of security that things are
working when they really aren't.
stillalex commented on PR #1831:
URL: https://github.com/apache/solr/pull/1831#issuecomment-1671627980
thank you for the review @epugh. will leave this open for a bit more, if no
other comments will merge it as is. we can rename later if anyone finds a
better name for this config class.
-
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752431#comment-17752431
]
ASF subversion and git services commented on SOLR-16825:
Commit 4
psalagnac commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1288526660
##
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##
@@ -506,30 +507,23 @@ private static NamedList
waitForCoreAdminAsyncCallToC
psalagnac commented on PR #1761:
URL: https://github.com/apache/solr/pull/1761#issuecomment-1671353210
> Any thoughts on how this bug slipped by our notice?
I was unable to write a unit that actually do an expensive operation (backup
or restore). The low-level queue mechanism is well
Hariprasad T created SOLR-16923:
---
Summary: Open JDK with solr compatibility
Key: SOLR-16923
URL: https://issues.apache.org/jira/browse/SOLR-16923
Project: Solr
Issue Type: Task
Security
janhoy commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-167041
> > Also feel free to add a line to CHANGES.txt, giving yourself credit
>
> Is it ok if I added this ticket under bug section?
Yes I believe that is appropriate
--
This is an a
23 matches
Mail list logo
