xtenzQ commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1681600877
@janhoy I've begun to question whether my current solution is more of a
workaround rather than an actual resolution that eliminates the problem.
To be honest, there are certain aspects
[ https://issues.apache.org/jira/browse/SOLR-6853 ]
Nikita Rusetskii deleted comment on SOLR-6853:
was (Author: JIRAUSER301650):
[~janhoy], I have left a comment on the [pull
request|https://github.com/apache/solr/pull/1829] regarding poten
stillalex merged PR #1846:
URL: https://github.com/apache/solr/pull/1846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
stillalex commented on PR #1846:
URL: https://github.com/apache/solr/pull/1846#issuecomment-1681576553
@janhoy just fyi. do you think it's worth backporting this to 9.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1681573914
moved the simple otel update to https://github.com/apache/solr/pull/1846
will rebase once that is in
--
This is an automated message from the Apache Git Service.
To respond to the messag
stillalex opened a new pull request, #1846:
URL: https://github.com/apache/solr/pull/1846
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
[
https://issues.apache.org/jira/browse/SOLR-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755337#comment-17755337
]
Nikita Rusetskii edited comment on SOLR-6853 at 8/17/23 3:09 AM:
---
[
https://issues.apache.org/jira/browse/SOLR-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755337#comment-17755337
]
Nikita Rusetskii commented on SOLR-6853:
[~janhoy], I have left a comment on the p
xtenzQ commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1681450555
@janhoy I've begun to question whether my current solution is more of a
workaround rather than an actual solution.
I've been contemplating recently how to create a universal solution fo
noblepaul opened a new pull request, #1845:
URL: https://github.com/apache/solr/pull/1845
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1681360684
Yes, splitting out the otel version upgrade is a good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16929:
Description:
The exception message included by the SolrStream can sometimes be the encoded
(javabi
[
https://issues.apache.org/jira/browse/SOLR-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16929:
Description:
The exception message included by the SolrStream can sometimes be the encoded
(javabi
[
https://issues.apache.org/jira/browse/SOLR-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755263#comment-17755263
]
ASF subversion and git services commented on SOLR-16928:
Commit 0
mkhludnev merged PR #1844:
URL: https://github.com/apache/solr/pull/1844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
stillalex merged PR #1838:
URL: https://github.com/apache/solr/pull/1838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
stillalex commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1296299519
##
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##
@@ -96,6 +120,22 @@ public static int getErrorInfo(Throwable ex,
NamedList info, Logger log)
*
stillalex merged PR #1840:
URL: https://github.com/apache/solr/pull/1840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-16859.
-
Fix Version/s: 9.4
Assignee: Alex Deparvu
Resolution: Fixed
> Missing Proxy suppo
[
https://issues.apache.org/jira/browse/SOLR-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755209#comment-17755209
]
ASF subversion and git services commented on SOLR-16859:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755208#comment-17755208
]
ASF subversion and git services commented on SOLR-16859:
Commit 2
stillalex merged PR #1779:
URL: https://github.com/apache/solr/pull/1779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
stillalex commented on PR #1779:
URL: https://github.com/apache/solr/pull/1779#issuecomment-1681033327
re. SSL testing. it is very difficult to setup the exiting proxy server for
this test, I think it does not actually support SSL. I've sent an email to dev
list to ask for more help. @risde
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680999594
quick smoke test on benchmarking side, I tried running the existing
`CloudIndexing` benchmark and numbers seem pretty close (I am sure there are
more opportunities for improvement but I di
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1296183918
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software F
Raghavan1988 closed pull request #1843: SOLR-16925 Fixing broken JSON
indentation using JacksonJsonWriter
URL: https://github.com/apache/solr/pull/1843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Raghavan1988 commented on PR #1843:
URL: https://github.com/apache/solr/pull/1843#issuecomment-1680936909
Thanks @noblepaul ! apologies. I mixed up multiple bug fixes into this PR.
let me withdraw this PR
--
This is an automated message from the Apache Git Service.
To respond to the messa
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1296170780
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -847,9 +851,11 @@ protected String generateAuthDataHeader() {
Map data = new H
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1296161226
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -847,9 +851,11 @@ protected String generateAuthDataHeader() {
Map data = new H
janhoy commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1296130713
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHas
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1296094876
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software F
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680832985
> Would you like to give the docs a shot @stillalex ? Also, please add a
line to CHANGES.txt.
@janhoy updated, please take a look.
Just to run one idea by you: the otel librar
epugh commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1296072822
##
solr/webapp/web/js/angular/controllers/login.js:
##
@@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController',
var hp = AuthenticationService.decodeHash
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1296026006
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software F
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1296026006
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software F
stillalex commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1296026006
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software F
[
https://issues.apache.org/jira/browse/SOLR-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev reassigned SOLR-16928:
---
Assignee: Mikhail Khludnev
> Add missing unit tests for utilities in solr-core
> ---
mkhludnev opened a new pull request, #1844:
URL: https://github.com/apache/solr/pull/1844
…oLower (#1837)
* SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower
* SOLR-16928: Add license to RegexFileFilterTest
https://issues.apache.org/jira/browse/S
[
https://issues.apache.org/jira/browse/SOLR-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755062#comment-17755062
]
ASF subversion and git services commented on SOLR-16928:
Commit e
mkhludnev merged PR #1837:
URL: https://github.com/apache/solr/pull/1837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
[
https://issues.apache.org/jira/browse/SOLR-16939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul reassigned SOLR-16939:
-
Assignee: Noble Paul
> CBOR format should support nested documents
> --
janhoy commented on issue #600:
URL: https://github.com/apache/solr-operator/issues/600#issuecomment-1680381244
> Do we have input from the zookeeper community about their preferred or
recommended approach?
Who/where do you want to ask? The Zookeeper project does not do any Docker
st
[
https://issues.apache.org/jira/browse/SOLR-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-16896:
--
Assignee: Jan Høydahl
> add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)
>
[
https://issues.apache.org/jira/browse/SOLR-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-6853:
-
Assignee: Jan Høydahl
> solr.ManagedSynonymFilterFactory/ManagedStopwordFilterFactory: URLEncodin
janhoy commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1680370856
I believe there is no documentation needed since this is a bug fix?
@gerlowskija any comments before I merge?
--
This is an automated message from the Apache Git Service.
To respond t
Noble Paul created SOLR-16939:
-
Summary: CBOR format should support nested documents
Key: SOLR-16939
URL: https://issues.apache.org/jira/browse/SOLR-16939
Project: Solr
Issue Type: Task
Se
noblepaul commented on PR #1843:
URL: https://github.com/apache/solr/pull/1843#issuecomment-1680315689
This is not fixing the indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680314430
Wrt documentation. As long as the user-facing config and env vars are the
same, and the spans created are almost identical, I think the only Ref-guide
documentation to add is in "Major change
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295650436
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foun
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295650436
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foun
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680279442
I reproduced the thread leak locally, but it does not happen every time.
Also, the new Crave test run was successful. Looks like there is a timing
issue. @stillalex how is the tracer life cyc
janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1295565981
##
solr/core/src/java/org/apache/solr/core/TracerConfigurator.java:
##
@@ -17,83 +17,88 @@
package org.apache.solr.core;
-import io.opentracing.Scope;
-import io.opent
Jan Høydahl created SOLR-16938:
--
Summary: Auto configure tracer without a tag in
solr.xml
Key: SOLR-16938
URL: https://issues.apache.org/jira/browse/SOLR-16938
Project: Solr
Issue Type: Sub-ta
janhoy commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680170683
> if this is for 2 fields only (`http.status_code` =>
`http.response.status_code` and `http.method` => `http.request.method`) it
feels like overkill to implement this mechanism. I would emit
54 matches
Mail list logo
