renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1700433722
i don't see whats why the Precommit is complaining about
SpellCheckComponent.java, I did run tidy again, and no changes appear.
--
This is an automated message from the Apache Git Service.
dustinpeerce commented on PR #1872:
URL: https://github.com/apache/solr/pull/1872#issuecomment-1700270234
@mkhludnev Created cherry-pick PR:
[1874](https://github.com/apache/solr/pull/1874)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
magibney commented on code in PR #1351:
URL: https://github.com/apache/solr/pull/1351#discussion_r1311015770
##
solr/test-framework/src/java/org/apache/solr/util/TestHarness.java:
##
@@ -186,6 +187,9 @@ public TestHarness(NodeConfig config, CoresLocator
coresLocator) {
}
dustinpeerce opened a new pull request, #1874:
URL: https://github.com/apache/solr/pull/1874
(cherry picked from commit
[`4d656c5`](https://github.com/apache/solr/commit/4d656c5ef845912f54eb7b0f7936491e680cac55))
--
This is an automated message from the Apache Git Service.
To respond to t
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1699944570
Added a 'TraceAwareCommand' wrapper that covers most of the internal
commands. will also generate a new trace if there isn't one. the only part that
is not correct is the SimplePropagator,
laminelam commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1699940578
> * Add refguide docs
> * CHANGES entry
> * Constant naming
> * Backend part of CSP header
Will the CHANGEs entry.
Here are the main changes to the patch:
- In line
laminelam commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1699933444
> > > Eager to get this into 9.4. Let me know if we can help finalizing
these two PRs
> >
> >
> > @janhoy I should push a new commit sometime today. I have changed little
bit yo
dsmiley commented on code in PR #1351:
URL: https://github.com/apache/solr/pull/1351#discussion_r1310891181
##
solr/test-framework/src/java/org/apache/solr/util/TestHarness.java:
##
@@ -186,6 +187,9 @@ public TestHarness(NodeConfig config, CoresLocator
coresLocator) {
}
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1310887235
##
solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc:
##
@@ -85,6 +85,8 @@ jwk ; As an alternative to `jwksUrl` you may
dsmiley commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1699913844
> this time I am also attempting to create a span if it does not exist.
IMO I think we should only initiate traces at entry points
(SolrDispatchFilter) or maybe other moments we expli
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1310867905
##
solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc:
##
@@ -85,6 +85,8 @@ jwk ; As an alternative to `jwksUrl` you may
pr
[
https://issues.apache.org/jira/browse/SOLR-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760617#comment-17760617
]
ASF subversion and git services commented on SOLR-16654:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760615#comment-17760615
]
ASF subversion and git services commented on SOLR-16654:
Commit 2
magibney merged PR #1351:
URL: https://github.com/apache/solr/pull/1351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
Eric Pugh created SOLR-16956:
Summary: bin/solr stop -p doesn't work
Key: SOLR-16956
URL: https://issues.apache.org/jira/browse/SOLR-16956
Project: Solr
Issue Type: Sub-task
Components:
epugh commented on PR #1851:
URL: https://github.com/apache/solr/pull/1851#issuecomment-1699663219
Okay, I didn't realize the superadmin doesn't extend admin extend
search/index, instead you have to assign all of them...
I wonder if we should map alll roles to superadmin, some roles t
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1699695874
@madrob I might have been wrong with the static code analysis, looks like it
is even a compiler warning:
 under one or more
+
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1699663446
> This is a tricky decision, changing behavior to match the documentation.
Is it a breaking change or not?
Note that the "pluggable" CBs are not yet released, so if we can get this
fix in
dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1310619260
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -32,7 +33,7 @@ public static void setDbInstance(SolrQueryRequest req, String
coreOrColl) {
}
dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1310618039
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1310615888
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
wrunderwood commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1699585220
@janhoy Thanks so much for picking this up.
I'll take a look at the compromise. This is a tricky decision, changing
behavior to match the documentation. Is it a breaking change or not
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1699562192
@wrunderwood I pushed a few fixes related to my own recent changes. But I'll
leave you in the drivers seat for this PR again, if you want to.
--
This is an automated message from the Apache Git
madrob commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1699566197
Which static code analysis reports on this? Can we add this inspection to
our build so that we don't regress on it in the future?
--
This is an automated message from the Apache Git Service
cpoerschke commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310558195
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codah
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310587960
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codahale.
HoustonPutman opened a new pull request, #614:
URL: https://github.com/apache/solr-operator/pull/614
There was a bug introduced at some point, that once a deletion of a node was
determined, if there was an error while moving replicas off of the node, then
the operator was likely to delete t
cpoerschke commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310541536
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java:
##
@@ -86,7 +86,8 @@ public void init(NamedList args) {
memCB.setThreshold(memT
cpoerschke commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310549161
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -96,11 +91,46 @@ public String getErrorMessage() {
+ allowedCPUUsage.get();
cpoerschke commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310547379
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codah
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16955:
Description:
Tracing for v2 apis will eagerly consume the contentstream to find a good name
for th
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16955:
Priority: Blocker (was: Minor)
> Tracing v2 apis breaks SecurityConfHandler
>
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760524#comment-17760524
]
Alex Deparvu commented on SOLR-16955:
-
you are right Jan. I wanted to validate this a
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16955:
Fix Version/s: 9.4
> Tracing v2 apis breaks SecurityConfHandler
> -
[
https://issues.apache.org/jira/browse/SOLR-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760409#comment-17760409
]
Eric Pugh commented on SOLR-10772:
--
I am waiting for the SolrJ client to be able to use
janhoy commented on PR #428:
URL: https://github.com/apache/solr/pull/428#issuecomment-1699161604
@elyograg and @gus-asf Please add your concrete code reviews to this PR so
we can aim for completion.
The important part is to test on major Linux flavors and spot bugs. In the
PR descri
janhoy commented on PR #1829:
URL: https://github.com/apache/solr/pull/1829#issuecomment-1699144140
So any suggestions on completing this?
The pragmatic side of me says merge a working bugfix, even if not optimal.
The more thorugh side says dive deep to investigate whether Jett
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1699134153
@dsmiley I am seeing some weirdness and wanted to check with you.
from the `InheritableThreadLocalProvider#store` javadocs:
```
This is invoked in the parent thread which subm
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1699111725
Will soon need a rebase and force-push to make crave tests happy. But will
wait a bit for more review comments, and so that it is easier to view the
changes since 2 years ago...
--
This is an
[
https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760356#comment-17760356
]
Jan Høydahl commented on SOLR-16955:
This should probably be a blocker for 9.4 ?
> T
epugh commented on PR #1872:
URL: https://github.com/apache/solr/pull/1872#issuecomment-1699058232
Thanks @dustinpeerce ! Doc fixes are so important!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
mkhludnev commented on PR #1872:
URL: https://github.com/apache/solr/pull/1872#issuecomment-1699057850
Thanks you, Dustin.
Would you mind to create cherry-picking PR to branch_9x ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mkhludnev merged PR #1872:
URL: https://github.com/apache/solr/pull/1872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310168797
##
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java:
##
@@ -193,6 +195,55 @@ public void testFakeCPUCircuitBreaker() {
}
}
+ public void testFakeL
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310122961
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/LoadAverageCircuitBreaker.java:
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
cpoerschke commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1310115919
##
solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java:
##
@@ -49,6 +56,21 @@ public void init(NamedList args) {
@Override
public void hand
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310120363
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java:
##
@@ -40,12 +41,15 @@
* solution. There will be a follow up with a SIP for a schema API
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310118157
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -110,6 +113,27 @@ public double getCpuUsageThreshold() {
}
protected double calc
[
https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760285#comment-17760285
]
Jan Høydahl commented on SOLR-15056:
Hi. I chatted with Atri and he's OK with me pick
[
https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-15056:
--
Assignee: Jan Høydahl (was: Atri Sharma)
> CPU circuit breaker needs to use CPU utilization,
[
https://issues.apache.org/jira/browse/SOLR-14755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760279#comment-17760279
]
Jan Høydahl commented on SOLR-14755:
[~atri] I had a look at the code around this. Th
janhoy commented on PR #1871:
URL: https://github.com/apache/solr/pull/1871#issuecomment-1698672344
@dsmiley This is the pr for update request circuit breaking. Please have a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
54 matches
Mail list logo
