stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1699134153
@dsmiley I am seeing some weirdness and wanted to check with you.
from the `InheritableThreadLocalProvider#store` javadocs:
```
This is invoked in the parent thread which submitted a task. copy the
necessary Objects to the ctx. The object that is passed is same across all
three methods
```
but it's not what I am seeing testing locally
```
INFO (qtp605101809-26) [t:ed7a6af8e4d1a260a125b601a5893adc c:test s:shard1
r:core_node4 x:test_shard1_replica_n2] o.a.s.c.S.Request webapp=/solr
path=/select
params={df=_text_&distrib=false&fl=id&fl=score&shards.purpose=16388&start=0&fsv=true&q.op=OR&rows=10&rid=localhost-0&version=2&q=*:*&omitHeader=false&NOW=1693399732700&isShard=true&wt=javabin&useParams=&_=1693398636818}
hits=0 status=0 QTime=6
2023-08-30 05:48:52.738 INFO (httpShardExecutor-7-thread-1) []
o.a.s.c.TracerConfigurator CTLP STORE {}
2023-08-30 05:48:52.738 INFO (httpShardExecutor-7-thread-5) []
o.a.s.c.TracerConfigurator CTLP SET OTEL missing span
```
the trace id is there, you can see it in the line above, but the thread
local provider calls store on a pool thread instead of the main thread, as I
would have expected. and just looking at the code, the entire mechanism happens
on `execute` call which is not guaranteed to be called in a specific thread.
did this context injection mechanism break recently, or was it always like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
