dsmiley commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1714888248
It's sad to see so much ceremony in NodeConfig :-( -- an issue for another
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dsmiley commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1322296243
##
solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1714858621
@dsmiley was there anything more you wanted to cover here or could we merge?
re. backport to 9.x branch. I think the complexity is pretty high, it
deserves a dedicated PR for 9.x branch
patsonluk commented on PR #1143:
URL: https://github.com/apache/solr/pull/1143#issuecomment-1714784748
Mismatching node name could happen when `-Dhost` is used, under such
circumstances, it is desirable to publish a down state with the updated node
name (this probably explains the
[check](
patsonluk closed pull request #1143: SOLR-16506: Throws exception on core
startup for node name mismatch
URL: https://github.com/apache/solr/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763967#comment-17763967
]
ASF subversion and git services commented on SOLR-16970:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763965#comment-17763965
]
ASF subversion and git services commented on SOLR-16970:
Commit 6
HoustonPutman merged PR #1913:
URL: https://github.com/apache/solr/pull/1913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
patsonluk closed pull request #1438: SOLR-16690: enqueueUpdate should execute
callback even if cmds is empty or noop
URL: https://github.com/apache/solr/pull/1438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
patsonluk commented on PR #1438:
URL: https://github.com/apache/solr/pull/1438#issuecomment-1714685834
Closing this as the proposed change can introduce incorrect behavior. For
example, if there's already pending changes in the `ZkStateWriter`, and a no op
changes invocation to `enqueueUpda
laminelam commented on code in PR #1791:
URL: https://github.com/apache/solr/pull/1791#discussion_r1322136364
##
solr/webapp/web/js/angular/services.js:
##
@@ -286,8 +286,74 @@ solrAdminServices.factory('System',
})
}])
.factory('AuthenticationService',
-['base64'
solrbot commented on PR #1769:
URL: https://github.com/apache/solr/pull/1769#issuecomment-1714674897
### ⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch, i
HoustonPutman commented on code in PR #1913:
URL: https://github.com/apache/solr/pull/1913#discussion_r1322087879
##
solr/bin/solr:
##
@@ -1886,7 +1892,7 @@ function start_solr() {
# OOME is thrown. Program operation after OOME is unpredictable.
"-XX:+CrashOnOutOfMemor
tflobbe commented on code in PR #1913:
URL: https://github.com/apache/solr/pull/1913#discussion_r1322079893
##
solr/bin/solr:
##
@@ -1886,7 +1892,7 @@ function start_solr() {
# OOME is thrown. Program operation after OOME is unpredictable.
"-XX:+CrashOnOutOfMemoryError
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16415.
-
Fix Version/s: 9.4
Resolution: Fixed
> ZK DistributedMap should reject slash in IDs
>
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16415:
Summary: ZK DistributedMap should reject slash in IDs (was: DELETESTATUS
API throws Exception)
>
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763913#comment-17763913
]
ASF subversion and git services commented on SOLR-16415:
Commit f
renatoh opened a new pull request, #1915:
URL: https://github.com/apache/solr/pull/1915
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Pl
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1322029693
##
solr/core/src/test/org/apache/solr/handler/admin/api/SnapshotBackupAPITest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1322029293
##
solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotBackupAPI.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1322028887
##
solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotBackupAPI.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
[
https://issues.apache.org/jira/browse/SOLR-16415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763901#comment-17763901
]
ASF subversion and git services commented on SOLR-16415:
Commit 7
dsmiley merged PR #1824:
URL: https://github.com/apache/solr/pull/1824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
stillalex commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1322003104
##
solr/core/src/java/org/apache/solr/handler/admin/api/SnapshotBackupAPI.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
stillalex commented on code in PR #1914:
URL: https://github.com/apache/solr/pull/1914#discussion_r1321986627
##
solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java:
##
@@ -272,6 +272,40 @@ public void testDeleteByIdImplicitRouter() throws
Exception {
sigram commented on code in PR #1905:
URL: https://github.com/apache/solr/pull/1905#discussion_r1321979342
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/AveragingMetricProvider.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
sigram commented on code in PR #1905:
URL: https://github.com/apache/solr/pull/1905#discussion_r1321979342
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/AveragingMetricProvider.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
sigram commented on code in PR #1905:
URL: https://github.com/apache/solr/pull/1905#discussion_r1321979342
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/AveragingMetricProvider.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
epugh commented on code in PR #1914:
URL: https://github.com/apache/solr/pull/1914#discussion_r1321971417
##
solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java:
##
@@ -272,6 +272,40 @@ public void testDeleteByIdImplicitRouter() throws
Exception {
}
stillalex commented on PR #1898:
URL: https://github.com/apache/solr/pull/1898#issuecomment-1714429359
updated the major changes doc. @dsmiley would appreciate a quick sanity
check before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
HoustonPutman commented on PR #1912:
URL: https://github.com/apache/solr/pull/1912#issuecomment-1714423565
> I love it... I wonder though if we should think about having a explicit
"integration" tests subdir? We use BATS for both "unit testing" our Bash
scripts, but also now are using it mo
patsonluk commented on PR #1457:
URL: https://github.com/apache/solr/pull/1457#issuecomment-1714423429
> This looks really useful -- indeed basically _required_ in order to
specifically target certain kinds of race/deadlock issues. Basically identical
in spirit to `injectDelay()`, but more
patsonluk commented on code in PR #1457:
URL: https://github.com/apache/solr/pull/1457#discussion_r1321959127
##
solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java:
##
@@ -73,4 +76,66 @@ public static boolean injectDelay() {
}
return true;
}
+
tomglk commented on PR #1883:
URL: https://github.com/apache/solr/pull/1883#issuecomment-1714418382
Oh yes, keeping the reading near the clearing is a good call. Nice!
I like it and do not see any more todos. :)
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763880#comment-17763880
]
Alex Deparvu commented on SOLR-16971:
-
I believe this was introduced with changes for
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16971:
Affects Version/s: 9.0
> RealTimeGet with Composite router throws NPE
> ---
stillalex opened a new pull request, #1914:
URL: https://github.com/apache/solr/pull/1914
https://issues.apache.org/jira/browse/SOLR-16971
# Description
RealTimeGet with Composite router throws NPE at slice resolution time making
it unusable.
# Solution
[
https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-14886:
---
Assignee: Alex Deparvu
> Suppress stack trace in Query response.
> -
stillalex commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1714390934
@dsmiley I refactored the test as best I could. please take a look and let
me know if more cleanup is needed.
I had to rebase+force push to get crave build running again
--
This is an
gerlowskija commented on code in PR #1903:
URL: https://github.com/apache/solr/pull/1903#discussion_r1321902791
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReloadCoreAPI.java:
##
@@ -17,52 +17,68 @@
package org.apache.solr.handler.admin.api;
-import static org.a
magibney commented on code in PR #1457:
URL: https://github.com/apache/solr/pull/1457#discussion_r1321891475
##
solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java:
##
@@ -73,4 +76,66 @@ public static boolean injectDelay() {
}
return true;
}
+
+
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763855#comment-17763855
]
ASF subversion and git services commented on SOLR-16825:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763853#comment-17763853
]
ASF subversion and git services commented on SOLR-16825:
Commit 8
gerlowskija merged PR #1902:
URL: https://github.com/apache/solr/pull/1902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
dsmiley commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1714322303
Thanks for trying Alex!
I suppose this test is more sensitive to the serialization, in which case
you should probably use SolrJettyTestRule.
EmbeddedSolrServer: Ideally, a test (or
stillalex commented on PR #1632:
URL: https://github.com/apache/solr/pull/1632#issuecomment-1714298498
@dsmiley I am attempting to rewrite the test using thew new
`EmbeddedSolrServerTestRule` but I am falling short.
First it seems to shortcut exceptions in the response via
`checkForExcep
[
https://issues.apache.org/jira/browse/SOLR-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16963:
--
Summary: verifyClientHostName is used incorrectly (was: Conflicting SSL
options for Http2SolrC
dsmiley commented on code in PR #1886:
URL: https://github.com/apache/solr/pull/1886#discussion_r1321795884
##
solr/core/src/test/org/apache/solr/search/TestThinCache.java:
##
@@ -26,13 +26,63 @@
import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.metrics.SolrMetricM
stillalex commented on code in PR #1886:
URL: https://github.com/apache/solr/pull/1886#discussion_r1321762017
##
solr/core/src/test/org/apache/solr/search/TestThinCache.java:
##
@@ -26,13 +26,63 @@
import org.apache.solr.SolrTestCaseJ4;
import org.apache.solr.metrics.SolrMetri
[
https://issues.apache.org/jira/browse/SOLR-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763791#comment-17763791
]
Houston Putman commented on SOLR-16963:
---
We should backport this to 8.11.3
> Confl
[
https://issues.apache.org/jira/browse/SOLR-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763782#comment-17763782
]
Houston Putman commented on SOLR-16963:
---
Not a solution for the back compat issues,
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16971:
Description:
RealTimeGet with Composite router throws NPE at slice resolution time making it
unusa
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16971:
Description:
RealTimeGet with Composite router throws NPE at slice resolution time making it
unusa
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16971:
Description:
RealTimeGet with Composite router throws NPE at slice resolution time making it
unusa
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16971:
Description:
RealTimeGet with Composite router throws NPE at slice resolution time making it
unusa
Anna created SOLR-16972:
---
Summary: java.lang.NullPointerException in ReRankScaler.explain
Key: SOLR-16972
URL: https://issues.apache.org/jira/browse/SOLR-16972
Project: Solr
Issue Type: Bug
Secur
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16971:
Description:
RealTimeGet with Composite router throws NPE at slice resolution time making it
unusa
[
https://issues.apache.org/jira/browse/SOLR-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16971:
---
Assignee: Alex Deparvu
> RealTimeGet with Composite router throws NPE
>
Alex Deparvu created SOLR-16971:
---
Summary: RealTimeGet with Composite router throws NPE
Key: SOLR-16971
URL: https://issues.apache.org/jira/browse/SOLR-16971
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-16899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16899:
---
Assignee: Alex Deparvu
> CoreAdminOp are statically registered in CoreAdminHandler, preventi
stillalex commented on PR #1892:
URL: https://github.com/apache/solr/pull/1892#issuecomment-1714096653
thank you for confirming @ctargett.
@pvcnt what name should I use in the CHANGES.txt entry for the credit?
--
This is an automated message from the Apache Git Service.
To respond to th
epugh commented on PR #1912:
URL: https://github.com/apache/solr/pull/1912#issuecomment-1714022969
I love it... I wonder though if we should think about having a explicit
"integration" tests subdir? We use BATS for both "unit testing" our Bash
scripts, but also now are using it more a
HoustonPutman opened a new pull request, #1912:
URL: https://github.com/apache/solr/pull/1912
This adds full mTLS integration tests (WANT_CLIENT_AUTH and
NEED_CLIENT_AUTH). The client/server certs are different, as are the truststore
and keystore, so each is tested independently.
One
Houston Putman created SOLR-16970:
-
Summary: SOLR_OPTS is unable to override many sysProps
Key: SOLR-16970
URL: https://issues.apache.org/jira/browse/SOLR-16970
Project: Solr
Issue Type: Impr
[
https://issues.apache.org/jira/browse/SOLR-16750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763719#comment-17763719
]
Vamsi Krishna K commented on SOLR-16750:
-
Hello, please can I work on this issue
janhoy commented on PR #1653:
URL: https://github.com/apache/solr/pull/1653#issuecomment-1713798800
Yea, looks like the bot foce pushed. Unfortunately the commons project have
not released a 2.13.1 or 2.14, even if 2.13.0 contains a non-compatible change
:( So we just have to wait until the
[
https://issues.apache.org/jira/browse/SOLR-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-12976.
Resolution: Done
This is done elsewhere
> Unify RedactionUtils and metrics hiddenSysProps settings
cpoerschke commented on PR #1892:
URL: https://github.com/apache/solr/pull/1892#issuecomment-1713748603
Yes, `CoreAdminHandler.opMap` remaining static when there could be custom
actions seems unintended.
--
This is an automated message from the Apache Git Service.
To respond to the messag
cpoerschke commented on PR #1883:
URL: https://github.com/apache/solr/pull/1883#issuecomment-1713645754
> The assert for the used scorer is a bit hidden now. I fear that for others
it would not be obvious at first glance what the tests want to test. ...
Yes, I agree that the assert in
cpoerschke commented on PR #1653:
URL: https://github.com/apache/solr/pull/1653#issuecomment-1713600473
Oops, I checked the _"If you want to rebase/retry this PR, check this box"_
option before fully reading the PR history here ... unchecked it again now but
not sure if @solrbot will see th
cpoerschke commented on PR #1910:
URL: https://github.com/apache/solr/pull/1910#issuecomment-1713566544
https://commons.apache.org/proper/commons-compress/changes-report.html#a1.24.0
mentions that the change includes _Bump commons-io:commons-io from 2.11.0 to
2.13.0._ and we have #1653 to
71 matches
Mail list logo
