[jira] [Updated] (SOLR-16983) ObjectReleaseTracker completely useless in all SolrTestCaseJ4 based tests

2023-09-20 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16983: -- Attachment: SOLR-16983-2.patch Assignee: Chris M. Hostetter Status: Open

[GitHub] [solr] stillalex commented on pull request #1943: SOLR-16960 Tests should sometimes run with a Tracer (not no-op)

2023-09-20 Thread via GitHub
stillalex commented on PR #1943: URL: https://github.com/apache/solr/pull/1943#issuecomment-1728541552 > but ideally we would inject the propagating tracer and potentially this recording flag in an independent way that isn't specific to SolrCloud. Tracing isn't specific to SolrCloud! In the

[GitHub] [solr] janhoy commented on pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-20 Thread via GitHub
janhoy commented on PR #1905: URL: https://github.com/apache/solr/pull/1905#issuecomment-1728536787 Planning to merge this on friday... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [solr] janhoy commented on pull request #1930: SOLR-16982: Trip a Circuit Breaker only for external requests

2023-09-20 Thread via GitHub
janhoy commented on PR #1930: URL: https://github.com/apache/solr/pull/1930#issuecomment-1728535462 Plan to merge this on Friday.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2023-09-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767325#comment-17767325 ] ASF subversion and git services commented on SOLR-15056: Commit a

[jira] [Resolved] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2023-09-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15056. Fix Version/s: 9.4 Resolution: Fixed > CPU circuit breaker needs to use CPU utilization, not

[GitHub] [solr] stillalex commented on a diff in pull request #1943: SOLR-16960 Tests should sometimes run with a Tracer (not no-op)

2023-09-20 Thread via GitHub
stillalex commented on code in PR #1943: URL: https://github.com/apache/solr/pull/1943#discussion_r1332259553 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1299,5 +1301,15 @@ public Builder withTraceIdGenerationDisabled() { this.d

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2023-09-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767318#comment-17767318 ] ASF subversion and git services commented on SOLR-15056: Commit 5

[GitHub] [solr] janhoy merged pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-20 Thread via GitHub
janhoy merged PR #96: URL: https://github.com/apache/solr/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org Fo

[GitHub] [solr] anshumg merged pull request #1944: fix protected term filter example (#1894)

2023-09-20 Thread via GitHub
anshumg merged PR #1944: URL: https://github.com/apache/solr/pull/1944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Updated] (SOLR-16989) Optimize and consolidate reuse of DocValues iterators for value retrieval

2023-09-20 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-16989: -- Security: (was: Public) > Optimize and consolidate reuse of DocValues iterators for value r

[GitHub] [solr-operator] brickpattern opened a new issue, #627: Create Collection fails after Upgrade

2023-09-20 Thread via GitHub
brickpattern opened a new issue, #627: URL: https://github.com/apache/solr-operator/issues/627 Setup: K8S cluster: AWS EKS Solr Operator : 0.7.1 helm chart Solr cloud version: 9.3 ZK : inbuilt w/operator Nodes: 3 solr nodes ( pod solrcloud-0, solrcloud-1, solrcloud-2)

[GitHub] [solr] dsmiley commented on a diff in pull request #1943: SOLR-16960 Tests should sometimes run with a Tracer (not no-op)

2023-09-20 Thread via GitHub
dsmiley commented on code in PR #1943: URL: https://github.com/apache/solr/pull/1943#discussion_r1332091693 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1299,5 +1301,15 @@ public Builder withTraceIdGenerationDisabled() { this.dis

[GitHub] [solr] gerlowskija commented on pull request #1933: SOLR-16397: Create v2(JAX-RS) endpoints for UNLOAD core

2023-09-20 Thread via GitHub
gerlowskija commented on PR #1933: URL: https://github.com/apache/solr/pull/1933#issuecomment-1728321719 > I ran into a similar SolrCore ref-count issue on one other API. Let me try to remember what I did back then and hopefully I'll have a fix to discuss here shortly. This should be

[GitHub] [solr] gerlowskija commented on a diff in pull request #1933: SOLR-16397: Create v2(JAX-RS) endpoints for UNLOAD core

2023-09-20 Thread via GitHub
gerlowskija commented on code in PR #1933: URL: https://github.com/apache/solr/pull/1933#discussion_r1331761409 ## solr/core/src/java/org/apache/solr/handler/admin/api/UnloadCoreAPI.java: ## @@ -17,60 +17,89 @@ package org.apache.solr.handler.admin.api; -import static org.a

[GitHub] [solr] anshumg opened a new pull request, #1944: fix protected term filter example (#1894)

2023-09-20 Thread via GitHub
anshumg opened a new pull request, #1944: URL: https://github.com/apache/solr/pull/1944 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] anshumg merged pull request #1894: Fix example for Protected Term Filter

2023-09-20 Thread via GitHub
anshumg merged PR #1894: URL: https://github.com/apache/solr/pull/1894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] AndreyBozhko commented on pull request #1894: Fix example for Protected Term Filter

2023-09-20 Thread via GitHub
AndreyBozhko commented on PR #1894: URL: https://github.com/apache/solr/pull/1894#issuecomment-1728281479 Hi @anshumg - could you please help with reviewing this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SOLR-16890) Extra unit test cases for Coordinator

2023-09-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767237#comment-17767237 ] ASF subversion and git services commented on SOLR-16890: Commit 7

[jira] [Commented] (SOLR-16960) Tests should sometimes run with a Tracer (not no-op)

2023-09-20 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767229#comment-17767229 ] Alex Deparvu commented on SOLR-16960: - Took a stab at this https://github.com/apache/

[GitHub] [solr] stillalex opened a new pull request, #1943: SOLR-16960 Tests should sometimes run with a Tracer (not no-op)

2023-09-20 Thread via GitHub
stillalex opened a new pull request, #1943: URL: https://github.com/apache/solr/pull/1943 https://issues.apache.org/jira/browse/SOLR-16960 # Description Took a stab at randomizing the isRecording flag during tests so we get better coverage. # Solution

[jira] [Commented] (SOLR-16986) Measure and aggregate thread CPU time in distributed search

2023-09-20 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767226#comment-17767226 ] Alex Deparvu commented on SOLR-16986: - very interesting. I was playing with something

[GitHub] [solr-operator] kobo-gcyre opened a new issue, #626: Zookeeper fails to upgrade after upgrading operator

2023-09-20 Thread via GitHub
kobo-gcyre opened a new issue, #626: URL: https://github.com/apache/solr-operator/issues/626 After upgrading the solr operator to 0.7.1 the zookeeper operator doesn't upgrade the zookeeper pods. found these errors in the logs ``` {"level":"error","ts":1694631591.8541024,"msg":"Rec

[jira] [Commented] (SOLR-16890) Extra unit test cases for Coordinator

2023-09-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767190#comment-17767190 ] ASF subversion and git services commented on SOLR-16890: Commit 3

[GitHub] [solr] HoustonPutman merged pull request #1939: SOLR-16890: Fix SSL cert issue for test case in TestCoordinatorRole

2023-09-20 Thread via GitHub
HoustonPutman merged PR #1939: URL: https://github.com/apache/solr/pull/1939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] stillalex commented on a diff in pull request #1856: SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory

2023-09-20 Thread via GitHub
stillalex commented on code in PR #1856: URL: https://github.com/apache/solr/pull/1856#discussion_r1331914086 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestDistributedTracing.java: ## @@ -173,20 +167,137 @@ public void testV2Api() throws Exception {

[GitHub] [solr] HoustonPutman commented on pull request #1941: SOLR-16925 Broken JSON indentation using JacksonJsonWriter

2023-09-20 Thread via GitHub
HoustonPutman commented on PR #1941: URL: https://github.com/apache/solr/pull/1941#issuecomment-1728078002 I created a new PR for this https://github.com/apache/solr/pull/1942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [solr] HoustonPutman opened a new pull request, #1942: SOLR-16925: Fix indentation for JacksonJsonWriter

2023-09-20 Thread via GitHub
HoustonPutman opened a new pull request, #1942: URL: https://github.com/apache/solr/pull/1942 https://issues.apache.org/jira/browse/SOLR-16925 `PrettyPrinter` is stateful, so we need a new instance every time. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1941: SOLR-16925 Broken JSON indentation using JacksonJsonWriter

2023-09-20 Thread via GitHub
HoustonPutman commented on code in PR #1941: URL: https://github.com/apache/solr/pull/1941#discussion_r1331893557 ## solr/core/src/java/org/apache/solr/response/JacksonJsonWriter.java: ## @@ -25,11 +25,17 @@ import java.io.OutputStream; import java.math.BigDecimal; import jav

[GitHub] [solr] iamsanjay commented on pull request #1903: SOLR-16397: Create v2(JAX-RS) endpoints for RELOAD core

2023-09-20 Thread via GitHub
iamsanjay commented on PR #1903: URL: https://github.com/apache/solr/pull/1903#issuecomment-1727912513 Thank you so much for the reviewing it and fixing few issues as well. Just one thing, I removed the 'Content-type' from the documentation. I will make another pull request for documentati

[GitHub] [solr] noblepaul opened a new pull request, #1941: SOLR-16925 Broken JSON indentation using JacksonJsonWriter

2023-09-20 Thread via GitHub
noblepaul opened a new pull request, #1941: URL: https://github.com/apache/solr/pull/1941 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-20 Thread via GitHub
janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1331630936 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-20 Thread via GitHub
janhoy commented on PR #96: URL: https://github.com/apache/solr/pull/96#issuecomment-1727720423 Thanks. I'll add the fail-early check from https://github.com/wrunderwood/solr/pull/1, rebase on main and force-push. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr-operator] thomaswoeckinger opened a new issue, #624: Possibility to run as readOnlyRootFilesysystem

2023-09-20 Thread via GitHub
thomaswoeckinger opened a new issue, #624: URL: https://github.com/apache/solr-operator/issues/624 In Openshift environments (may in others too) it is possible to restrict containers with SecurityContextConstraints (SCC). Especial setting the root filesystem to read only would increas

[jira] [Created] (SOLR-16990) Upack raw cosineSim and dotProduct in reRanker

2023-09-20 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-16990: - Summary: Upack raw cosineSim and dotProduct in reRanker Key: SOLR-16990 URL: https://issues.apache.org/jira/browse/SOLR-16990 Project: Solr Issue Type: New

[jira] [Updated] (SOLR-16990) Unpack raw cosineSim and dotProduct in reRanker

2023-09-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16990: -- Description: Currently the Lucene vector scores are scaled to avoid negative values. There are

[jira] [Commented] (SOLR-16691) Use Jackson for JSON serialization

2023-09-20 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767100#comment-17767100 ] Eric Pugh commented on SOLR-16691: -- Quepid uses JSONP (Json with Padding) to talk to Sol

[jira] [Updated] (SOLR-16990) Unpack raw cosineSim and dotProduct in reRanker

2023-09-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16990: -- Summary: Unpack raw cosineSim and dotProduct in reRanker (was: Upack raw cosineSim and dotProd

[GitHub] [solr] gerlowskija commented on a diff in pull request #1933: SOLR-16397: Create v2(JAX-RS) endpoints for UNLOAD core

2023-09-20 Thread via GitHub
gerlowskija commented on code in PR #1933: URL: https://github.com/apache/solr/pull/1933#discussion_r1331534623 ## solr/solr-ref-guide/modules/configuration-guide/pages/coreadmin-api.adoc: ## @@ -439,7 +439,31 @@ The `UNLOAD` action removes a core from Solr. Active requests wil

[jira] [Updated] (SOLR-16990) Upack raw cosineSim and dotProduct in reRanker

2023-09-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16990: -- Description: Currently the Lucene vector scores are scaled to avoid negative values. There are

[jira] [Assigned] (SOLR-16990) Unpack raw cosineSim and dotProduct in reRanker

2023-09-20 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein reassigned SOLR-16990: - Assignee: Joel Bernstein > Unpack raw cosineSim and dotProduct in reRanker > ---

[GitHub] [solr-operator] radu-gheorghe opened a new pull request, #625: Call rebalance API once all pods are updated

2023-09-20 Thread via GitHub
radu-gheorghe opened a new pull request, #625: URL: https://github.com/apache/solr-operator/pull/625 Timid attempt to fix #615 It works on my machine, it seems to fix the problem, but: * I have no tests. Yet. I have a feeling this is the hard part 🙂 * I guess I'll need to updat