iamsanjay commented on code in PR #2144:
URL: https://github.com/apache/solr/pull/2144#discussion_r1442540458
##
solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
dsmiley commented on code in PR #2171:
URL: https://github.com/apache/solr/pull/2171#discussion_r1442512538
##
dev-docs/FAQ.adoc:
##
@@ -91,3 +91,9 @@ If you don't yet have an account, you have to ask for one in
the 'users' or 'dev
1. Please do not delete older files that you
dsmiley commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442510069
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrParams
dsmiley commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442509698
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrParams
gerlowskija commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442460595
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrPa
gerlowskija opened a new pull request, #2177:
URL: https://github.com/apache/solr/pull/2177
https://issues.apache.org/jira/browse/SOLR-17066
# Description
SOLR-17066 recently expanded the concept of a "default collection" to all
SolrClient implementations, as a migration pa
janhoy commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442291279
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrException(E
janhoy commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442292722
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrException(E
janhoy commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442291279
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrException(E
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1442145469
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setC
gerlowskija commented on code in PR #2173:
URL: https://github.com/apache/solr/pull/2173#discussion_r1442103850
##
solr/solrj/src/java/org/apache/solr/common/util/URLUtil.java:
##
Review Comment:
Yeah, I think that'd probably make sense (moving `normalizeSolrUrl` that
is).
gerlowskija commented on code in PR #2173:
URL: https://github.com/apache/solr/pull/2173#discussion_r1440817786
##
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##
@@ -332,24 +336,26 @@ private void setLeaderUrl(String leaderUrl) {
solrCore
epugh commented on PR #2171:
URL: https://github.com/apache/solr/pull/2171#issuecomment-1877537809
> > ... One little question? I found this commit:
https://github.com/apache/solr/pull/2171/files/f76b845cf03ddb177f1dc7e0286d0faa9310cbba..4536ca7004da0d3638b41eae1c341446234b15bb
however I do
cpoerschke commented on PR #2171:
URL: https://github.com/apache/solr/pull/2171#issuecomment-1877535845
> ... One little question? I found this commit:
https://github.com/apache/solr/pull/2171/files/f76b845cf03ddb177f1dc7e0286d0faa9310cbba..4536ca7004da0d3638b41eae1c341446234b15bb
however I
uschindler commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442080975
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrExcepti
uschindler commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442078351
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrExcepti
uschindler commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442076218
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrExcepti
uschindler commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442076218
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrExcepti
uschindler commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442023598
##
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields)
throw new SolrExcepti
pvcnt commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1877435871
The point I am raising about validation has actually already been raised by
Paul there: https://github.com/apache/solr/pull/2126/files#r1424690508 I think
it would be a mistake to not enforce
NazerkeBS commented on PR #2176:
URL: https://github.com/apache/solr/pull/2176#issuecomment-1877411210
> It's great that we are working to stay up to date with Lucene! Looks like
two of the tests are failing?
`TestSolrQueryParser#testSyntax `- re-run it a few times locally ,
surprisi
dsmiley commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1877290383
> I believe it would still be interesting to have at least two different
plugin types to validate that the generic approach is really generic, and what
it takes to add a new type of plugin.
[
https://issues.apache.org/jira/browse/SOLR-17063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-17063.
---
Fix Version/s: 9.5
Resolution: Fixed
> Do not buffer raw log params in LogWatcher
> --
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803189#comment-17803189
]
Jan Høydahl commented on SOLR-15960:
Once this lands, one can do several cleanup PRs
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441805546
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setC
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803182#comment-17803182
]
Eric Pugh commented on SOLR-15960:
--
I am curious if there are any logical next steps onc
epugh commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1877166371
I went to check if Ref Guide was updated, and sure enough it was!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441792277
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setC
epugh commented on PR #2176:
URL: https://github.com/apache/solr/pull/2176#issuecomment-1877156966
Looks like two of the tests are failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
epugh commented on PR #2171:
URL: https://github.com/apache/solr/pull/2171#issuecomment-1877154430
This looks great! One little question? I found this commit:
https://github.com/apache/solr/pull/2171/files/f76b845cf03ddb177f1dc7e0286d0faa9310cbba..4536ca7004da0d3638b41eae1c341446234b15bb
janhoy merged PR #2165:
URL: https://github.com/apache/solr/pull/2165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #2159:
URL: https://github.com/apache/solr/pull/2159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #2048:
URL: https://github.com/apache/solr/pull/2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441659284
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -929,8 +941,8 @@ public NodeConfig build() {
metricsConfig,
cachesConfig,
janhoy merged PR #2174:
URL: https://github.com/apache/solr/pull/2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1876955879
Thanks for the extra review. Will merge to main tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
cpoerschke commented on PR #2080:
URL: https://github.com/apache/solr/pull/2080#issuecomment-1876908119
Just re-discovered this pull request via the
https://issues.apache.org/jira/browse/SOLR-16865 ticket -- based on its history
tagging @chatman and @gerlowskija as potential reviewers, than
pvcnt commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1876907601
I believe it would still be interesting to have at least two different
plugin types to validate that the generic approach is really generic, and what
it takes to add a new type of plugin.
NazerkeBS opened a new pull request, #2176:
URL: https://github.com/apache/solr/pull/2176
*https://issues.apache.org/jira/browse/SOLR-17097
# Description
Upgrade Solr to use Lucene 9.9.1
# Solution
Please provide a short description of the approach take
iamsanjay commented on PR #2128:
URL: https://github.com/apache/solr/pull/2128#issuecomment-1876760283
Also, I saw some APIs override the below method to mark it expensive. I
believe, MERGEINDEXES is kind of expensive.
```
boolean isExpensive() {
return false;
}
```
--
iamsanjay commented on code in PR #2128:
URL: https://github.com/apache/solr/pull/2128#discussion_r1441509938
##
solr/api/src/java/org/apache/solr/client/api/model/MergeIndexesRequestBody.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
41 matches
Mail list logo
