epugh commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067505398
I noticed that you have this listed as a 10 change, not a 9.6.. which is
fine by me, just wanted to check...
--
This is an automated message from the Apache Git Service.
To respond to the m
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1573100711
##
solr/modules/monitor/src/java/org/apache/solr/monitor/package-info.java:
##
@@ -0,0 +1,21 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under one
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1573099302
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ParallelSolrMatcherSink.java:
##
@@ -0,0 +1,95 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundatio
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1573099302
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ParallelSolrMatcherSink.java:
##
@@ -0,0 +1,95 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundatio
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067450739
I think the PR is ready for a merge.
Run another full test and all tests passed
Thank you @epugh and @HoustonPutman for your review and feedback.
--
This is an automated message fr
[
https://issues.apache.org/jira/browse/SOLR-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-16866.
---
Fix Version/s: 9.6.0
Assignee: Michael Gibney
Resolution: Fixed
> CachingDire
[
https://issues.apache.org/jira/browse/SOLR-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839123#comment-17839123
]
ASF subversion and git services commented on SOLR-16866:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839122#comment-17839122
]
ASF subversion and git services commented on SOLR-16866:
Commit d
magibney merged PR #2349:
URL: https://github.com/apache/solr/pull/2349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
[
https://issues.apache.org/jira/browse/SOLR-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839120#comment-17839120
]
ASF subversion and git services commented on SOLR-16866:
Commit 7
HoustonPutman commented on PR #2410:
URL: https://github.com/apache/solr/pull/2410#issuecomment-2067241865
Ok I've updated the docs, and used the `maxConcurrentPushedStreams` to get
the multiplexing factor.
This should probably be good to go?
--
This is an automated message from th
HoustonPutman commented on code in PR #660:
URL: https://github.com/apache/solr-operator/pull/660#discussion_r1572878677
##
controllers/util/solr_security_util.go:
##
@@ -238,7 +238,7 @@ func addHostHeaderToProbe(httpGet *corev1.HTTPGetAction,
host string) {
func cmdToPutSec
HoustonPutman commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1572832579
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1048,7 +1056,7 @@ private static class AsyncTracker {
int getMaxRequests
[
https://issues.apache.org/jira/browse/SOLR-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839094#comment-17839094
]
Houston Putman commented on SOLR-17240:
---
As with everything jetty related, not conf
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572781910
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient {
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572781253
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+ pu
HoustonPutman commented on PR #2349:
URL: https://github.com/apache/solr/pull/2349#issuecomment-2067100236
I've seen this cause failures when moving replicas around, so I would love
to see it fixed in 9.6
--
This is an automated message from the Apache Git Service.
To respond to the messa
HoustonPutman commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572758958
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient
epugh closed pull request #2378: SOLR-17194: CloudHttp2SolrClient doesn't
properly use httpClient Builder on certain paths
URL: https://github.com/apache/solr/pull/2378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
epugh commented on PR #2378:
URL: https://github.com/apache/solr/pull/2378#issuecomment-2067066181
Closing in favour of #2412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
epugh commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572740653
##
solr/core/src/test/org/apache/solr/cli/TestExportTool.java:
##
@@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception {
}
}
+ @Test
+ public
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067045033
> > @laminelam should we just merge the other test over to this PR? and then
I can close it...
>
> done :)
BTW, in _testWithBasicAuth_, I used
"_CollectionAdminRequest.create
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572722875
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lb
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2067028284
> @laminelam should we just merge the other test over to this PR? and then I
can close it...
done :)
--
This is an automated message from the Apache Git Service.
To respond to t
epugh commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572697455
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lbClie
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2066977654
> @laminelam should we just merge the other test over to this PR? and then I
can close it...
Yes I think we should. Will do
--
This is an automated message from the Apache Git Ser
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572680652
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lb
laminelam commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572678088
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -85,14 +79,62 @@ protected CloudHttp2SolrClient(Builder builder) {
this.lb
epugh commented on code in PR #2412:
URL: https://github.com/apache/solr/pull/2412#discussion_r1572623626
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -54,17 +54,12 @@ public class CloudHttp2SolrClient extends CloudSolrClient {
*/
epugh commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2066901677
@laminelam should we just merge the other test over to this PR? and then I
can close it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/SOLR-17222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-17222.
---
Fix Version/s: 9.6.0
Assignee: Michael Gibney
Resolution: Fixed
> QueryRespon
[
https://issues.apache.org/jira/browse/SOLR-17222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839044#comment-17839044
]
ASF subversion and git services commented on SOLR-17222:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-17222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839042#comment-17839042
]
ASF subversion and git services commented on SOLR-17222:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-17222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839039#comment-17839039
]
ASF subversion and git services commented on SOLR-17222:
Commit 8
magibney merged PR #2386:
URL: https://github.com/apache/solr/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
laminelam commented on PR #2412:
URL: https://github.com/apache/solr/pull/2412#issuecomment-2066779786
@epugh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
laminelam commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1572519870
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -422,7 +422,10 @@ public CloudHttp2SolrClient build() {
}
}
laminelam opened a new pull request, #2412:
URL: https://github.com/apache/solr/pull/2412
https://issues.apache.org/jira/browse/SOLR-17194
Possible duplicate of [2378](https://github.com/apache/solr/pull/2378)
# Description
When creating a _CloudHttp2So
jdyer1 commented on PR #2411:
URL: https://github.com/apache/solr/pull/2411#issuecomment-2066741170
@gerlowskija I'd appreciate your review on this, as here I am undoing
behavior you were protecting in unit test
`LBSolrClientTest#testServerIteratorWithZombieServers`. My change restores the
magibney commented on PR #2349:
URL: https://github.com/apache/solr/pull/2349#issuecomment-2066737230
Assuming we want to wait until after 9.6 for this? It should be safe, but
it's really only about reducing log noise, so is pretty low priority.
--
This is an automated message from the Ap
jdyer1 opened a new pull request, #2411:
URL: https://github.com/apache/solr/pull/2411
This is to fix a regression bug in `main` only, in that LBHttp2SolrClient
does not skip "zombie" Endpoints. See JIRA for more details.
--
This is an automated message from the Apache Git Service.
To re
James Dyer created SOLR-17242:
-
Summary: Http2SolrClient/HttpJdkSolrClient: Better handling of
timeout parameters
Key: SOLR-17242
URL: https://issues.apache.org/jira/browse/SOLR-17242
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Dyer reassigned SOLR-17234:
-
Assignee: James Dyer
> LBHttp2SolrClient does not skip "zombie" endpoints
>
magibney commented on PR #2410:
URL: https://github.com/apache/solr/pull/2410#issuecomment-2066626472
javadoc should be updated on
[HttpSolrClientBuilderBase.withMaxConnectionsPerHost(int)](https://github.com/apache/solr/blob/188ca8872cdbe61ea229bc40fadee20e7ba50053/solr/solrj/src/java/org/a
[
https://issues.apache.org/jira/browse/SOLR-17240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839005#comment-17839005
]
Michael Gibney commented on SOLR-17240:
---
I think that depends on
{quote}Jetty will
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838998#comment-17838998
]
ASF subversion and git services commented on SOLR-14763:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838996#comment-17838996
]
ASF subversion and git services commented on SOLR-14763:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838988#comment-17838988
]
ASF subversion and git services commented on SOLR-14763:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838983#comment-17838983
]
James Dyer commented on SOLR-14763:
---
Test *HttpJdkSolrClientTest.testAsyncAndCancel* ha
dependabot[bot] opened a new pull request, #700:
URL: https://github.com/apache/solr-operator/pull/700
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to
0.23.0.
Commits
https://github.com/golang/net/commit/c48da131589f122489348be5dfbcb6457640046f";>c48da13
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1572044870
##
solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateProcessorFactory.java:
##
@@ -0,0 +1,56 @@
+/*
+ *
+ * * Licensed to the Apache Software F
Michael Eves created SOLR-17241:
---
Summary: Collection Reload v2 API Fails On Node Without Replica
Key: SOLR-17241
URL: https://issues.apache.org/jira/browse/SOLR-17241
Project: Solr
Issue Type:
52 matches
Mail list logo
