Re: [PR] SOLR-16659: Properly construct V2 base urls instead of replacing substring "/solr" with "/api" [solr]

2024-05-28 Thread via GitHub
dsmiley commented on PR #2473: URL: https://github.com/apache/solr/pull/2473#issuecomment-2136414314 It feel weird to me that we go to ZkStateReader to build node URLs. Conceptually, this seem like something that ought to exist at a higher conceptual layer. On the other hand,

[jira] [Updated] (SOLR-16093) Tests should not require a working IPv6 networking stack

2024-05-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16093: Summary: Tests should not require a working IPv6 networking stack (was: HttpClient does not

[jira] [Updated] (SOLR-16093) HttpClient does not gracefully handle IPv6

2024-05-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16093: Component/s: Tests Priority: Minor (was: Major) > HttpClient does not gracefully handle

[PR] SOLR-16093: Tests: don't require IPv6 [solr]

2024-05-28 Thread via GitHub
dsmiley opened a new pull request, #2484: URL: https://github.com/apache/solr/pull/2484 The Java VM/host, doesn't always support IPv6, our tests shouldn't require it. security.policy: Removed 3 lines that were for tests. https://issues.apache.org/jira/browse/SOLR-16093 In a

Re: [PR] [SOLR-17187] Add possibility to supply a custom commitPollInterval for TLOG/PULL replicas [solr]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #2316: URL: https://github.com/apache/solr/pull/2316#issuecomment-2136286797 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify

[jira] [Commented] (SOLR-16093) HttpClient does not gracefully handle IPv6

2024-05-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850206#comment-17850206 ] David Smiley commented on SOLR-16093: - I spent some time with this today, finally able to reproduce

[jira] [Assigned] (SOLR-16093) HttpClient does not gracefully handle IPv6

2024-05-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-16093: --- Assignee: David Smiley > HttpClient does not gracefully handle IPv6 >

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
gerlowskija commented on PR #2471: URL: https://github.com/apache/solr/pull/2471#issuecomment-2136063043 Thanks for flagging this @AndreyBozhko. I'll take a look and try to fix the test in this PR tomorrow. Sorry to hold this up! -- This is an automated message from the Apache

Re: [PR] Factor out ModifiableSolrParams.setShardAttributesToParams method [solr]

2024-05-28 Thread via GitHub
dsmiley commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-2136032515 Sorry, but I strongly object to ModifiableSolrParams being a home for this method. SolrParams and subclasses are a generic data structure intended for params but they don't (nor do I think

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
AndreyBozhko commented on PR #2471: URL: https://github.com/apache/solr/pull/2471#issuecomment-2136007603 Looks like the test failure is due to the latest commit 8c5ae1b to main. @gerlowskija Could you take a look at this? It seems like the "Convert /cluster filestore APIs to

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
AndreyBozhko commented on PR #2471: URL: https://github.com/apache/solr/pull/2471#issuecomment-2135968815 > @AndreyBozhko did you see the build failure? Hm, I'll try to rebase off of the tip of the main branch and see if I can reproduce the failure... -- This is an automated

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
epugh commented on PR #2471: URL: https://github.com/apache/solr/pull/2471#issuecomment-2135923942 @AndreyBozhko did you see the build failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-05-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-17302: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental

[jira] [Updated] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-05-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-17302: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental

[PR] Correct command to reproduce test with a failure in classMethod [solr]

2024-05-28 Thread via GitHub
AndreyBozhko opened a new pull request, #2483: URL: https://github.com/apache/solr/pull/2483 # Description If a test fails due to some exception during static initialization, the logs contain message that looks like ``` Reproduce with: gradlew :solr:core:test --tests

[jira] [Commented] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850132#comment-17850132 ] ASF subversion and git services commented on SOLR-17302: Commit

[jira] [Commented] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850128#comment-17850128 ] ASF subversion and git services commented on SOLR-17302: Commit

Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS [solr]

2024-05-28 Thread via GitHub
gerlowskija merged PR #2470: URL: https://github.com/apache/solr/pull/2470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (SOLR-17277) Circuit Breakers should support a "Warn-only" mode

2024-05-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17277. Fix Version/s: main (10.0) 9.7 Resolution: Fixed > Circuit

[jira] [Assigned] (SOLR-17277) Circuit Breakers should support a "Warn-only" mode

2024-05-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-17277: -- Assignee: Jason Gerlowski > Circuit Breakers should support a "Warn-only" mode >

[jira] [Commented] (SOLR-17277) Circuit Breakers should support a "Warn-only" mode

2024-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850099#comment-17850099 ] ASF subversion and git services commented on SOLR-17277: Commit

Re: [PR] SOLR-17302: Convert /cluster filestore APIs to JAX-RS [solr]

2024-05-28 Thread via GitHub
gerlowskija commented on PR #2470: URL: https://github.com/apache/solr/pull/2470#issuecomment-2135679557 > is there an argument that ClusterFileStore should do everything DistribFileStore does? I guess? Idk about "do everything", but ClusterFileStore/ClusterFileStoreApi will

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
AndreyBozhko commented on code in PR #2471: URL: https://github.com/apache/solr/pull/2471#discussion_r1617551538 ## solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java: ## @@ -694,16 +694,32 @@ public boolean addToCoreAware(T obj) { } } - void

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
AndreyBozhko commented on code in PR #2471: URL: https://github.com/apache/solr/pull/2471#discussion_r1617546510 ## solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java: ## @@ -694,9 +694,14 @@ public boolean addToCoreAware(T obj) { } } + void

[jira] [Commented] (SOLR-17277) Circuit Breakers should support a "Warn-only" mode

2024-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850070#comment-17850070 ] ASF subversion and git services commented on SOLR-17277: Commit

Re: [PR] SOLR-17277: Add 'warnOnly' mode to CircuitBreakers [solr]

2024-05-28 Thread via GitHub
gerlowskija merged PR #2476: URL: https://github.com/apache/solr/pull/2476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17118: Simplify CoreContainerProvider initialization [solr]

2024-05-28 Thread via GitHub
dsmiley commented on PR #2474: URL: https://github.com/apache/solr/pull/2474#issuecomment-2135435742 If I get no more feedback, I'll merge Friday. I'm not sure what single test (or small number of such) to beast. Running all tests isn't viable. Suggested CHANGES.txt in "Bugs":

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
AndreyBozhko commented on PR #2471: URL: https://github.com/apache/solr/pull/2471#issuecomment-2135403307 Hi @epugh, I've done another pass over this and I think the change is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-17304: PKG_VERSIONS not honored when loading the schema plugins [solr]

2024-05-28 Thread via GitHub
AndreyBozhko commented on code in PR #2471: URL: https://github.com/apache/solr/pull/2471#discussion_r1617374323 ## solr/core/src/test-files/solr/configsets/conf-using-mypkg-version-1/conf/schema.xml: ## @@ -0,0 +1,36 @@ + + + + Review Comment: Thanks, updated the name

[jira] [Created] (SOLR-17312) Error accessing property 'INDEX.sizeInBytes' in Solr Cloud

2024-05-28 Thread Antony VEYRE (Jira)
Antony VEYRE created SOLR-17312: --- Summary: Error accessing property 'INDEX.sizeInBytes' in Solr Cloud Key: SOLR-17312 URL: https://issues.apache.org/jira/browse/SOLR-17312 Project: Solr Issue