David Smiley created SOLR-17398:
---
Summary: Add Javadoc links from V1 APIs to V2 APIs
Key: SOLR-17398
URL: https://issues.apache.org/jira/browse/SOLR-17398
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-15751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872537#comment-17872537
]
David Smiley commented on SOLR-15751:
-
I agree that for V2 we should have one endpoin
dsmiley commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1712555039
##
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##
@@ -264,11 +268,23 @@ public void processAdd(AddUpdateCommand cmd) th
dsmiley commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1712549704
##
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##
@@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId)
uvatbc commented on PR #2498:
URL: https://github.com/apache/solr/pull/2498#issuecomment-2278924832
> If crave.yml change the Java version to 21, `gradlew check` should fail,
more specifically the `ecj-lint` version that we are currently using make sure
the Java version should be less than
github-actions[bot] commented on PR #2498:
URL: https://github.com/apache/solr/pull/2498#issuecomment-2278892872
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity or converting it to draft will remove the stale label. To attract
more reviewers, please t
[
https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17381.
-
Fix Version/s: 9.8
Resolution: Fixed
Thanks for contributing!
I wondered more about the V
[
https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872445#comment-17872445
]
ASF subversion and git services commented on SOLR-17381:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872440#comment-17872440
]
ASF subversion and git services commented on SOLR-17381:
Commit c
dsmiley merged PR #2599:
URL: https://github.com/apache/solr/pull/2599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
cpoerschke opened a new pull request, #2632:
URL: https://github.com/apache/solr/pull/2632
for `main` and `branch_9x` only, no JIRA or solr/CHANGES.txt entry needed in
my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dsmiley commented on code in PR #2625:
URL: https://github.com/apache/solr/pull/2625#discussion_r1711432544
##
solr/core/src/test/org/apache/solr/TestCrossCoreJoin.java:
##
@@ -246,6 +261,7 @@ public String query(SolrCore core, SolrQueryRequest req)
throws Exception {
@Aft
malliaridis commented on PR #2618:
URL: https://github.com/apache/solr/pull/2618#issuecomment-2278075274
The bats test succeed on my machine now with Java 17 and the latest changes.
I can't reproduce the error anymore from the automation.
--
This is an automated message from the Apache Gi
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1711563638
##
build.gradle:
##
@@ -195,8 +214,8 @@ apply from: file('gradle/hacks/gradle-archives.gradle')
apply from: file('gradle/hacks/wipe-temp.gradle')
apply from: file(
dsmiley commented on PR #2599:
URL: https://github.com/apache/solr/pull/2599#issuecomment-2278047653
+1 Excellent; I'll merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1711540601
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -109,7 +109,7 @@ public void getClusterStatus(NamedList results)
boolean withClus
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1711490702
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -109,7 +109,7 @@ public void getClusterStatus(NamedList results)
boolean withClus
malliaridis commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2277941657
@gerlowskija and @epugh the build errors you have probably occur because of
the jvmargs in `gradpe.properties` that need to be updated. I added
`-Dkotlin.daemon.jvm.options\="-Xmx2048M"
cpoerschke closed pull request #2588: SOLR-13350, SOLR-17298: multi-threaded
search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when
need(TopDocs|MaxScore|DocSet) is false
URL: https://github.com/apache/solr/pull/2588
--
This is an automated message from the Apache Git Service.
cpoerschke commented on PR #2588:
URL: https://github.com/apache/solr/pull/2588#issuecomment-2277879973
closing since thought to be no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872336#comment-17872336
]
Tim Owen commented on SOLR-17397:
-
We've only recently started using child docs (having b
[
https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872335#comment-17872335
]
Gus Heck commented on SOLR-17298:
-
Yeah, probably no need
> Multithreaded search breaks
[
https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck reassigned SOLR-17298:
---
Assignee: Gus Heck
> Multithreaded search breaks limits, and possibly other things
> ---
epugh commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711377616
##
solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java:
##
@@ -314,6 +314,22 @@ public void
testSkippableUpdateIsSkippedIfSki
epugh commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711374955
##
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##
@@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId) t
timatbw commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711372740
##
solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java:
##
@@ -314,6 +314,22 @@ public void
testSkippableUpdateIsSkippedIfS
epugh commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2277829774
I am getting an error when running `./gradlew dev`:
```
Execution failed for task
':solr:compose-ui:compileProductionExecutableKotlinWasmJs'.
> A failure occurred while executing
org.
timatbw commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711363724
##
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##
@@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId)
[
https://issues.apache.org/jira/browse/SOLR-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872331#comment-17872331
]
Eric Pugh commented on SOLR-17397:
--
I appreciate the attention to child docs, which ofte
epugh commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711353839
##
solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java:
##
@@ -314,6 +314,22 @@ public void
testSkippableUpdateIsSkippedIfSki
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1711339498
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2277782852
@rahulgoswami thanks for your work, I was able to take what you did and
find a really nice refactoring on the `-r` option! Looking forward to the next
pr...
--
This is an automated messag
cpoerschke commented on code in PR #2630:
URL: https://github.com/apache/solr/pull/2630#discussion_r1711260464
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -37,7 +37,7 @@ Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to
Con
[
https://issues.apache.org/jira/browse/SOLR-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17397:
--
Labels: pull-request-available (was: )
> Skip atomic updates for non-existent child documents
timatbw opened a new pull request, #2631:
URL: https://github.com/apache/solr/pull/2631
…nts too
https://issues.apache.org/jira/browse/SOLR-17397
# Description
Fix SkipExistingDocumentsProcessor to handle child documents too
# Solution
Now we det
Tim Owen created SOLR-17397:
---
Summary: Skip atomic updates for non-existent child documents
Key: SOLR-17397
URL: https://issues.apache.org/jira/browse/SOLR-17397
Project: Solr
Issue Type: Improveme
[
https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-17386:
---
Affects Version/s: 9.7
> it's now impossible to update solrconfig for coordinators af
[
https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-17386.
Resolution: Fixed
Thanks everyone!
> it's now impossible to update solrconfig for
cpoerschke commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2277500262
> Pushed 2
[changes](https://github.com/apache/solr/pull/2607/commits/aeadce89abe1f8c8239224161306a0c10055b559):
>
> 1. Integrated [cpoerschke](https://github.com/cpoerschke)'s sugg
[
https://issues.apache.org/jira/browse/SOLR-17269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872250#comment-17872250
]
ASF subversion and git services commented on SOLR-17269:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872251#comment-17872251
]
ASF subversion and git services commented on SOLR-17386:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-17269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872248#comment-17872248
]
ASF subversion and git services commented on SOLR-17269:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872249#comment-17872249
]
ASF subversion and git services commented on SOLR-17386:
Commit b
cpoerschke commented on PR #2627:
URL: https://github.com/apache/solr/pull/2627#issuecomment-2277472435
> I wonder if this is important enough to bring to branch_9_7?
I think so, yes, i.e. back porting to both branch_9x and branch_9_7 IMO.
Otherwise we'll unnecessarily include/ship li
cpoerschke merged PR #2546:
URL: https://github.com/apache/solr/pull/2546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
[
https://issues.apache.org/jira/browse/SOLR-17386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872245#comment-17872245
]
ASF subversion and git services commented on SOLR-17386:
Commit 8
cpoerschke merged PR #2607:
URL: https://github.com/apache/solr/pull/2607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
[
https://issues.apache.org/jira/browse/SOLR-17269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872244#comment-17872244
]
ASF subversion and git services commented on SOLR-17269:
Commit 8
48 matches
Mail list logo
