dsmiley commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1732145178
##
solr/solrj/src/java/org/apache/solr/common/util/BytesOutputStream.java:
##
@@ -22,6 +22,7 @@
import java.io.UnsupportedEncodingException;
import java.util.Arrays;
+
[
https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876891#comment-17876891
]
David Smiley commented on SOLR-15748:
-
I filed SOLR-17422 with a PR
> Create v2 equi
[
https://issues.apache.org/jira/browse/SOLR-17422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17422:
--
Labels: pull-request-available (was: )
> Remove CLUSTERSTATE from v2; redundant
>
dsmiley opened a new pull request, #2670:
URL: https://github.com/apache/solr/pull/2670
It's a kitchen sink API that is redundant with finer grain endpoints.
https://issues.apache.org/jira/browse/SOLR-17422
I generated the ref guide to review what the modified page looked like.
[
https://issues.apache.org/jira/browse/SOLR-17422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17422:
Description:
Revert SOLR-15748 – remove v2 /api/cluster being a CLUSTERSTATUS call
The information
David Smiley created SOLR-17422:
---
Summary: Remove CLUSTERSTATE from v2; redundant
Key: SOLR-17422
URL: https://issues.apache.org/jira/browse/SOLR-17422
Project: Solr
Issue Type: Improvement
janhoy commented on PR #2669:
URL: https://github.com/apache/solr/pull/2669#issuecomment-2310997205
> We're on commons-io 2.15.1? We should upgrade to 2.16.1 in this PR
Already open PR for it, but blocked on forbidden-apis: #2398 and
https://github.com/policeman-tools/forbidden-apis/p
[
https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-14370.
--
Resolution: Abandoned
We can always reopen this in the future.
> Refactor bin/solr to allow external o
epugh commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1731673463
##
solr/solrj/src/java/org/apache/solr/common/util/BytesOutputStream.java:
##
@@ -22,6 +22,7 @@
import java.io.UnsupportedEncodingException;
import java.util.Arrays;
+@D
epugh commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1731671282
##
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##
@@ -1054,16 +1055,12 @@ public static InputStream stringToStream(String s) {
* source and thrown away.
*/
epugh commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1731660860
##
solr/core/src/java/org/apache/solr/handler/designer/DefaultSampleDocumentsLoader.java:
##
@@ -65,14 +64,11 @@ public class DefaultSampleDocumentsLoader implements
Sample
[
https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876814#comment-17876814
]
David Smiley commented on SOLR-14370:
-
This is a minor improvement. Any way, my coll
dsmiley commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1731593824
##
solr/core/src/java/org/apache/solr/handler/designer/DefaultSampleDocumentsLoader.java:
##
@@ -65,14 +64,11 @@ public class DefaultSampleDocumentsLoader implements
Samp
madrob commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1731569507
##
solr/core/src/java/org/apache/solr/handler/designer/DefaultSampleDocumentsLoader.java:
##
@@ -65,14 +64,11 @@ public class DefaultSampleDocumentsLoader implements
Sampl
dsmiley commented on code in PR #2669:
URL: https://github.com/apache/solr/pull/2669#discussion_r1731549604
##
solr/solrj/src/java/org/apache/solr/common/util/BytesOutputStream.java:
##
@@ -22,6 +22,7 @@
import java.io.UnsupportedEncodingException;
import java.util.Arrays;
+
gus-asf commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1731444666
##
solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java:
##
@@ -139,30 +142,63 @@ public ReturnFields getReturnFields() {
/**
* If {@link #getRespon
gus-asf commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1731443097
##
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##
@@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more.
=== Confi
gus-asf commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1731441978
##
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##
@@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more.
=== Confi
fsparv commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1731437654
##
solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java:
##
@@ -61,7 +64,7 @@
*/
public class SolrQueryResponse {
public static final String NAME = "res
[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876755#comment-17876755
]
David Smiley commented on SOLR-3913:
[PostTool|https://github.com/apache/solr/blob/108
dsmiley merged PR #2661:
URL: https://github.com/apache/solr/pull/2661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
hiteshk25 commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2310458755
> Now that I have had my head back into 17158 for a bit, I can better
articulate some differences with this PR. This PR presumes that if we hit a
failure we just want to quit as soon as po
sigram commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1731349309
##
solr/CHANGES.txt:
##
@@ -109,8 +109,11 @@ New Features
Improvements
-
+* SOLR-17158: Users for whom partial results are uninteresting may set
pa
gus-asf commented on PR #2666:
URL: https://github.com/apache/solr/pull/2666#issuecomment-2310297839
looking back at https://github.com/apache/solr/pull/2493 I'm exploring if
there are ways to also shorten the case where partial results are desired, but
possibly due to super short CpuTimeAl
dsmiley merged PR #2642:
URL: https://github.com/apache/solr/pull/2642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
iamsanjay commented on PR #2665:
URL: https://github.com/apache/solr/pull/2665#issuecomment-2310129670
Thanks @dweiss for pointing that out. To test that, I added below code to
one of the test case.
```
public void testFailure() {
if(random().nextBoolean()) {
assert
[
https://issues.apache.org/jira/browse/SOLR-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-11640:
--
Labels: pull-request-available (was: )
> bin/post should obey fileType list in all modes
> ---
epugh opened a new pull request, #2668:
URL: https://github.com/apache/solr/pull/2668
https://issues.apache.org/jira/browse/SOLR-11640
# Description
Obey the fileTypes setting!
# Solution
Please provide a short description of the approach taken to implement you
[
https://issues.apache.org/jira/browse/SOLR-15750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617429#comment-17617429
]
Jason Gerlowski edited comment on SOLR-15750 at 8/26/24 11:39 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-11640:
Assignee: Eric Pugh
> bin/post should obey fileType list in all modes
> --
[
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-16470:
---
Description:
Replication Handler has no v2 equivalent. This ticket is covering few endpoints
[
https://issues.apache.org/jira/browse/SOLR-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876690#comment-17876690
]
Eric Pugh commented on SOLR-11966:
--
This is interesting... To tackle this one, it wou
[
https://issues.apache.org/jira/browse/SOLR-12137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-12137.
--
Resolution: Won't Fix
I'd like to close this ticket since we don't have any actual plans around doing
[
https://issues.apache.org/jira/browse/SOLR-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-12341.
--
Resolution: Won't Fix
These days, the post command lives in bin/solr post, and as part of being part
o
[
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876686#comment-17876686
]
Jason Gerlowski commented on SOLR-16470:
That's awesome, thanks for volunteering
[
https://issues.apache.org/jira/browse/SOLR-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876685#comment-17876685
]
Eric Pugh commented on SOLR-13446:
--
One thing that I've been wanting is some good "defau
[
https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876684#comment-17876684
]
Eric Pugh commented on SOLR-14370:
--
I'm reading back up this, and it did seem to elicit
[
https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-14370:
--
Labels: pull-request-available (was: )
> Refactor bin/solr to allow external override of Jetty
[
https://issues.apache.org/jira/browse/SOLR-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876683#comment-17876683
]
Eric Pugh commented on SOLR-13422:
--
Lets get this chased to done!
> bin/post command no
[
https://issues.apache.org/jira/browse/SOLR-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876682#comment-17876682
]
Eric Pugh commented on SOLR-13422:
--
[~agger] would you be interested in testing this on
[
https://issues.apache.org/jira/browse/SOLR-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876681#comment-17876681
]
Eric Pugh commented on SOLR-10189:
--
It turns out we now have a bin/solr cluster command
[
https://issues.apache.org/jira/browse/SOLR-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876677#comment-17876677
]
Eric Pugh commented on SOLR-9272:
-
[~janhoy] and others who have worked on this... I th
[
https://issues.apache.org/jira/browse/SOLR-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-9272.
-
Resolution: Implemented
Marking as already implemented.
> Auto resolve zkHost for bin/solr zk for running
[
https://issues.apache.org/jira/browse/SOLR-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-9259.
-
Resolution: Won't Fix
Thank you for opening this ticket. I am not seeing a lot of energy around the
Had
[
https://issues.apache.org/jira/browse/SOLR-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-7901.
-
Fix Version/s: (was: 6.0)
Resolution: Fixed
These days we've got Java based unit tests PLUS som
[
https://issues.apache.org/jira/browse/SOLR-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-7428.
-
Resolution: Implemented
Thanks for this patch [~andyetitmoves] , there are some interesting ideas in it
w
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876673#comment-17876673
]
Eric Pugh commented on SOLR-6962:
-
Still a bug!
> bin/solr stop -a should complain about
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876672#comment-17876672
]
Eric Pugh commented on SOLR-6962:
-
Doing a little triaging.. These days, bin/solr stop -
[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-3913:
-
Labels: pull-request-available (was: )
> SimplePostTool optimize does a redundant commit
> --
epugh opened a new pull request, #2667:
URL: https://github.com/apache/solr/pull/2667
https://issues.apache.org/jira/browse/SOLR-3913
# Description
if you do a opitmize, don't do a commit, otherwise if you request commit do
it.
# Solution
Be smart about the logic.
[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-3913:
---
Assignee: Eric Pugh
> SimplePostTool optimize does a redundant commit
> -
[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876667#comment-17876667
]
Eric Pugh commented on SOLR-3913:
-
[~dsmiley] i am fixing the first commit/optimize optimi
[
https://issues.apache.org/jira/browse/SOLR-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876665#comment-17876665
]
Eric Pugh commented on SOLR-7268:
-
You may be interested in the work in SOLR-14673 to supp
[
https://issues.apache.org/jira/browse/SOLR-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876661#comment-17876661
]
Eric Pugh commented on SOLR-16254:
--
[~sunrui] thanks for opening this ticket. I just st
mkhludnev commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1730916305
##
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##
Review Comment:
fyi
here is an easier approach for testing time limits
https://github.
55 matches
Mail list logo
