[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-08-08 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1286973313 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -474,6 +509,8 @@ public static String resolveSolrUrl(CommandLine cli) throws Exception { solrUrl =

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-08-08 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1286963177 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -444,8 +453,34 @@ private static void printHelp() { print("Pass -help or -h after any COMMAND to see comma

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-08-08 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1286961989 ## solr/core/src/test/org/apache/solr/cli/SolrCLITest.java: ## @@ -19,7 +19,14 @@ import org.apache.solr.SolrTestCase; import org.junit.Test; -public class SolrCliUptime

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-08-06 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1285218105 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) { } public static SolrCl

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-07-27 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1276630658 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) { } public static SolrCl

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-07-27 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1276584581 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) { } public static SolrCl

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-07-27 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1276296189 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -445,8 +450,31 @@ private static void printHelp() { print("Pass -help or -h after any COMMAND to see comma

[GitHub] [solr] epugh commented on a diff in pull request #1808: SOLR-16800: Move towards using the root of Solr as the -solrUrl in the CLI.

2023-07-27 Thread via GitHub
epugh commented on code in PR #1808: URL: https://github.com/apache/solr/pull/1808#discussion_r1276281337 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -383,6 +383,11 @@ public static boolean exceptionIsAuthRelated(Exception exc) { } public static SolrCl