[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336236341 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336235878 ## solr/prometheus-exporter/src/test-files/solr/security.json: ## Review Comment: yeah, a "metrics" role or a "monitor" role that has what you would need, that way you

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336228358 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java: ## @@ -96,6 +96,13 @@ public class SolrExporter { + ARG_NUM_THREADS_DE

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336227295 ## solr/prometheus-exporter/src/test-files/solr/security.json: ## Review Comment: Here is the "default" security.json that we now have! https://github.com/apache/solr

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336226900 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336203092 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java: ## Review Comment: Maybe I just wished we could use one of the other fa

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336202283 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336201491 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java: ## @@ -47,42 +54,45 @@ public class SolrStandaloneScraperTest extends

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336087033 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java: ## @@ -47,42 +54,45 @@ public class SolrStandaloneScraperTest extends

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336085950 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336084359 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336083135 ## solr/prometheus-exporter/src/test-files/solr/security.json: ## Review Comment: have you seen the new "sane defaults" security.json? It declares four roles, index,

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336081208 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java: ## @@ -266,6 +296,12 @@ public static void main(String[] args) { cluster

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336080221 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java: ## @@ -242,6 +256,22 @@ public static void main(String[] args) { .setDef

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336079691 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java: ## @@ -96,6 +96,20 @@ public class SolrExporter { + ARG_NUM_THREADS_DE

[GitHub] [solr] epugh commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

epugh commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336078795 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java: ## Review Comment: Do we need this class? Probably, but I wonder if it