[GitHub] [solr] gerlowskija commented on pull request #1832: SOLR-16733: Toggle Sec Manager when OSX+JDK20 used

2023-08-17 Thread via GitHub
gerlowskija commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1682886382 Alright, I've updated the PR in line with my comment above and previous feedback. With these changes, the whole test run now fails with: ``` $ export "RUNTIME_JAVA_HOME=/usr/lo

[GitHub] [solr] gerlowskija commented on pull request #1832: SOLR-16733: Toggle Sec Manager when OSX+JDK20 used

2023-08-17 Thread via GitHub
gerlowskija commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1682800074 > I mean that we shouldn't even run the tests at all. Disabling the security manager for tests and saying "hey look on JDK 20 on Mac tests pass" but we just hide the fact that we disable

[GitHub] [solr] gerlowskija commented on pull request #1832: SOLR-16733: Toggle Sec Manager when OSX+JDK20 used

2023-08-09 Thread via GitHub
gerlowskija commented on PR #1832: URL: https://github.com/apache/solr/pull/1832#issuecomment-1671886686 > this just seems like a terrible way to do this. We shouldn't even run tests this way on Mac. It gives a false sense of security that things are working when they really aren't.