[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334880267 ## solr/bin/solr: ## @@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then . "$SOLR_INCLUDE" fi +# Export variables we want to make visible to Solr sub-process +for

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334729823 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334695590 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334695590 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334344311 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1333971080 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1330348141 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1330341363 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -0,0 +1,60 @@ +# Mapping from Environment variable to system property +# This file only contains non-stand

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1330341363 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -0,0 +1,60 @@ +# Mapping from Environment variable to system property +# This file only contains non-stand

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1329800978 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328988330 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## Review Comment: Searching for `System.getProperty` and `-D…` takes you a long way.. ## solr/c

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328985748 ## solr/bin/solr: ## @@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then . "$SOLR_INCLUDE" fi +# Export all SOLR variables so they are visible to Solr sub-process

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328508569 ## solr/core/src/java/org/apache/solr/util/ModuleUtils.java: ## @@ -56,17 +55,9 @@ public static Path getModuleLibPath(Path solrInstallDirPath, String moduleName) * @r

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328506613 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328441524 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li