[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064698824 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -259,6 +260,14 @@ public FileVisitResult postVisitDirectory(Path dir, IOException ioExce

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064698615 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -250,7 +251,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs)

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064697931 ## solr/core/src/test/org/apache/solr/core/TestConfigSetService.java: ## @@ -77,24 +72,31 @@ public void testConfigSetServiceOperations() throws IOException { byte[]

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168782 ## solr/core/src/test/org/apache/solr/core/TestConfigSetService.java: ## @@ -108,16 +110,14 @@ public void testConfigSetServiceOperations() throws IOException { ass

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168758 ## solr/core/src/test/org/apache/solr/core/TestConfigSetService.java: ## @@ -77,24 +72,31 @@ public void testConfigSetServiceOperations() throws IOException { byte[]

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168704 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -259,6 +260,14 @@ public FileVisitResult postVisitDirectory(Path dir, IOException ioExce

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1064168669 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -250,7 +251,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs)

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1063815270 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1062881305 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1062653536 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1062648382 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1061851039 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1048817209 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1048775867 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1048708781 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {