[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303627276 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -567,6 +575,7 @@ public static class NodeConfigBuilder { private String defaultZkHost; privat

[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303627276 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -567,6 +575,7 @@ public static class NodeConfigBuilder { private String defaultZkHost; privat

[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303292779 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -567,6 +575,7 @@ public static class NodeConfigBuilder { private String defaultZkHost; privat

[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303284476 ## solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303281456 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -135,4 +182,8 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex, Logger log) { erro

[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303280414 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -28,6 +28,11 @@ public class ResponseUtils { private ResponseUtils() {} + // System proper

[GitHub] [solr] stillalex commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

stillalex commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1296299519 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -96,6 +120,22 @@ public static int getErrorInfo(Throwable ex, NamedList info, Logger log) *