[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-16 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1296183918 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software F

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-16 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1296094876 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software F

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-16 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1296026006 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software F

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-16 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1296026006 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software F

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-16 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1296026006 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software F

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295202810 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -510,18 +507,21 @@ protected void populateTracingSpan(Span span) { // if this api has commands ...

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295082536 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -255,15 +247,12 @@ private void dispatch( Action result = call.call(); switch

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295080612 ## solr/core/src/java/org/apache/solr/api/AnnotatedApi.java: ## @@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse rsp) { } for (C

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295031075 ## solr/core/src/java/org/apache/solr/api/AnnotatedApi.java: ## @@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse rsp) { } for (C

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295032461 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -16,38 +16,56 @@ */ package org.apache.solr.opentelemetry; -

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294595678 ## solr/core/src/java/org/apache/solr/util/tracing/HttpServletRequestGetter.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294592758 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -977,15 +979,32 @@ protected void writeResponse( } if (Method.HEAD != reqMethod) {

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294592415 ## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ## @@ -241,6 +243,18 @@ public void handleRequest(SolrQueryRequest req, SolrQueryResponse rsp) {

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294580656 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -510,18 +507,21 @@ protected void populateTracingSpan(Span span) { // if this api has commands ...

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294556596 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -977,15 +979,32 @@ protected void writeResponse( } if (Method.HEAD != reqMethod) {

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294577381 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -16,38 +16,56 @@ */ package org.apache.solr.opentelemetry; -

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294556596 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -977,15 +979,32 @@ protected void writeResponse( } if (Method.HEAD != reqMethod) {

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294555321 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -16,38 +16,56 @@ */ package org.apache.solr.opentelemetry; -

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294554607 ## solr/core/src/java/org/apache/solr/core/TracerConfigurator.java: ## @@ -17,83 +17,88 @@ package org.apache.solr.core; -import io.opentracing.Scope; -import io.op

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294552518 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -16,38 +16,56 @@ */ package org.apache.solr.opentelemetry; -

[GitHub] [solr] stillalex commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

2023-08-15 Thread via GitHub
stillalex commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294549451 ## solr/core/src/java/org/apache/solr/api/AnnotatedApi.java: ## @@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse rsp) { } for (C