stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1634740945
thank you for taking a look @HoustonPutman!
sorry I did a few force push trying to update the changes file. should be
good now.
--
This is an automated message from the Apache Git Se
stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1633255820
@epugh no updates on this one from anyone else. should I shoot an email to
dev list to check is anyone has any strong opinions against merging?
--
This is an automated message from the A
stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1612217008
@epugh posted some perf numbers, but I think the confidence we are looking
for is more in the correctness side, rather than speed :) so probably someone
more familiar with the area could v
stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1612215529
I recently added some benchmarks, would really hope people look at them and
validate the data patters (number of docs, size, threads and so on), but as
they stand, here are the numbers on
stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1612213493
fixed a `tidy` problem and pushed again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1611823614
> For changes like this, I wish there was a way for me, as someone who
hasn't really worked deeply in this code base to know that this is a positivie
safe change
I agree with the se
stillalex commented on PR #1728:
URL: https://github.com/apache/solr/pull/1728#issuecomment-1609762594
@HoustonPutman fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
