stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1682180045
> PS: Did you do a broader review of tag name changes apart from the two we
covered, or should we put it up as a new JIRA?
No review yet. I was thinking I could do one as part of SOL
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1681573914
moved the simple otel update to https://github.com/apache/solr/pull/1846
will rebase once that is in
--
This is an automated message from the Apache Git Service.
To respond to the messag
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680999594
quick smoke test on benchmarking side, I tried running the existing
`CloudIndexing` benchmark and numbers seem pretty close (I am sure there are
more opportunities for improvement but I di
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1680832985
> Would you like to give the docs a shot @stillalex ? Also, please add a
line to CHANGES.txt.
@janhoy updated, please take a look.
Just to run one idea by you: the otel librar
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679730960
> Perhaps we should emit both for some versions, or implement the suggested
env var OTEL_SEMCONV_STABILITY_OPT_IN?
if this is for 2 fields only (`http.status_code` =>
`http.response
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679674060
quick comparison of _Indexing_ span data (exporting from jaeger on 9.3 vs
this PR):
Update spans on this PR
```
{
"data": [
{
"trac
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679664416
quick comparison of span data (exporting from jaeger on 9.3 vs this PR):
Query spans on this PR
```
{
"data": [
{
"traceID": "b3e378
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1679599489
sorry, had to do a rebase on top of main branch to fix some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
stillalex commented on PR #1841:
URL: https://github.com/apache/solr/pull/1841#issuecomment-1678936745
Thank you @janhoy for the review!
I think the biggest question was the removal of span.log. it felt strange to
have logs mixed with spans. maybe I misunderstood the use. happy to loo
