stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1691956569
@dsmiley I apparently forgot to update log4j config (so we can actually see
this trace id). I could swear I had seen the trace id in there before (maybe
too much local patching). I will op
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1690788877
@dsmiley did a recap above and pushed a few more commits. I would like to
leave it on by default to catch regressions early, I will disable it if it
turns out to be too noisy.
I think
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1688098261
@dsmiley I wanted to make sure this review is headed in the right direction.
I feel we got sidetracked with a number of thing unrelated to this proposal for
trace id generation, but rather
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1687120500
I took a stab at having this on by default, just to see what the tests say.
and it looks ok so far. I am also open to not doing this right away, to allow
for some more testing time.
--
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1687016572
@dsmiley I added a tentative update for the apache httpclient based you
feedback so far. please take a look. the test is fragile, as it assumes the api
call will rely on apache http client
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1686762490
> I disagree; both are "instrumentation" and the class name was already
chosen in this generic way instead of being called MetricsBlahBlahBlah.
Nonetheless the concerns could be split up t
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1686650312
I think I understand what you are saying. but I think it was misleading to
say propagation doesn't work (I think you partially corrected later by saying
"won't propagate tracing"). a more
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1686314216
> FYI, one gap in propagation is that our Apache HttpClient isn't
instrumented with tracing, only the Jetty HttpClient. I actually have a fix for
this locally.
could you be a bit mo
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1685416582
@dsmiley thank you for the review so far. I managed to successfully move the
functionality to solr-core without extra dependencies (just api and context). I
think this allows for much more
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1685121875
> It's kind of a shame to require the whole open tracing SDK for this
functionality but so be it.
you raise a very interesting point, and I think this could work without the
sdk. it
stillalex commented on PR #1854:
URL: https://github.com/apache/solr/pull/1854#issuecomment-1684942884
@dsmiley would love your thoughts on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
11 matches
Mail list logo
