luiseterc commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2306678676
Thanks @janhoy We'll do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
janhoy commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2304766444
> Will that be backported to 8.11?
@luiseterc It is not decided whether there will ever be another 8.11.x
relese, as 8.11 will be EOL once 10.0 lands this fall. If I were you I'd test
luiseterc commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2304533301
Will that be backported to 8.11? We recently started using the
CloudSolrClient client in our Java applications and the performance went south.
We are experiencing high latencies, millions
dsmiley merged PR #2571:
URL: https://github.com/apache/solr/pull/2571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2257130669
I reported one of those test failures to Houston as it's a fresh issue. The
other is a long-time flaky failure; shouldn't be affected by this change.
I think this is ready!
CH
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1696009637
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -362,8 +362,8 @@ private NamedList
directUpdate(AbstractUpdateRequest request,
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695995454
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -262,26 +265,34 @@ public void testAliasHandling() throws Exception {
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695801350
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -262,26 +265,34 @@ public void testAliasHandling() throws Exception {
publ
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695690868
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +260,58 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695687677
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1149,7 +1149,7 @@ private Set resolveAliases(List
inputCollections) {
}
aparnasuresh85 commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2256383781
> The previous PR to solve this
[apache/lucene-solr#2086](https://github.com/apache/lucene-solr/pull/2086) has
a test suggesting the alias matter only results in one request?
T
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695462899
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +257,52 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695462899
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +257,52 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695462899
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +257,52 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1695459965
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +257,52 @@ public void testAliasHandling() throws Exception {
dsmiley commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2256229574
The previous PR to solve this
https://github.com/apache/lucene-solr/pull/2086 has a test suggesting the alias
matter only results in one request?
An aside: if we don't solve/improve t
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1694463314
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +257,52 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690592214
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690592151
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690591569
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -325,6 +325,11 @@ protected void init() throws Exception {
addCollectionParamIfNeede
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690542590
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690524467
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {
}
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690487661
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +257,81 @@ public void testAliasHandling() throws Exception {
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690380168
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1228,9 +1199,15 @@ protected DocCollection getDocCollection(String
collection, Integ
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690380168
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1228,9 +1199,15 @@ protected DocCollection getDocCollection(String
collection, Integ
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690370559
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1228,9 +1199,15 @@ protected DocCollection getDocCollection(String
collection, Integ
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690233893
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -93,6 +94,22 @@ public class CloudHttp2SolrClientTest extends
SolrClo
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690201866
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +267,36 @@ public void testAliasHandling() throws Exception {
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1690194393
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -93,6 +94,22 @@ public class CloudHttp2SolrClientTest extends
SolrCloudTestC
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1689976255
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +250,51 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1689971949
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -124,7 +119,10 @@ private ClusterState fetchClusterState(
t
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1689968198
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1689968198
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1688601156
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integ
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1688240886
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -124,7 +124,14 @@ private ClusterState fetchClusterState(
t
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1688159135
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +250,51 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687153189
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integ
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687117265
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -262,12 +263,18 @@ public void testHttpCSPPerf() throws Exception {
http
aparnasuresh85 commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2243168467
> I love the sequence diagrams! What tool did you use to draw it?
>
Plant UML - It can be installed as a plugin in IntelliJ
--
This is an automated message from the Ap
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1686678910
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +249,45 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1686678323
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientCacheTest.java:
##
@@ -156,6 +156,15 @@ public List resolveAlias(String collection) {
dsmiley commented on PR #2571:
URL: https://github.com/apache/solr/pull/2571#issuecomment-2241266022
I love the sequence diagrams! What tool did you use to draw it?
RE aliases: I was anticipating that this PR might regress the alias
functionality. But CloudHttp2SolrClientTest.testA
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1685236741
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientCacheTest.java:
##
@@ -156,6 +156,15 @@ public List resolveAlias(String collection) {
public
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1685215019
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integ
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1685176739
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -22,12 +22,7 @@
import java.io.IOException;
import java.lang.invoke.Met
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684977532
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -124,7 +124,14 @@ private ClusterState fetchClusterState(
throws S
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684972908
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -124,7 +119,10 @@ private ClusterState fetchClusterState(
throws S
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684685937
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -124,7 +119,10 @@ private ClusterState fetchClusterState(
t
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684685495
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -22,12 +22,7 @@
import java.io.IOException;
import java.lang.inv
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684685675
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##
@@ -31,7 +29,7 @@
public interface ClusterStateProvider extends SolrCloseabl
epugh commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1684536395
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -22,12 +22,7 @@
import java.io.IOException;
import java.lang.invoke.Metho
aparnasuresh85 opened a new pull request, #2571:
URL: https://github.com/apache/solr/pull/2571
…rStateProvider
https://issues.apache.org/jira/browse/SOLR-14985
# Description
Outlined below is the perf impact for /select request. Similar issues exist
on the /updat
56 matches
Mail list logo
