epugh merged PR #2471:
URL: https://github.com/apache/solr/pull/2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
AndreyBozhko commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2140018509
Thanks @gerlowskija, appreciate you looking into this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gerlowskija commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2139909782
I've reverted my commit on main to get this unblocked, and merged 'main'
into the PR branch. The test passes for me locally now. Let me know if
there's any other issues @AndreyBozhko
gerlowskija commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2139661307
Hi @AndreyBozhko - sorry for the delay in unblocking this.
The reason your test started failing is that [my recent
epugh commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2139655943
@AndreyBozhko give me a ping when this is syned with main!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gerlowskija commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2136063043
Thanks for flagging this @AndreyBozhko.
I'll take a look and try to fix the test in this PR tomorrow. Sorry to hold
this up!
--
This is an automated message from the Apache
AndreyBozhko commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2136007603
Looks like the test failure is due to the latest commit 8c5ae1b to main.
@gerlowskija Could you take a look at this?
It seems like the "Convert /cluster filestore APIs to
AndreyBozhko commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2135968815
> @AndreyBozhko did you see the build failure?
Hm, I'll try to rebase off of the tip of the main branch and see if I can
reproduce the failure...
--
This is an automated
epugh commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2135923942
@AndreyBozhko did you see the build failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AndreyBozhko commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1617551538
##
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##
@@ -694,16 +694,32 @@ public boolean addToCoreAware(T obj) {
}
}
- void
AndreyBozhko commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1617546510
##
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##
@@ -694,9 +694,14 @@ public boolean addToCoreAware(T obj) {
}
}
+ void
AndreyBozhko commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2135403307
Hi @epugh, I've done another pass over this and I think the change is ready
for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please
AndreyBozhko commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1617374323
##
solr/core/src/test-files/solr/configsets/conf-using-mypkg-version-1/conf/schema.xml:
##
@@ -0,0 +1,36 @@
+
+
+
+
Review Comment:
Thanks, updated the name
epugh commented on PR #2471:
URL: https://github.com/apache/solr/pull/2471#issuecomment-2124630652
> > It seems like if your test is passing, then you've fixed the bug!
>
> The test does pass - but for completeness, I still want to check what
happens when the collection is reloaded
epugh commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1609830946
##
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##
@@ -694,9 +694,14 @@ public boolean addToCoreAware(T obj) {
}
}
+ void
AndreyBozhko commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1608792092
##
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##
@@ -694,9 +694,14 @@ public boolean addToCoreAware(T obj) {
}
}
+ void
epugh commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1608596554
##
solr/core/src/test-files/solr/configsets/conf-using-mypkg-version-1/conf/schema.xml:
##
@@ -0,0 +1,36 @@
+
+
+
+
Review Comment:
I think we change up the schema
17 matches
Mail list logo
