Seunghan-Jung commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2426218449
@dsmiley
I believe the PR I worked on to fix a bug
(https://github.com/apache/lucene/pull/13832) is for Lucene version 10. I
thought it would be merged before Solr version 10.
--
dsmiley commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2425412127
Proposed CHANGES.txt for 9.8, New Feature:
> SOLR-17444: The UnifiedHighlighter now supports an hl.passageSort option
to control passage ordering per document startOffset|endOffset|sco
Seunghan-Jung commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779548037
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,26 @@ protected PassageFormatter getFormatter(String fieldName) {
Seunghan-Jung commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779530690
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
Seunghan-Jung commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2380669818
> It's somewhat unfortunate to have no Solr level test... but not strictly
necessary. You could probably add a query & assertion to a test method in
TestUnifiedSolrHighlighter. Just sh
Seunghan-Jung commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2380663931
@dsmiley
> Just a thought -- is this enum actually buying us anything at all? It's a
bunch of lines of code but only ultimately used for a set lookup and nothing
else? If so, lets
dsmiley commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2380643974
Just a thought -- is this enum actually buying us anything at all? It's a
bunch of lines of code but only ultimately used for a set lookup and nothing
else? If so, lets just have less line
dsmiley commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779363345
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
ret
Seunghan-Jung commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779351977
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
dsmiley commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779120744
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
ret
Seunghan-Jung opened a new pull request, #2697:
URL: https://github.com/apache/solr/pull/2697
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
11 matches
Mail list logo
