[jira] [Assigned] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-01 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-17264: - Assignee: Noble Paul > Reproducible Seed for OverseerStatusTest Failure >

[jira] [Commented] (SOLR-17088) TestPrepRecovery.testLeaderNotResponding fails much more lately

2024-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842821#comment-17842821 ] David Smiley commented on SOLR-17088: - Wow; you deserve an award of some kind for root causing that

[jira] [Commented] (SOLR-17261) Core loading is capped at 60 seconds

2024-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842815#comment-17842815 ] ASF subversion and git services commented on SOLR-17261: Commit

[jira] [Resolved] (SOLR-17261) Core loading is capped at 60 seconds

2024-05-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-17261. --- Fix Version/s: 9.6.1 9.7 Resolution: Fixed > Core loading is

[jira] [Commented] (SOLR-17261) Core loading is capped at 60 seconds

2024-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842813#comment-17842813 ] ASF subversion and git services commented on SOLR-17261: Commit

[jira] [Commented] (SOLR-17261) Core loading is capped at 60 seconds

2024-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842812#comment-17842812 ] ASF subversion and git services commented on SOLR-17261: Commit

Re: [PR] SOLR-17261: Allow cores to load without a timeout [solr]

2024-05-01 Thread via GitHub
HoustonPutman merged PR #2431: URL: https://github.com/apache/solr/pull/2431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-01 Thread via GitHub
kotman12 commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2089353858 > Ease of configuration might be a reason? Or could one imagine a scenario where indexing and searching wish to use different presearcher types or settings? I think it would be

[jira] [Comment Edited] (SOLR-17088) TestPrepRecovery.testLeaderNotResponding fails much more lately

2024-05-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842810#comment-17842810 ] Houston Putman edited comment on SOLR-17088 at 5/2/24 12:50 AM: Wow this

Re: [PR] [SOLR-16497] Allow finer grained locking in SolrCores [solr]

2024-05-01 Thread via GitHub
github-actions[bot] commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-2089311201 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java: ## @@ -56,6 +58,10 @@ public abstract class

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586911809 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java: ## @@ -56,6 +58,10 @@ public abstract class

Re: [PR] SOLR-17261: Allow cores to load without a timeout [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on PR #2431: URL: https://github.com/apache/solr/pull/2431#issuecomment-2089193456 I've simplified the logic, definitely went overboard on the first attempt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1586827784 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on PR #2436: URL: https://github.com/apache/solr/pull/2436#issuecomment-2089162157 Thanks for the info on those. I've standardized both the reseting of sysProps as well as where the option is set from. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (SOLR-17266) Investigate avoiding Jetty "____v2" path rewrite

2024-05-01 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842779#comment-17842779 ] Gus Heck commented on SOLR-17266: - The ultimate way to improve this (ignoring effort momentarily) is to

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r158684 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -2849,9 +2834,14 @@ public boolean checkIfCoreNodeNameAlreadyExists(CoreDescriptor dcore) { *

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1586807196 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { }

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586786180 ## solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java: ## @@ -140,28 +143,29 @@ public static void shutdownCluster() throws Exception {

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1586783103 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { }

Re: [PR] SOLR-17257: Avoid instantiating NodeStateProvider several times when computing replica placement [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on PR #2420: URL: https://github.com/apache/solr/pull/2420#issuecomment-2089068594 Nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-05-01 Thread via GitHub
dsmiley commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-2089008592 I looked at the [test history](https://ge.apache.org/scans/tests?search.relativeStartTime=P90D=solr-root=America%2FNew_York=org.apache.solr.search.TestCoordinatorRole) -- seems flaky. I

Re: [PR] SOLR-17257: Avoid instantiating NodeStateProvider several times when computing replica placement [solr]

2024-05-01 Thread via GitHub
dsmiley merged PR #2420: URL: https://github.com/apache/solr/pull/2420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17049: Fix Replica Down on startup logic [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2432: URL: https://github.com/apache/solr/pull/2432#discussion_r1586719024 ## solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java: ## @@ -181,29 +183,46 @@ public String getShardId(String nodeName, String coreName) { }

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586713299 ## solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java: ## @@ -140,29 +138,18 @@ public static void shutdownCluster() throws Exception {

Re: [PR] fixTestUninvertingReader [solr]

2024-05-01 Thread via GitHub
dsmiley merged PR #2422: URL: https://github.com/apache/solr/pull/2422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586652988 ## solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java: ## @@ -83,7 +83,7 @@ public class SolrCloudTestCase extends SolrTestCaseJ4 { private

[PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
HoustonPutman opened a new pull request, #2436: URL: https://github.com/apache/solr/pull/2436 https://issues.apache.org/jira/browse/SOLR-17265 This fixes the test errors introduced by https://github.com/apache/solr/pull/2230 I'm not really certain what the previous logic was

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2088918365 Ok created a PR to fix this, I'm not sure what the logic here was supposed to be, but I've changed PRS to be a much more normal per-test-class randomized option. -- This is an

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-05-01 Thread via GitHub
laminelam commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2088871902 > @laminelam I'm following up my response last night. What do you think about removing the class loader stuff from this PR and just getting the refactor in, and then having a seperate PR

[jira] [Commented] (SOLR-17160) Bulk admin operations may fail because of max tracked requests

2024-05-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842732#comment-17842732 ] David Smiley commented on SOLR-17160: - BTW I think Denial of Service should be a non-concern for

[jira] [Commented] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-01 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842725#comment-17842725 ] Andy Webb commented on SOLR-17263: -- Thanks James, and no worries! I want to understand the code better,

[jira] [Commented] (SOLR-17160) Bulk admin operations may fail because of max tracked requests

2024-05-01 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842698#comment-17842698 ] Jason Gerlowski commented on SOLR-17160: bq. 100 is clearly way too low. +1...to tweaking the

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-05-01 Thread via GitHub
cpoerschke commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2088667529 Thanks for the notes above, they helped me continue browsing the code to see how the `Presearcher` fits in and how the various objects are currently put together. So with indexing

[jira] [Commented] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-05-01 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842689#comment-17842689 ] James Dyer commented on SOLR-17263: --- [~andywebb1975] Thank you for being an early adopter of this new

[PR] SOLR-17263: HttpJdkSolrClient doesn't encode curly braces etc (follow-up PR) [solr]

2024-05-01 Thread via GitHub
jdyer1 opened a new pull request, #2435: URL: https://github.com/apache/solr/pull/2435 This is a follow up to [PR ](https://github.com/apache/solr/pull/2433). Using @andywebb1975 fix for `HttpJdkSolrClient` this adds a unit test, adding `fq="{!terms f=myfield}value1,value2` to

Re: [PR] SOLR-17076: Optimize `OrderedNodePlacementPlugin#getAllReplicasOnNode` [solr]

2024-05-01 Thread via GitHub
justinrsweeney commented on PR #2076: URL: https://github.com/apache/solr/pull/2076#issuecomment-2088534839 Thanks for the reminder, will make sure next time! On Wed, May 1, 2024 at 10:06 AM David Smiley ***@***.***> wrote: > Just a little reminder... when squash-merging,

Re: [PR] SOLR-17076: Optimize `OrderedNodePlacementPlugin#getAllReplicasOnNode` [solr]

2024-05-01 Thread via GitHub
dsmiley commented on PR #2076: URL: https://github.com/apache/solr/pull/2076#issuecomment-2088515065 Just a little reminder... when squash-merging, remember to edit the commit message so it's cleaned up to reflect the final result in totality; it's almost always necessary. Should not

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-05-01 Thread via GitHub
gus-asf commented on code in PR #2415: URL: https://github.com/apache/solr/pull/2415#discussion_r1586246848 ## dev-docs/releasing.adoc: ## @@ -0,0 +1,73 @@ + += Releasing Solr +:toc: left + +== Motivated? +So you're of the opinion that there are unreleased features or bugfixes

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-05-01 Thread via GitHub
gus-asf commented on code in PR #2415: URL: https://github.com/apache/solr/pull/2415#discussion_r1586242677 ## dev-docs/releasing.adoc: ## @@ -0,0 +1,73 @@ + += Releasing Solr +:toc: left + +== Motivated? +So you're of the opinion that there are unreleased features or bugfixes

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub
gus-asf commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2088385840 Neither this PR nor the commit mention a jira so I'll drop this here: https://issues.apache.org/jira/browse/SOLR-17265 -- This is an automated message from the Apache Git Service. To

[jira] [Created] (SOLR-17265) Reproducing Failure: OverseerStatusTest after commit 9c9250c6

2024-05-01 Thread Gus Heck (Jira)
Gus Heck created SOLR-17265: --- Summary: Reproducing Failure: OverseerStatusTest after commit 9c9250c6 Key: SOLR-17265 URL: https://issues.apache.org/jira/browse/SOLR-17265 Project: Solr Issue

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub
gerlowskija commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2088376107 +1 I spent a bunch of time on this this morning after running into OverseerStatusTest failures on main, before stumbling on this discussion. Any chance you're able to investigate

[jira] [Updated] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-01 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-17264: --- Description: OverseerStatusTest has been failing in about 8% of runs since mid February

[jira] [Created] (SOLR-17264) Reproducible Seed for OverseerStatusTest Failure

2024-05-01 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17264: -- Summary: Reproducible Seed for OverseerStatusTest Failure Key: SOLR-17264 URL: https://issues.apache.org/jira/browse/SOLR-17264 Project: Solr Issue

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-05-01 Thread via GitHub
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-2088106960 Build failed due to one of the flaky test cases as test passing when ran again. > gradlew :solr:core:test --tests "org.apache.solr.search.TestCoordinatorRole.testNRTRestart"