[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-03-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1517 > I'm not sure we can do without this. I know I had problems which lead me to do this which may be related to older versions of Bison. Note that it works for 3.0.4 compared to

[GitHub] trafficserver pull request #1517: Remove BisonHeaderToC++.sed

2017-02-28 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1517 Remove BisonHeaderToC++.sed We can do without it, and less is more? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver

[GitHub] trafficserver issue #1435: Prefer setting AM_CPPFLAGS vs. CPPFLAGS, etc.

2017-02-23 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1435 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #1435: Prefer setting AM_CPPFLAGS vs. CPPFLAGS, e...

2017-02-23 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1435: Prefer setting AM_CPPFLAGS vs. CPPFLAGS, etc.

2017-02-23 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1435 @zwoop Yes please! I rebased this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

2017-02-16 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1439: Add BIO_sock_non_fatal_error() attribution

2017-02-16 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...

2017-02-13 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1440#discussion_r100845545 --- Diff: lib/raft/raft_impl.h --- @@ -338,8 +338,8 @@ template class RaftImpl : public Raft if (!i_am_leader()) return

[GitHub] trafficserver pull request #1439: Add BIO_sock_non_fatal_error() attribution

2017-02-12 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1439 Add BIO_sock_non_fatal_error() attribution Fixes #1437 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver

[GitHub] trafficserver pull request #1438: BoringSSL doesn't have BIO_sock_non_fatal_...

2017-02-12 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1438#discussion_r100697717 --- Diff: iocore/net/BIO_fastopen.cc --- @@ -27,6 +27,67 @@ #include "BIO_fastopen.h" +// For BoringSSL, which for s

[GitHub] trafficserver issue #1431: CI builds fail on some platforms

2017-02-10 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

2017-02-10 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1438: BoringSSL doesn't have BIO_sock_non_fatal_...

2017-02-10 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1438 BoringSSL doesn't have BIO_sock_non_fatal_error() Fixes #1437 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/traffics

[GitHub] trafficserver issue #1437: Build fail with BoringSSL

2017-02-10 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1437 Hmm -- I see what you mean -- BoringSSL sock_read() and sock_write() have used bio_fd_non_fatal_error() since [1], which claims to be a fork from https://github.com/openssl/openssl/commit

[GitHub] trafficserver issue #1321: 6.2.x TS-4435 and TS-5059: Fixes for building wit...

2017-02-09 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1321 @PSUdaemon Sure thing -- I rebased this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request #1435: Prefer setting AM_CPPFLAGS vs. CPPFLAGS, e...

2017-02-09 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1435 Prefer setting AM_CPPFLAGS vs. CPPFLAGS, etc. Autoconf and Automake discourage setting some Makefile variables [1]. They encourage setting their AM_ variants instead. [1] https

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

2017-02-09 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1433#discussion_r100367866 --- Diff: configure.ac --- @@ -1937,6 +1939,9 @@ AC_CONFIG_FILES([ tools/tsxs ]) +AC_CONFIG_FILES([tools/check-unused

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

2017-02-09 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1433 Get the list of files from Autoconf vs. Git This will work with source tarballs as well as checkouts. Fixes #1431 You can merge this pull request into a Git repository by running

[GitHub] trafficserver issue #1424: Backport unused dependency check to Python 2.6

2017-02-08 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1424 Thanks @masaori335! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1424: Backport unused dependency check to Python...

2017-02-08 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1424: Backport unused dependency check to Python...

2017-02-08 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1424 Backport unused dependency check to Python 2.6 We support CentOS 6, which comes with Python 2.6. Set literals were introduced in Python 2.7. You can merge this pull request into a Git

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

2017-02-08 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1416: TS-1878: Add --as-needed to the linker flags

2017-02-08 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1416 Merged. Thanks @zwoop! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1416: TS-1878: Add --as-needed to the linker fla...

2017-02-08 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1411: Replace EXTRA_CXX_LDFLAGS with AM_LDFLAGS

2017-02-08 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1411: Replace EXTRA_CXX_LDFLAGS with AM_LDFLAGS

2017-02-08 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1411 This PR is included in #1416. I'm landing that one, so I'm merging both pull requests. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1385: sslheaders plugin fails with OpenSSL v1.1.0d

2017-02-08 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1384: Warnings when compiling against OpenSSL 1.1.0d

2017-02-08 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1388: Fixes for building with OpenSSL 1.1

2017-02-08 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1388 Merged. Thanks @zwoop! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1388: Fixes for building with OpenSSL 1.1

2017-02-08 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are a...

2017-02-07 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

2017-02-07 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1398#discussion_r99888612 --- Diff: configure.ac --- @@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk], AC_MSG_RESULT([$enable_fast_sdk]) TS_ARG_ENABLE_VAR([use], [fast

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

2017-02-07 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1398#discussion_r99878821 --- Diff: cmd/traffic_top/Makefile.am --- @@ -17,13 +17,13 @@ # We only build traffic_top if libcurses and libcurl are available. if

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

2017-02-07 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1398#discussion_r99866474 --- Diff: configure.ac --- @@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk], AC_MSG_RESULT([$enable_fast_sdk]) TS_ARG_ENABLE_VAR([use], [fast

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

2017-02-07 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1398#discussion_r99871965 --- Diff: cmd/traffic_top/Makefile.am --- @@ -17,13 +17,13 @@ # We only build traffic_top if libcurses and libcurl are available. if

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

2017-02-07 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1392 @zwoop Yes -- I'm happy to make any changes, but I think it's ready to land. If you approve, I'll merge it. --- If your project is set up for it, you can reply to this emai

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

2017-02-02 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1408 I rebased this onto #1416. My theory is that traffic_top (etc.) was getting hwloc (etc.) because of Libtool's link_all_deplibs [1]. As I understand it, when Libtool links to a library (l

[GitHub] trafficserver pull request #1416: TS-1878: Add --as-needed to the linker fla...

2017-02-02 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1416 TS-1878: Add --as-needed to the linker flags Normally the linker will link to every -llibrary mentioned on the command line. This option causes it to skip libraries that it doesn'

[GitHub] trafficserver pull request #1414: TS-2274: Drop vestigial Autoconf output va...

2017-02-02 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1414: TS-2274: Drop vestigial Autoconf output va...

2017-02-02 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1414 TS-2274: Drop vestigial Autoconf output variable We haven't used defer_accept since we minimized the default records.config. You can merge this pull request into a Git reposito

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

2017-02-02 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1408#discussion_r99212271 --- Diff: iocore/cache/Cache.cc --- @@ -1041,12 +1041,12 @@ CacheProcessor::cacheInitialized() case CACHE_COMPRESSION_FASTLZ

[GitHub] trafficserver pull request #1405: TS-552: Trivial Autoconf cleanup

2017-02-02 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1405 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1411: Replace EXTRA_CXX_LDFLAGS with AM_LDFLAGS

2017-02-02 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1411 Replace EXTRA_CXX_LDFLAGS with AM_LDFLAGS We've never had different LDFLAGS for C and C++, so drop EXTRA_CC_LDFLAGS and EXTRA_CXX_LDFLAGS. Just use AM_LDFLAGS. You can merge this

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1397 I'm seeing the same thing on the CI machine [1]. Can you please share the output of `make V=1 cmd/traffic_top/traffic_top` with me? [1] https://ci.trafficserver.apache.org/job/G

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

2017-02-01 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1408 Prune some unused library dependencies and add a script to check for unused dependencies going forward. This PR depends on #1392 because otherwise the script fails -- traffic_server

[GitHub] trafficserver pull request #1405: TS-552: Trivial Autoconf cleanup

2017-02-01 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1405 TS-552: Trivial Autoconf cleanup We dropped exc_capture_context() and MLD_demangle_string() along with support for the Alpha architecture. You can merge this pull request into a Git

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1392 @zwoop I revised this: ```Diff print_feature("BUILD_PERSON", BUILD_PERSON, json); print_feature("BUILD_GROUP", BUILD_GROUP, json); print_f

[GitHub] trafficserver issue #1388: Fixes for building with OpenSSL 1.1

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1388 @zwoop I separated the commits because they each address a different issue -- #1384 and #1385. I think that makes the most sense ... but I'm happy to squash them if you prefer! --- If

[GitHub] trafficserver issue #1400: traffic_via depends on the PCRE library

2017-02-01 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1400 > I think we should backport this to 7.1.x too I agree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] trafficserver pull request #1400: traffic_via depends on the PCRE library

2017-02-01 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1400: traffic_via depends on the PCRE library

2017-01-31 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1400 traffic_via depends on the PCRE library You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver ldadd Alternatively you

[GitHub] trafficserver issue #1398: Configure option to disable CURL

2017-01-31 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1398 Oh, and I guess it still requires curses, so maybe leave in `AM_CONDITIONAL([BUILD_TRAFFIC_TOP], [test "x$ax_cv_curses" = xyes])`? --- If your project is set up for it, you can rep

[GitHub] trafficserver issue #1398: Configure option to disable CURL

2017-01-31 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1398 > Linux build failed! Try with AC_DEFINE vs. AM_CONDITIONAL: ```M4Sugar AX_LIB_CURL([7.19], [AC_DEFINE([HAS_CURL], [1], [Define if libcurl >= 7.19.])]) ```

[GitHub] trafficserver pull request #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-01-31 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1397 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-01-31 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1397 > it seems the checks for hwloc are not done well How can I reproduce this? I'm not seeing traffic_top getting hwloc: ``` $ ldd -r -u cmd/traffic_top/.libs/tra

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-01-30 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1397 > Wonder if we should bother back porting these to 7.1.x ? Wdyt ? It's probably safe. How serious is the problem it's fixing? What's the downside of linking with unn

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

2017-01-30 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1392 Would this latest change work? How does traffic_layout --features get used? ```Diff print_feature("BUILD_PERSON", BUILD_PERSON, json); print_feature(&q

[GitHub] trafficserver pull request #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-01-30 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1397 TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB AC_SEARCH_LIBS always adds -llibrary to LIBS, but AC_CHECK_LIB doesn't check that the function isn't already available -- in whic

[GitHub] trafficserver pull request #1393: Trivial Autoconf cleanup

2017-01-30 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1393: Trivial Autoconf cleanup

2017-01-30 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1393 Thanks for reviewing this @zwoop! I'm going to land it and see about fixing the issue you spotted in a separate PR. --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver issue #1386: ATS hangs, possibly because of OpenSSL 1.1.0

2017-01-30 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1389: SSL_CTX_remove_session() and external cach...

2017-01-30 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1393: Trivial Autoconf cleanup

2017-01-29 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1393 Trivial Autoconf cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver cleanup Alternatively you can review and

[GitHub] trafficserver pull request #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are a...

2017-01-29 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1392 TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always false Since replacing TS_FLAG_HEADERS, zlibh and lzmah are always false. Just use HAVE_ZLIB_H and HAVE_LZMA_H directly. You can merge this

[GitHub] trafficserver pull request #1389: SSL_CTX_remove_session() and external cach...

2017-01-28 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1389 SSL_CTX_remove_session() and external cache The remove session callback is triggered when a session is removed, so at best, calling SSL_CTX_remove_session() again is redundant. In

[GitHub] trafficserver pull request #1388: Fixes for building with OpenSSL 1.1

2017-01-28 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1388 Fixes for building with OpenSSL 1.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver openssl Alternatively you can

[GitHub] trafficserver pull request #1313: Use Autoconf checks vs. OPENSSL_VERSION_NU...

2017-01-27 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1313 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1382: TS-993: OpenBSD sbindir should be ${exec_prefix}/...

2017-01-26 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1382 Thanks @zwoop! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1382: TS-993: OpenBSD sbindir should be ${exec_p...

2017-01-26 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1382: TS-993: OpenBSD sbindir should be ${exec_p...

2017-01-26 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1382 TS-993: OpenBSD sbindir should be ${exec_prefix}/sbin You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver sbindir

[GitHub] trafficserver issue #1359: Flaw in TS-2157 means that port in server address...

2017-01-26 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1359 Fixed in #1364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1359: Flaw in TS-2157 means that port in server address...

2017-01-26 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

2017-01-25 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1378 > Also, please remember to add Milestone, Label's etc. on each Issue / PR, otherwise @bryancall gets all pissy. :) Will do! :-) > Why are there 4 commits on th

[GitHub] trafficserver issue #1377: TS-5107: init_customizations() isn't new in Docut...

2017-01-25 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1377 @jsime Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request #1378: 7.1.x TS-5107: Changes to autolinking in D...

2017-01-25 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1378 7.1.x TS-5107: Changes to autolinking in Docutils 0.13 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver 7.1.x

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-25 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1303 @zwoop Sure thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1377: TS-5107: init_customizations() isn't new i...

2017-01-25 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1377 TS-5107: init_customizations() isn't new in Docutils 0.13 We can use it in 0.12 and 0.13. @jsime Thanks for merging #1303. Sorry for the mistake! If you approve, can you p

[GitHub] trafficserver pull request #1342: Fix CID 1368305: Dereference before null c...

2017-01-24 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1342: Fix CID 1368305: Dereference before null c...

2017-01-24 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1342#discussion_r97648817 --- Diff: plugins/experimental/money_trace/money_trace.cc --- @@ -120,17 +120,13 @@ mt_check_request_header(TSHttpTxn txnp) if (!hdr_value

[GitHub] trafficserver pull request #1342: Fix CID 1368305: Dereference before null c...

2017-01-24 Thread jablko
Github user jablko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1342#discussion_r97640188 --- Diff: plugins/experimental/money_trace/money_trace.cc --- @@ -120,17 +120,13 @@ mt_check_request_header(TSHttpTxn txnp) if (!hdr_value

[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()

2017-01-24 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1328 I agree with @bgaff. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #1355: TS-4716: OpenBSD mandir should be ${prefix}/man

2017-01-24 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1355 > I'm marking this for 7.1.0, since it's mostly benign, and generally useful. Sounds good, thanks! Merged. > Update: I think I see, it's merely a cleanup

[GitHub] trafficserver pull request #1355: TS-4716: OpenBSD mandir should be ${prefix...

2017-01-24 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1353: [openbsd] wrong mandir for OpenBSD layout

2017-01-24 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1309: Fixes for building with LibreSSL

2017-01-24 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1309 Thanks @bryancall! Merged. Yeah, until this PR landed, it was also part of #1313 (is there a way around that?) so I guess applying both would conflict. Git is smart enough to match

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-24 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1307: [openbsd] build fails while building SSLUtils.cc

2017-01-24 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1371: Calling setrlimit() twice is redundant

2017-01-24 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1371 Calling setrlimit() twice is redundant Set .rlim_cur to either .rlim_max or RLIM_INFINITY. Doing both is redundant. This is a follow-up to #1362. The first commit belongs to that

[GitHub] trafficserver issue #1362: If setrlimit() fails, log the details

2017-01-24 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1362 Come to think of it, why do we setrlimit() to .rlim_max and RLIM_INFINITY in the same call? That seems redundant. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1362: If setrlimit() fails, log the details

2017-01-23 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1362 If setrlimit() fails, log the details I guess this is the same error as TS-882 [1] and TS-3074 [2]. The relevant commits are 8d7bb47419b25e50a5c50b53e54ce6dc5b342ef4 and

[GitHub] trafficserver pull request #1355: TS-4716: OpenBSD mandir should be ${prefix...

2017-01-23 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1355 TS-4716: OpenBSD mandir should be ${prefix}/man Fixes #1353 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver layout

[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()

2017-01-23 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1328 Thanks @bgaff and @jirib! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1328: Replace gethostbyname_r() with getaddrinfo...

2017-01-23 Thread jablko
Github user jablko closed the pull request at: https://github.com/apache/trafficserver/pull/1328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1312: [openbsd] build fails as openbsd doesn't have get...

2017-01-23 Thread jablko
Github user jablko closed the issue at: https://github.com/apache/trafficserver/issues/1312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1309: Fixes for building with LibreSSL

2017-01-23 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1309 @bryancall Thanks for reviewing this! I'd like to land both (this and #1313). I think this is ready to go? If you approve, I'll merge it. #1313 depends on this PR,

[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...

2017-01-18 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1291 On second thought, I don't know the proper way to fix this. @zwoop Do you have any suggestions? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...

2017-01-18 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1291 I think if the first argument -- buf -- is nullptr, print() should always return 1 [1]? I'll take a stab at fixing this. [1] https://github.com/apache/trafficserver

[GitHub] trafficserver pull request #1342: Fix CID 1368305: Dereference before null c...

2017-01-18 Thread jablko
GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/1342 Fix CID 1368305: Dereference before null check #1302 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver cid1368305

[GitHub] trafficserver issue #1302: CID 1368306 & 1368305: NULLPTR and security BP in...

2017-01-18 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/issues/1302 I think CID 1368306 is a false positive? The open() file_arguments[i] isn't the same as the access() file_arguments[i] because there's a ++i in between. I'm not sure

[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()

2017-01-17 Thread jablko
Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1328 @bgaff Thanks! I messaged @jirib to see if building Traffic Server works for him now. This is the last of the four issues he reported, but yeah, I suspect there'll be more once his build

  1   2   >