[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1197 Pretty sure I see other places where TCL hash is used, no? So this would just make things worse, we'd get both TCL hash and STL hashes :-/. --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1197 Is this the only place where we use TCL hash now? If so, it seems we could shoe horn something else here other than STL? --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1115: RFC: Build with non-recursive make.

2016-10-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1115 Besides the failures ( ;-) ) I think this is something we should do. It's a fairly simple change (hopefully), retains the modularity (by retaining the Makefile.inc's and then include them

[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...

2016-10-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1125 I see. The first portion of this patch is important, whereas the second portion is done (better?) in #1079. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Just a heads up, but this PR is against 6.2.x branch, the code has diverged, so will need one PR for 6.2.x and one for master. @gtenev Please make a PR for master at your earliest convenience

[GitHub] trafficserver pull request #1101: TS-4959: Remove remnants of old UA configu...

2016-10-12 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1101 TS-4959: Remove remnants of old UA configurations and handling I made this as two commits: 1) Remove some definitely strange code around MSIE. 2) Remove all the code around

[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-23 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1133 TS-4993: Disables escaping and quotes inside regexes In addition, this cleans up the unit tests a bit, to make it more useful from the command line when testing/debugging. New tests

[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.

2016-10-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1134 Hmmm, are we sure this makes sense? The CPP APIs aren't plugins, and we certainly don't put the TS API's into plugins. I could perhaps see this go into proxy somewhere. --- If your project

[GitHub] trafficserver issue #1114: TS-4976: Remove useless casts from plugins.

2016-10-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1114 Clang format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1109 Is this a duplicate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1078: TS-4930: Unfolds request headers that are ...

2016-10-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1116: TS-4979: Fix clang-analyzer complaint abou...

2016-10-18 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1116#discussion_r83893797 --- Diff: proxy/http/HttpTransact.cc --- @@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s) if (!request.is_target_in_url

[GitHub] trafficserver pull request #1117: TS-4916 Add safety net to avoid H2-infinit...

2016-10-18 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1117#discussion_r83908521 --- Diff: proxy/http2/Http2Stream.cc --- @@ -675,6 +675,17 @@ Http2Stream::destroy() } chunked_handler.clear(); super::destroy

[GitHub] trafficserver issue #1117: TS-4916 Add safety net to avoid H2-infinite-loop ...

2016-10-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1117 Sigh, it failed again on the bison generated files :-/. [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1133: TS-4993: Disables escaping and quotes inside rege...

2016-10-24 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1133 Randall and I ran into another issue with this patch, so doing some more debugging :-/. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup

2016-10-20 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1128 @jsime Can you review please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1129: TS-4992: Do not build the static libraries

2016-10-20 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1129 TS-4992: Do not build the static libraries You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4992 Alternatively you

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84770458 --- Diff: plugins/header_rewrite/header_rewrite_test.cc --- @@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = "TEST_dbg_header_rewrite";

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84770538 --- Diff: plugins/header_rewrite/parser.cc --- @@ -133,14 +152,15 @@ Parser::preprocess(std::vector tokens) std::string s = tokens[0].substr

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84729282 --- Diff: plugins/header_rewrite/header_rewrite_test.cc --- @@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = "TEST_dbg_header_rewrite";

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84723539 --- Diff: plugins/header_rewrite/header_rewrite_test.cc --- @@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = "TEST_dbg_header_rewrite";

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84770706 --- Diff: plugins/header_rewrite/parser.cc --- @@ -133,14 +152,15 @@ Parser::preprocess(std::vector tokens) std::string s = tokens[0].substr

[GitHub] trafficserver pull request #1117: TS-4916 Add safety net to avoid H2-infinit...

2016-10-19 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...

2016-10-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1125 Looking back, it seems this is basically handled (but better) with #1079 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...

2016-11-24 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1227 Hmmm, logging most metrics seems somewhat useless. What would be useful would be to have generic access to the underlying data that is used to update the metrics for that transactions

[GitHub] trafficserver pull request #1234: TS-5063: Fixes coverity warnings and clean...

2016-11-27 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1234: TS-5063: Fixes coverity warnings and cleans up th...

2016-11-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1234 I think this will clear the clang analyzer errors too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1235: HostDB memory fixes

2016-11-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1235 Which Jira is this for ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1234: TS-5063: Fixes coverity warnings and clean...

2016-11-23 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1234 TS-5063: Fixes coverity warnings and cleans up the temp string The Vec seems overkill here, and makes things less nice when managing the intermediary strings. The new code has issues

[GitHub] trafficserver issue #1229: TS-5061 TS use ats_malloc instead of malloc in lo...

2016-11-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1229 This needs to be updated with clang-format. Easiest is to just run $ make clang-format and then push the branch again to update the PR. --- If your project is set up

[GitHub] trafficserver pull request #1234: TS-5063: Fixes coverity warnings and clean...

2016-11-23 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1234#discussion_r89405035 --- Diff: mgmt/LocalManager.cc --- @@ -950,29 +949,27 @@ LocalManager::startProxy(const char *onetime_options) if (open_ports_p

[GitHub] trafficserver issue #1225: Create a tool to list files changed since a tag

2016-11-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1225 Can we put this into tools/reports ? There's one other similar tool in there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1184: TS-5030: Add API to get the unique client request...

2016-11-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 I'm still not convinced this is a particularly useful API, but it's also fairly benign. However, I do feel that if we are going to do this, we should make the prototype something like

[GitHub] trafficserver issue #1218: TS-5050: The background_fetch plugin fails to che...

2016-11-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1218 Please add Milestones, Labels etc... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1154: TS-5011: Fixes memory leak in CLFUS compre...

2016-11-01 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...

2016-11-01 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1166 TS-5024: Limits the gzip to 200 OK responses You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5024 Alternatively

[GitHub] trafficserver pull request #1167: TS-5025: Add 'setHost' method to 'atscppap...

2016-11-01 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1167#discussion_r85967946 --- Diff: lib/cppapi/Request.cc --- @@ -177,6 +177,23 @@ Request::getHeaders() const return state_->headers_; } +void +Requ

[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...

2016-11-01 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1166#discussion_r85968661 --- Diff: plugins/gzip/gzip.cc --- @@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configur

[GitHub] trafficserver issue #1171: TS-4957: Make the use of madvise() with MADV_DONT...

2016-11-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1171 EventSystem.o ../../../iocore/eventsystem/EventSystem.cc:38:7: error: unused variable 'iobuffer_advice' [-Werror,-Wunused-variable] int iobuffer_advice = 0

[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...

2016-11-01 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1164: TS-3939: Add a --enable-asan configure option

2016-10-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1164 Looks good to me. A future improvement would be that --enable-asan disables the freelist. It's today pretty obnoxious to run with ASAN, since you have to tell traffic_manager to pass along

[GitHub] trafficserver pull request #1164: TS-3939: Add a --enable-asan configure opt...

2016-10-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1164#discussion_r85624763 --- Diff: configure.ac --- @@ -188,6 +188,14 @@ AC_ARG_ENABLE([werror], ) AC_MSG_RESULT([$enable_werror]) +# Enable ASAN

[GitHub] trafficserver issue #958: TS-4449 Better errors and debug output

2016-10-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/958 Meh, lets not do this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #958: TS-4449 Better errors and debug output

2016-10-28 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/958 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1185: TS-5031: Use readdir() instead of readdir_...

2016-11-03 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1185 TS-5031: Use readdir() instead of readdir_r() See http://lwn.net/Articles/696474/. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop

[GitHub] trafficserver pull request #1185: TS-5031: Use readdir() instead of readdir_...

2016-11-03 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1193: TS-5037: Fix LogFormat object leak.

2016-11-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1193 How does this leak? If the constructor of LogObject fails? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975

2016-10-26 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1140#discussion_r85228363 --- Diff: proxy/http/HttpSM.cc --- @@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c) // only external

[GitHub] trafficserver pull request #1146: TS-5005: CID 1364117: Explicit null derefe...

2016-10-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1148: Make master work on OmniOS.

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1148 Does this need to go into 7.0.0 as well? @bryancall --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request #1146: TS-5005: CID 1364117: Explicit null derefe...

2016-10-26 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1146 TS-5005: CID 1364117: Explicit null dereferenced in HttpSM.cc Probably benign, since the vc shouldn't be NULL, but coverity is ruling with an iron fist. You can merge this pull request

[GitHub] trafficserver issue #1140: Fix CID 1356975

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1140 This needs a Jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1154: TS-5011: Fixes memory leak in CLFUS compression

2016-10-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1154 @SolidWallOfCode I agree, file a lira :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1152: TS-5009 CID 1022011 Logically dead code removal

2016-10-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1152 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...

2016-10-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1089 Maybe you have to rebase this from master, to get the clang-format fixes that were done yesterday. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1090: TS-4949: Disables the fuzzy revalidation l...

2016-10-11 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1090 TS-4949: Disables the fuzzy revalidation logic by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4949

[GitHub] trafficserver issue #1090: TS-4949: Disables the fuzzy revalidation logic by...

2016-10-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1090 I'll leave this sitting for another day or so, we had already (in April I think) marked these as deprecated for 6.2.0, and no one objected then either. --- If your project is set up

[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...

2016-10-11 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1097#discussion_r82917530 --- Diff: mgmt/RecordsConfig.cc --- @@ -1449,6 +1449,8 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver issue #1088: TS-4915: Crash from hostdb in PriorityQueueLess

2016-10-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1088 Clang-format ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request #1081: TS-3204: Crash when body_factory file is e...

2016-10-12 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1099: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1099 @gtenev This looks very strange, did you pull/rebase your tree first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1087: TS-4945: Remove unused member variable, ep...

2016-10-10 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1087 TS-4945: Remove unused member variable, epoll_vc CID 1364096 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4945

[GitHub] trafficserver issue #1101: TS-4959: Remove remnants of old UA configurations...

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1101 Rebuilding again, because I think the trees on the buildbots was busted [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1101: TS-4959: Remove remnants of old UA configu...

2016-10-12 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1090: TS-4949: Disables the fuzzy revalidation l...

2016-10-12 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1238: TS-4429: Adds a --terse (-e) option for lo...

2016-11-29 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1238 TS-4429: Adds a --terse (-e) option for logstats, excludes % metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver

[GitHub] trafficserver issue #1252: TS-5082: define IOBufferReader::is_read_avail_mor...

2016-12-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1252 Hmmm, it seems we are incredibly inconsistent here. Why singling out this one place for this change? Do we really need TS_INLINE in general? I notice we turn off inlining via #define in some

[GitHub] trafficserver pull request #1255: TS-5087: Updates the AL2 license on all .p...

2016-12-08 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1255 TS-5087: Updates the AL2 license on all .po files You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5087

[GitHub] trafficserver pull request #1256: TS-2109: Allows CC: no-cache objects to be...

2016-12-08 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1256 TS-2109: Allows CC: no-cache objects to be stored in cache However, we still honor the no-cache header, such that we perform an IMS request against the origin to validate the request

[GitHub] trafficserver pull request #1256: TS-2109: Allows CC: no-cache objects to be...

2016-12-09 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1259: TS-5095: IOBufferReader::read_avail adds to CPU u...

2016-12-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1259 Nice! Any details on what the impact / symptoms for this is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request #1261: TS-5096: Lua metrics crashes if the prefix...

2016-12-14 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1265: TS-5087: Updates the AL2 license on all .p...

2016-12-14 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1265 TS-5087: Updates the AL2 license on all .po files Cherry picks from master. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop

[GitHub] trafficserver pull request #1255: TS-5087: Updates the AL2 license on all .p...

2016-12-08 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1316: TS-5022: remove goto in SSLConfig : getnew...

2017-01-10 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1326: Core dump in SSLAccept / SSLNetVConnection::sslSe...

2017-01-13 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1326 Core dump in SSLAccept / SSLNetVConnection::sslServerHandShakeEvent We (@randall) ran into an odd crashes that seems fairly similar (but not identical) to https://issues.apache.org/jira/browse/TS

[GitHub] trafficserver issue #1325: #1323 Restores the NULL string where appropriate

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1325 Any takers on reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...

2017-01-13 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1325#discussion_r96107247 --- Diff: lib/records/RecUtils.cc --- @@ -419,7 +419,7 @@ RecDataSetFromString(RecDataT data_type, RecData *data_dst, const char *data_str

[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...

2017-01-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1323 I think this got broken with ced4da13279f834c381925f2ecd1649bfb459e8b. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

2017-01-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1324 Albeit reasonable, I don't think we should land this. There's a number of places from ced4da13279f834c381925f2ecd1649bfb459e8b which changes "NULL" to "nullptr" acciden

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1325 #1323 Restores the NULL string where appropriate You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver #1323 Alternatively

[GitHub] trafficserver pull request #1324: issue-1323: fix RecDataset

2017-01-13 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1319: 7.0.x TS-5059: Fixes for building with OpenSSL 1....

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1319 Mr (!) The Oil Rig, ( :-) ) did you check with @bryancall if he's planning a 7.0.1 release? if not, this is a moot point, 7.1.x will hopefully be released in 4 weeks. --- If your

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Marking this for 7.1.0, we really need this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1322: Possibly crasher in HostDB serialization (disk sy...

2017-01-12 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1322 Possibly crasher in HostDB serialization (disk sync) Hi Thomas, we're seeing this odd looking crash, fairly often: ``` #0 0x2d74337d in __libc_waitpid (pid

[GitHub] trafficserver issue #1322: Possibly crasher in HostDB serialization (disk sy...

2017-01-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1322 Pretty sure they had been running for a while (several days at least), but let me check. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1243: TS-5076: Test and set the in_enabled_list by atom...

2016-12-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1243 This might honestly be a back port candidate? Does this apply to 7.0.x as well as 6.2.x ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1243: TS-5076: Test and set the in_enabled_list by atom...

2016-12-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1243 5.3.x is end-of-lifed, we're not doing any more releases of that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1236: TS-5067 Fix required action for http2.enabled con...

2016-12-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1236 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1239: TS-5069 enhance logstats to report stats per user

2016-11-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1239 I landed my changes, so now you have to resolve the conflicts. Sorry bro. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1238: TS-4429: Adds a --concise (-C) option for ...

2016-11-30 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1241: TS-5060: Add support for DNAME record type.

2016-12-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1241 Seems two issues here: 1. clang-format 1. FreeBSD doesn't have a T_DNAME ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1237: Slowloris vulnerability

2016-12-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1237 I think think you can set a timeout (proxy.config.http.transaction_active_timeout_in) which doesn't care if data is being sent or not (it's a "hard" timeout on an active

[GitHub] trafficserver issue #1240: Doc conditional build

2016-11-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1240 How about this too: ``` diff --git a/ci/jenkins/bin/docs.sh b/ci/jenkins/bin/docs.sh index 6754040..f5b2a17 100644 --- a/ci/jenkins/bin/docs.sh +++ b/ci/jenkins/bin

[GitHub] trafficserver pull request #1240: Doc conditional build

2016-11-30 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1227: TS-5051 Add a new log tag % AppVersionInfo.B...

2016-12-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1227 @sekimura You want to take stab at adding this as Lua definitions? I assume the intent would be to expose some of these constants in an internal Lua table? --- If your project is set up

<    2   3   4   5   6   7   8   9   >