[
https://issues.apache.org/jira/browse/LUCENE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678045#action_12678045
]
Ning Li commented on LUCENE-1541:
-
An index size comparison will be great.
Trie range -
[
https://issues.apache.org/jira/browse/LUCENE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675390#action_12675390
]
Ning Li commented on LUCENE-1541:
-
When one precision step is given, it is converted to
Trie range - make trie range indexing more flexible
---
Key: LUCENE-1541
URL: https://issues.apache.org/jira/browse/LUCENE-1541
Project: Lucene - Java
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12673912#action_12673912
]
Ning Li commented on LUCENE-1470:
-
Good stuff!
Is it worth to also have an option to
[
https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674051#action_12674051
]
Ning Li commented on LUCENE-1470:
-
Hi Uwe,
I had something similar in mind when I said we
[
https://issues.apache.org/jira/browse/LUCENE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12628025#action_12628025
]
Ning Li commented on LUCENE-532:
Is the use of seek and write in ChecksumIndexOutput making
[
https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626158#action_12626158
]
Ning Li commented on LUCENE-1335:
-
Maybe this should be a separate JIRA issue. In
[
https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625455#action_12625455
]
Ning Li commented on LUCENE-1335:
-
I don't think so: with autoCommit=true, the merges
[
https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625078#action_12625078
]
Ning Li commented on LUCENE-1335:
-
It's because commit() calls prepareCommit(), which
[
https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624851#action_12624851
]
Ning Li commented on LUCENE-1335:
-
Hi Mike, could you update the patch? I cannot apply it.
[
https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624998#action_12624998
]
Ning Li commented on LUCENE-1335:
-
I agree that we should not make any API promises about
With non-deprecated constructors, IndexWriter's autoCommit is always true
-
Key: LUCENE-1338
URL: https://issues.apache.org/jira/browse/LUCENE-1338
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614404#action_12614404
]
Ning Li commented on LUCENE-1338:
-
Or is the intention to make autoCommit always false
[
https://issues.apache.org/jira/browse/LUCENE-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li resolved LUCENE-1338.
-
Resolution: Invalid
When deprecated constructors are removed in 3.0, autoCommit will always be
false.
[
https://issues.apache.org/jira/browse/LUCENE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578518#action_12578518
]
Ning Li commented on LUCENE-1228:
-
Does SegmentInfos really need both version and
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-1035:
Attachment: LUCENE-1035.contrib.patch
Re-do as a contrib package. Creating BufferPooledDirectory with
[
https://issues.apache.org/jira/browse/LUCENE-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12575782#action_12575782
]
Ning Li commented on LUCENE-1204:
-
I think this is a false alarm.
I just found out the
[
https://issues.apache.org/jira/browse/LUCENE-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572957#action_12572957
]
Ning Li commented on LUCENE-1194:
-
As of LUCENE-1044, when autoCommit=true, IndexWriter
[
https://issues.apache.org/jira/browse/LUCENE-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572576#action_12572576
]
Ning Li commented on LUCENE-1194:
-
Great to see deleteByQuery being added to IndexWriter!
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538638
]
Ning Li commented on LUCENE-1035:
-
The question is whether such situations are common enough to warrant adding
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537978
]
Ning Li commented on LUCENE-1035:
-
Were the tests run using the same set of queries they were warmed for?
Yes,
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538129
]
Ning Li commented on LUCENE-1035:
-
That seems like quite a few docs to retrieve--any particular reason why?
I was
ptional Buffer Pool to Improve Search Performance
-
Key: LUCENE-1035
URL: https://issues.apache.org/jira/browse/LUCENE-1035
Project: Lucene - Java
Issue Type: Improvement
Components:
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-1035:
Attachment: LUCENE-1035.patch
Coding Changes
--
New classes are localized to the store
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-1035:
Lucene Fields: [Patch Available] (was: [New])
ptional Buffer Pool to Improve Search Performance
[
https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-1035:
Summary: Optional Buffer Pool to Improve Search Performance (was: ptional
Buffer Pool to Improve Search
[
https://issues.apache.org/jira/browse/LUCENE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531513
]
Ning Li commented on LUCENE-1007:
-
One more thing about the approximation of actual bytes used for buffered delete
Flexibility to turn on/off any flush triggers
-
Key: LUCENE-1007
URL: https://issues.apache.org/jira/browse/LUCENE-1007
Project: Lucene - Java
Issue Type: Improvement
Components: Index
[
https://issues.apache.org/jira/browse/LUCENE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-1007:
Attachment: LUCENE-1007.patch
Just got around to do the patch:
- The patch includes changes to
[
https://issues.apache.org/jira/browse/LUCENE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-1007:
Attachment: LUCENE-1007.take2.patch
Take2 counts buffered delete terms towards ram buffer used. A test
[
https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527224
]
Ning Li commented on LUCENE-847:
Access of mergeThreads in ConcurrentMergeScheduler.merge() should be
synchronized.
[
https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527239
]
Ning Li commented on LUCENE-847:
Hmm, it's actually possible to have concurrent merges with SerialMergeScheduler.
[
https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527286
]
Ning Li commented on LUCENE-847:
This was actually intentional: I thought it fine if the application is
sending
[
https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526628
]
Ning Li commented on LUCENE-847:
OK, another rev of the patch (take6). I think it's close!
Yes, it's close! :)
[
https://issues.apache.org/jira/browse/LUCENE-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525271
]
Ning Li commented on LUCENE-992:
The patch looks good! A few comments and/or observations:
- addDocument(Document
Deprecate IndexModifier
---
Key: LUCENE-987
URL: https://issues.apache.org/jira/browse/LUCENE-987
Project: Lucene - Java
Issue Type: Test
Components: Index
Reporter: Ning Li
Priority:
[
https://issues.apache.org/jira/browse/LUCENE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-987:
---
Attachment: deprecateIndexModifier.patch
Deprecate IndexModifier
---
[
https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-978:
---
Lucene Fields: [Patch Available] (was: [New])
GC resources in TermInfosReader when exception occurs in its
[
https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520286
]
Ning Li commented on LUCENE-978:
Agreed. Actually, it also looks like we need to do something similar for
[
https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-978:
---
Attachment: Readers.patch
Similar fixes are added for FieldsReader and TermVectorsReader as well.
GC
[
https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-978:
---
Attachment: TermInfosReader.patch
GC resources in TermInfosReader when exception occurs in its constructor
GC resources in TermInfosReader when exception occurs in its constructor
Key: LUCENE-978
URL: https://issues.apache.org/jira/browse/LUCENE-978
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518520
]
Ning Li commented on LUCENE-847:
Furthermore, I think this is all contained within IndexWriter, right?
Ie when we
[
https://issues.apache.org/jira/browse/LUCENE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512271
]
Ning Li commented on LUCENE-938:
I didn't make myself clear. Let me try again. The patch includes two parts of
[
https://issues.apache.org/jira/browse/LUCENE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510422
]
Ning Li commented on LUCENE-938:
Good catch, Steven!
One thing though: I thought we had assumed that there wouldn't
[
https://issues.apache.org/jira/browse/LUCENE-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Li updated LUCENE-565:
---
Attachment: NewIndexModifier.Jan2007.patch
The patch is updated because of the code committed to IndexWriter
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: IndexWriter.java)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: IndexWriter.July09.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: IndexWriter.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: NewIndexModifier.July09.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: NewIndexWriter.Aug23.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: NewIndexWriter.July18.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: TestWriterDelete.java)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: KeepDocCount0Segment.Sept15.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: (was: newMergePolicy.Sept08.patch)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12459490 ]
Ning Li commented on LUCENE-565:
Many versions of the patch were submitted as new code was committed to
IndexWriter.java. For each version, all changes made were
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12459506 ]
Ning Li commented on LUCENE-565:
Here is the design overview. Minor changes were made because of lock-less
commits.
In the current IndexWriter, newly added
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12458158 ]
Ning Li commented on LUCENE-565:
Can the same thing happen with your patch (with a smaller window), or are
deletes applied between writing the new segment and
[
http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12457858 ]
Ning Li commented on LUCENE-702:
This is actually intentional: I don't want to write to the same
segments_N filename, ever, on the possibility that a reader may
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12457865 ]
Ning Li commented on LUCENE-565:
*or* you could choose to do it before a merge of the lowest level on-disk
segments. If none of the lowest level segments have
[
http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12457520 ]
Ning Li commented on LUCENE-702:
It looks good. My two cents:
1 In the two rollbacks in mergeSegments (where inTransaction is false), the
segmentInfos'
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12452039 ]
Ning Li commented on LUCENE-565:
With the recent commits to IndexWriter, this patch no longer applies cleanly.
The 5 votes for this issue encourages
me to submit
[
http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12448006 ]
Ning Li commented on LUCENE-702:
I think we should try to make all of the addIndexes calls (and more
generally any call to Lucene) transactional.
Agree. A
[
http://issues.apache.org/jira/browse/LUCENE-701?page=comments#action_12446638 ]
Ning Li commented on LUCENE-701:
Can the following scenario happen with lock-less commits?
1 A reader reads segments.1, which says the index contains seg_1.
2 A
[
http://issues.apache.org/jira/browse/LUCENE-701?page=comments#action_12446656 ]
Ning Li commented on LUCENE-701:
That wouldn't be considered a failure because it's part of the retry logic.
At that point, an attempt would be made to open
[
http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12446307 ]
Ning Li commented on LUCENE-702:
A possible solution to this issue is to check, when writing segment infos to
segments in directory d,
whether dir of a segment
[ http://issues.apache.org/jira/browse/LUCENE-528?page=all ]
Ning Li updated LUCENE-528:
---
Lucene Fields: [Patch Available]
Optimization for IndexWriter.addIndexes()
-
Key: LUCENE-528
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12444766 ]
Ning Li commented on LUCENE-686:
But removing TermDocs.close() will leave IndexInput.close() in a
similar half-in/half-out situation: e.g. close() will not be
[ http://issues.apache.org/jira/browse/LUCENE-528?page=all ]
Ning Li updated LUCENE-528:
---
Attachment: AddIndexesNoOptimize.patch
This patch implements addIndexesNoOptimize() following the algorithm described
earlier.
- The patch is based on the latest
[
http://issues.apache.org/jira/browse/LUCENE-528?page=comments#action_12443723 ]
Ning Li commented on LUCENE-528:
We want a robust algorithm for the version of addIndexes() which
does not call optimize().
The robustness can be expressed as the
[
http://issues.apache.org/jira/browse/LUCENE-528?page=comments#action_12443911 ]
Ning Li commented on LUCENE-528:
I think you need to ensure that no segments from the source index S remain
after the call, right?
Correct. And thanks!
So in
[
http://issues.apache.org/jira/browse/LUCENE-528?page=comments#action_12443978 ]
Ning Li commented on LUCENE-528:
I'll submit a patch next week.
Optimization for IndexWriter.addIndexes()
-
Resources not always reclaimed in scorers after each search
---
Key: LUCENE-686
URL: http://issues.apache.org/jira/browse/LUCENE-686
Project: Lucene - Java
Issue Type: Bug
[ http://issues.apache.org/jira/browse/LUCENE-686?page=all ]
Ning Li updated LUCENE-686:
---
Attachment: ScorerResourceGC.patch
A patch is attached:
- The patch is based on the lastest version from trunk.
- The patch includes a test called
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12442987 ]
Ning Li commented on LUCENE-686:
Is there an actual memory leak problem related to this?
Right now no. For example, in FS based directories, the index inputs
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: NewIndexModifier.Sept21.patch
This is to update the delete-support patch after the commit of the new merge
policy.
- Very few changes to IndexWriter.
-
[
http://issues.apache.org/jira/browse/LUCENE-672?page=comments#action_12435571 ]
Ning Li commented on LUCENE-672:
Should lowerBound start off as -1 in maybeMergeSegments if we keep 0 sized
segments?
Good catch! Although the rightmost disk
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: newMergePolicy.Sept08.patch
This patch features the new more robust merge policy. Reference on the new
policy is at
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: NewIndexWriter.Aug23.patch
Yes I am including this patch as it is very useful for increasing
the efficiency of updates as you described. I will be
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12430130 ]
Ning Li commented on LUCENE-565:
Doron, thank you very much for the review! I want to briefly comment
on one of your comments:
(5) deleteDocument(int doc) not
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: IndexWriter.July09.patch
NewIndexModifier.July09.patch
Hi Otis,
I've attached two patch files:
- IndexWriter.July09.patch is an updated
[
http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12419580 ]
Ning Li commented on LUCENE-565:
For an overview of my changes, I'll repeat some of what I said in
my earlier e-mail (see
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: IndexWriter.patch
Here is the diff file of IndexWriter.java.
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
-
Key: LUCENE-565
URL: http://issues.apache.org/jira/browse/LUCENE-565
Project: Lucene - Java
Type: Bug
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ]
Ning Li updated LUCENE-565:
---
Attachment: IndexWriter.java
TestWriterDelete.java
Supporting deleteDocuments in IndexWriter (Code and Performance Results
Provided)
85 matches
Mail list logo