[jira] Commented: (LUCENE-1541) Trie range - make trie range indexing more flexible

2009-03-02 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678045#action_12678045 ] Ning Li commented on LUCENE-1541: - An index size comparison will be great. Trie range -

[jira] Commented: (LUCENE-1541) Trie range - make trie range indexing more flexible

2009-02-20 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12675390#action_12675390 ] Ning Li commented on LUCENE-1541: - When one precision step is given, it is converted to

[jira] Created: (LUCENE-1541) Trie range - make trie range indexing more flexible

2009-02-17 Thread Ning Li (JIRA)
Trie range - make trie range indexing more flexible --- Key: LUCENE-1541 URL: https://issues.apache.org/jira/browse/LUCENE-1541 Project: Lucene - Java Issue Type: Improvement

[jira] Commented: (LUCENE-1470) Add TrieRangeFilter to contrib

2009-02-16 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12673912#action_12673912 ] Ning Li commented on LUCENE-1470: - Good stuff! Is it worth to also have an option to

[jira] Commented: (LUCENE-1470) Add TrieRangeFilter to contrib

2009-02-16 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674051#action_12674051 ] Ning Li commented on LUCENE-1470: - Hi Uwe, I had something similar in mind when I said we

[jira] Commented: (LUCENE-532) [PATCH] Indexing on Hadoop distributed file system

2008-09-03 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12628025#action_12628025 ] Ning Li commented on LUCENE-532: Is the use of seek and write in ChecksumIndexOutput making

[jira] Commented: (LUCENE-1335) Correctly handle concurrent calls to addIndexes, optimize, commit

2008-08-27 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626158#action_12626158 ] Ning Li commented on LUCENE-1335: - Maybe this should be a separate JIRA issue. In

[jira] Commented: (LUCENE-1335) Correctly handle concurrent calls to addIndexes, optimize, commit

2008-08-25 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625455#action_12625455 ] Ning Li commented on LUCENE-1335: - I don't think so: with autoCommit=true, the merges

[jira] Commented: (LUCENE-1335) Correctly handle concurrent calls to addIndexes, optimize, commit

2008-08-23 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12625078#action_12625078 ] Ning Li commented on LUCENE-1335: - It's because commit() calls prepareCommit(), which

[jira] Commented: (LUCENE-1335) Correctly handle concurrent calls to addIndexes, optimize, commit

2008-08-22 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624851#action_12624851 ] Ning Li commented on LUCENE-1335: - Hi Mike, could you update the patch? I cannot apply it.

[jira] Commented: (LUCENE-1335) Correctly handle concurrent calls to addIndexes, optimize, commit

2008-08-22 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12624998#action_12624998 ] Ning Li commented on LUCENE-1335: - I agree that we should not make any API promises about

[jira] Created: (LUCENE-1338) With non-deprecated constructors, IndexWriter's autoCommit is always true

2008-07-17 Thread Ning Li (JIRA)
With non-deprecated constructors, IndexWriter's autoCommit is always true - Key: LUCENE-1338 URL: https://issues.apache.org/jira/browse/LUCENE-1338 Project: Lucene - Java

[jira] Commented: (LUCENE-1338) With non-deprecated constructors, IndexWriter's autoCommit is always true

2008-07-17 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614404#action_12614404 ] Ning Li commented on LUCENE-1338: - Or is the intention to make autoCommit always false

[jira] Resolved: (LUCENE-1338) With non-deprecated constructors, IndexWriter's autoCommit is always true

2008-07-17 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li resolved LUCENE-1338. - Resolution: Invalid When deprecated constructors are removed in 3.0, autoCommit will always be false.

[jira] Commented: (LUCENE-1228) IndexWriter.commit() does not update the index version

2008-03-13 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578518#action_12578518 ] Ning Li commented on LUCENE-1228: - Does SegmentInfos really need both version and

[jira] Updated: (LUCENE-1035) Optional Buffer Pool to Improve Search Performance

2008-03-11 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-1035: Attachment: LUCENE-1035.contrib.patch Re-do as a contrib package. Creating BufferPooledDirectory with

[jira] Commented: (LUCENE-1204) IndexWriter.deleteDocuments bug

2008-03-06 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12575782#action_12575782 ] Ning Li commented on LUCENE-1204: - I think this is a false alarm. I just found out the

[jira] Commented: (LUCENE-1194) Add deleteByQuery to IndexWriter

2008-02-27 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572957#action_12572957 ] Ning Li commented on LUCENE-1194: - As of LUCENE-1044, when autoCommit=true, IndexWriter

[jira] Commented: (LUCENE-1194) Add deleteByQuery to IndexWriter

2008-02-26 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12572576#action_12572576 ] Ning Li commented on LUCENE-1194: - Great to see deleteByQuery being added to IndexWriter!

[jira] Commented: (LUCENE-1035) Optional Buffer Pool to Improve Search Performance

2007-10-29 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538638 ] Ning Li commented on LUCENE-1035: - The question is whether such situations are common enough to warrant adding

[jira] Commented: (LUCENE-1035) Optional Buffer Pool to Improve Search Performance

2007-10-26 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537978 ] Ning Li commented on LUCENE-1035: - Were the tests run using the same set of queries they were warmed for? Yes,

[jira] Commented: (LUCENE-1035) Optional Buffer Pool to Improve Search Performance

2007-10-26 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538129 ] Ning Li commented on LUCENE-1035: - That seems like quite a few docs to retrieve--any particular reason why? I was

[jira] Created: (LUCENE-1035) ptional Buffer Pool to Improve Search Performance

2007-10-25 Thread Ning Li (JIRA)
ptional Buffer Pool to Improve Search Performance - Key: LUCENE-1035 URL: https://issues.apache.org/jira/browse/LUCENE-1035 Project: Lucene - Java Issue Type: Improvement Components:

[jira] Updated: (LUCENE-1035) ptional Buffer Pool to Improve Search Performance

2007-10-25 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-1035: Attachment: LUCENE-1035.patch Coding Changes -- New classes are localized to the store

[jira] Updated: (LUCENE-1035) ptional Buffer Pool to Improve Search Performance

2007-10-25 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-1035: Lucene Fields: [Patch Available] (was: [New]) ptional Buffer Pool to Improve Search Performance

[jira] Updated: (LUCENE-1035) Optional Buffer Pool to Improve Search Performance

2007-10-25 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-1035: Summary: Optional Buffer Pool to Improve Search Performance (was: ptional Buffer Pool to Improve Search

[jira] Commented: (LUCENE-1007) Flexibility to turn on/off any flush triggers

2007-10-01 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531513 ] Ning Li commented on LUCENE-1007: - One more thing about the approximation of actual bytes used for buffered delete

[jira] Created: (LUCENE-1007) Flexibility to turn on/off any flush triggers

2007-09-27 Thread Ning Li (JIRA)
Flexibility to turn on/off any flush triggers - Key: LUCENE-1007 URL: https://issues.apache.org/jira/browse/LUCENE-1007 Project: Lucene - Java Issue Type: Improvement Components: Index

[jira] Updated: (LUCENE-1007) Flexibility to turn on/off any flush triggers

2007-09-27 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-1007: Attachment: LUCENE-1007.patch Just got around to do the patch: - The patch includes changes to

[jira] Updated: (LUCENE-1007) Flexibility to turn on/off any flush triggers

2007-09-27 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-1007: Attachment: LUCENE-1007.take2.patch Take2 counts buffered delete terms towards ram buffer used. A test

[jira] Commented: (LUCENE-847) Factor merge policy out of IndexWriter

2007-09-13 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527224 ] Ning Li commented on LUCENE-847: Access of mergeThreads in ConcurrentMergeScheduler.merge() should be synchronized.

[jira] Commented: (LUCENE-847) Factor merge policy out of IndexWriter

2007-09-13 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527239 ] Ning Li commented on LUCENE-847: Hmm, it's actually possible to have concurrent merges with SerialMergeScheduler.

[jira] Commented: (LUCENE-847) Factor merge policy out of IndexWriter

2007-09-13 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527286 ] Ning Li commented on LUCENE-847: This was actually intentional: I thought it fine if the application is sending

[jira] Commented: (LUCENE-847) Factor merge policy out of IndexWriter

2007-09-11 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526628 ] Ning Li commented on LUCENE-847: OK, another rev of the patch (take6). I think it's close! Yes, it's close! :)

[jira] Commented: (LUCENE-992) IndexWriter.updateDocument is no longer atomic

2007-09-05 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525271 ] Ning Li commented on LUCENE-992: The patch looks good! A few comments and/or observations: - addDocument(Document

[jira] Created: (LUCENE-987) Deprecate IndexModifier

2007-08-22 Thread Ning Li (JIRA)
Deprecate IndexModifier --- Key: LUCENE-987 URL: https://issues.apache.org/jira/browse/LUCENE-987 Project: Lucene - Java Issue Type: Test Components: Index Reporter: Ning Li Priority:

[jira] Updated: (LUCENE-987) Deprecate IndexModifier

2007-08-22 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-987: --- Attachment: deprecateIndexModifier.patch Deprecate IndexModifier ---

[jira] Updated: (LUCENE-978) GC resources in TermInfosReader when exception occurs in its constructor

2007-08-16 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-978: --- Lucene Fields: [Patch Available] (was: [New]) GC resources in TermInfosReader when exception occurs in its

[jira] Commented: (LUCENE-978) GC resources in TermInfosReader when exception occurs in its constructor

2007-08-16 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520286 ] Ning Li commented on LUCENE-978: Agreed. Actually, it also looks like we need to do something similar for

[jira] Updated: (LUCENE-978) GC resources in TermInfosReader when exception occurs in its constructor

2007-08-16 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-978: --- Attachment: Readers.patch Similar fixes are added for FieldsReader and TermVectorsReader as well. GC

[jira] Updated: (LUCENE-978) GC resources in TermInfosReader when exception occurs in its constructor

2007-08-15 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-978: --- Attachment: TermInfosReader.patch GC resources in TermInfosReader when exception occurs in its constructor

[jira] Created: (LUCENE-978) GC resources in TermInfosReader when exception occurs in its constructor

2007-08-15 Thread Ning Li (JIRA)
GC resources in TermInfosReader when exception occurs in its constructor Key: LUCENE-978 URL: https://issues.apache.org/jira/browse/LUCENE-978 Project: Lucene - Java

[jira] Commented: (LUCENE-847) Factor merge policy out of IndexWriter

2007-08-08 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518520 ] Ning Li commented on LUCENE-847: Furthermore, I think this is all contained within IndexWriter, right? Ie when we

[jira] Commented: (LUCENE-938) I/O exceptions can cause loss of buffered deletes

2007-07-12 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512271 ] Ning Li commented on LUCENE-938: I didn't make myself clear. Let me try again. The patch includes two parts of

[jira] Commented: (LUCENE-938) I/O exceptions can cause loss of buffered deletes

2007-07-05 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510422 ] Ning Li commented on LUCENE-938: Good catch, Steven! One thing though: I thought we had assumed that there wouldn't

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2007-01-25 Thread Ning Li (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Li updated LUCENE-565: --- Attachment: NewIndexModifier.Jan2007.patch The patch is updated because of the code committed to IndexWriter

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: IndexWriter.java) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: IndexWriter.July09.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: IndexWriter.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: NewIndexModifier.July09.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: NewIndexWriter.Aug23.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: NewIndexWriter.July18.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: TestWriterDelete.java) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: KeepDocCount0Segment.Sept15.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: (was: newMergePolicy.Sept08.patch) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12459490 ] Ning Li commented on LUCENE-565: Many versions of the patch were submitted as new code was committed to IndexWriter.java. For each version, all changes made were

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12459506 ] Ning Li commented on LUCENE-565: Here is the design overview. Minor changes were made because of lock-less commits. In the current IndexWriter, newly added

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-13 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12458158 ] Ning Li commented on LUCENE-565: Can the same thing happen with your patch (with a smaller window), or are deletes applied between writing the new segment and

[jira] Commented: (LUCENE-702) Disk full during addIndexes(Directory[]) can corrupt index

2006-12-12 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12457858 ] Ning Li commented on LUCENE-702: This is actually intentional: I don't want to write to the same segments_N filename, ever, on the possibility that a reader may

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-12-12 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12457865 ] Ning Li commented on LUCENE-565: *or* you could choose to do it before a merge of the lowest level on-disk segments. If none of the lowest level segments have

[jira] Commented: (LUCENE-702) Disk full during addIndexes(Directory[]) can corrupt index

2006-12-11 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12457520 ] Ning Li commented on LUCENE-702: It looks good. My two cents: 1 In the two rollbacks in mergeSegments (where inTransaction is false), the segmentInfos'

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-11-22 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12452039 ] Ning Li commented on LUCENE-565: With the recent commits to IndexWriter, this patch no longer applies cleanly. The 5 votes for this issue encourages me to submit

[jira] Commented: (LUCENE-702) Disk full during addIndexes(Directory[]) can corrupt index

2006-11-07 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12448006 ] Ning Li commented on LUCENE-702: I think we should try to make all of the addIndexes calls (and more generally any call to Lucene) transactional. Agree. A

[jira] Commented: (LUCENE-701) Lock-less commits

2006-11-02 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-701?page=comments#action_12446638 ] Ning Li commented on LUCENE-701: Can the following scenario happen with lock-less commits? 1 A reader reads segments.1, which says the index contains seg_1. 2 A

[jira] Commented: (LUCENE-701) Lock-less commits

2006-11-02 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-701?page=comments#action_12446656 ] Ning Li commented on LUCENE-701: That wouldn't be considered a failure because it's part of the retry logic. At that point, an attempt would be made to open

[jira] Commented: (LUCENE-702) Disk full during addIndexes(Directory[]) can corrupt index

2006-11-01 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-702?page=comments#action_12446307 ] Ning Li commented on LUCENE-702: A possible solution to this issue is to check, when writing segment infos to segments in directory d, whether dir of a segment

[jira] Updated: (LUCENE-528) Optimization for IndexWriter.addIndexes()

2006-10-26 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-528?page=all ] Ning Li updated LUCENE-528: --- Lucene Fields: [Patch Available] Optimization for IndexWriter.addIndexes() - Key: LUCENE-528

[jira] Commented: (LUCENE-686) Resources not always reclaimed in scorers after each search

2006-10-25 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12444766 ] Ning Li commented on LUCENE-686: But removing TermDocs.close() will leave IndexInput.close() in a similar half-in/half-out situation: e.g. close() will not be

[jira] Updated: (LUCENE-528) Optimization for IndexWriter.addIndexes()

2006-10-24 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-528?page=all ] Ning Li updated LUCENE-528: --- Attachment: AddIndexesNoOptimize.patch This patch implements addIndexesNoOptimize() following the algorithm described earlier. - The patch is based on the latest

[jira] Commented: (LUCENE-528) Optimization for IndexWriter.addIndexes()

2006-10-20 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-528?page=comments#action_12443723 ] Ning Li commented on LUCENE-528: We want a robust algorithm for the version of addIndexes() which does not call optimize(). The robustness can be expressed as the

[jira] Commented: (LUCENE-528) Optimization for IndexWriter.addIndexes()

2006-10-20 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-528?page=comments#action_12443911 ] Ning Li commented on LUCENE-528: I think you need to ensure that no segments from the source index S remain after the call, right? Correct. And thanks! So in

[jira] Commented: (LUCENE-528) Optimization for IndexWriter.addIndexes()

2006-10-20 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-528?page=comments#action_12443978 ] Ning Li commented on LUCENE-528: I'll submit a patch next week. Optimization for IndexWriter.addIndexes() -

[jira] Created: (LUCENE-686) Resources not always reclaimed in scorers after each search

2006-10-17 Thread Ning Li (JIRA)
Resources not always reclaimed in scorers after each search --- Key: LUCENE-686 URL: http://issues.apache.org/jira/browse/LUCENE-686 Project: Lucene - Java Issue Type: Bug

[jira] Updated: (LUCENE-686) Resources not always reclaimed in scorers after each search

2006-10-17 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-686?page=all ] Ning Li updated LUCENE-686: --- Attachment: ScorerResourceGC.patch A patch is attached: - The patch is based on the lastest version from trunk. - The patch includes a test called

[jira] Commented: (LUCENE-686) Resources not always reclaimed in scorers after each search

2006-10-17 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12442987 ] Ning Li commented on LUCENE-686: Is there an actual memory leak problem related to this? Right now no. For example, in FS based directories, the index inputs

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-09-21 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: NewIndexModifier.Sept21.patch This is to update the delete-support patch after the commit of the new merge policy. - Very few changes to IndexWriter. -

[jira] Commented: (LUCENE-672) new merge policy

2006-09-18 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-672?page=comments#action_12435571 ] Ning Li commented on LUCENE-672: Should lowerBound start off as -1 in maybeMergeSegments if we keep 0 sized segments? Good catch! Although the rightmost disk

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-09-08 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: newMergePolicy.Sept08.patch This patch features the new more robust merge policy. Reference on the new policy is at

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-08-24 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: NewIndexWriter.Aug23.patch Yes I am including this patch as it is very useful for increasing the efficiency of updates as you described. I will be

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-08-24 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12430130 ] Ning Li commented on LUCENE-565: Doron, thank you very much for the review! I want to briefly comment on one of your comments: (5) deleteDocument(int doc) not

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-09 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: IndexWriter.July09.patch NewIndexModifier.July09.patch Hi Otis, I've attached two patch files: - IndexWriter.July09.patch is an updated

[jira] Commented: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-07-06 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=comments#action_12419580 ] Ning Li commented on LUCENE-565: For an overview of my changes, I'll repeat some of what I said in my earlier e-mail (see

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-05-09 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: IndexWriter.patch Here is the diff file of IndexWriter.java. Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

[jira] Created: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-05-08 Thread Ning Li (JIRA)
Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided) - Key: LUCENE-565 URL: http://issues.apache.org/jira/browse/LUCENE-565 Project: Lucene - Java Type: Bug

[jira] Updated: (LUCENE-565) Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)

2006-05-08 Thread Ning Li (JIRA)
[ http://issues.apache.org/jira/browse/LUCENE-565?page=all ] Ning Li updated LUCENE-565: --- Attachment: IndexWriter.java TestWriterDelete.java Supporting deleteDocuments in IndexWriter (Code and Performance Results Provided)