[
https://issues.apache.org/jira/browse/LUCENE-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719435#action_12719435
]
Adrian Hempel commented on LUCENE-1474:
---
Hi Michael,
The index that Erik was workin
There is the wrong name in the pom.xml.template for contrib/remote
Here is a diff with a patch:
Index: contrib/remote/pom.xml.template
===
--- contrib/remote/pom.xml.template (revision 784550)
+++ contrib/remote/pom.xml.template
An index copied over another index can result in corruption
---
Key: LUCENE-1691
URL: https://issues.apache.org/jira/browse/LUCENE-1691
Project: Lucene - Java
Issue Type: Improvement
Thanks, Simon!
I just committed the fix.
Michael
On 6/15/09 12:20 AM, Simon Willnauer wrote:
There is the wrong name in the pom.xml.template for contrib/remote
Here is a diff with a patch:
Index: contrib/remote/pom.xml.template
Hi Mike,
after adding a new contrib, I think we should also add this to the site docs
and also the javadocs generation in the main build.xml.
Should I prepare this? I have done this for spatial and trie in the past,
too.
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.th
On Mon, Jun 15, 2009 at 3:41 AM, Uwe Schindler wrote:
> Hi Mike,
>
> after adding a new contrib, I think we should also add this to the site docs
> and also the javadocs generation in the main build.xml.
Woops, you're right.
> Should I prepare this? I have done this for spatial and trie in the pa
[
https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719491#action_12719491
]
Michael McCandless commented on LUCENE-1677:
bq. I think test-core is broken t
[
https://issues.apache.org/jira/browse/LUCENE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719504#action_12719504
]
Shai Erera commented on LUCENE-1677:
You're right. I updated build.xml, but the change
FYI, Simon, you are still a contrib committer ;-)
On Jun 15, 2009, at 3:20 AM, Simon Willnauer wrote:
There is the wrong name in the pom.xml.template for contrib/remote
Here is a diff with a patch:
Index: contrib/remote/pom.xml.template
Uh! I didn't know that I can commit to all contribs
Good to know but I have been inactive for a while so I want use my
power with care!
simon
On Mon, Jun 15, 2009 at 12:34 PM, Grant Ingersoll wrote:
> FYI, Simon, you are still a contrib committer ;-)
>
>
> On Jun 15, 2009, at 3:20 AM, Simon
[
https://issues.apache.org/jira/browse/LUCENE-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719512#action_12719512
]
Michael McCandless commented on LUCENE-1474:
OK that's good news: the bug is f
[
https://issues.apache.org/jira/browse/LUCENE-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719513#action_12719513
]
Michael McCandless commented on LUCENE-1691:
Copying over an existing index, w
[
https://issues.apache.org/jira/browse/LUCENE-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719520#action_12719520
]
Adrian Hempel commented on LUCENE-1691:
---
I realised that would probably be the case,
Adrian Hempel (JIRA) wrote:
[ https://issues.apache.org/jira/browse/LUCENE-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719520#action_12719520 ]
Adrian Hempel commented on LUCENE-1691:
---
I realised that
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719535#action_12719535
]
Shai Erera commented on LUCENE-1630:
Ok I was just about to post the patch, when the S
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719539#action_12719539
]
Earwin Burrfoot commented on LUCENE-1630:
-
I like the last option most. Creating d
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719539#action_12719539
]
Earwin Burrfoot edited comment on LUCENE-1630 at 6/15/09 5:36 AM:
--
Committed into general site docs (developer-resources) and into trunk's docs
(large patch, because navigation changed).
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: [email protected]
> -Original Message-
> From: Michael McCandless [mailto:luc...@mi
Thanks, uwe!
simon
On Mon, Jun 15, 2009 at 2:45 PM, wrote:
> Author: uschindler
> Date: Mon Jun 15 12:45:05 2009
> New Revision: 784758
>
> URL: http://svn.apache.org/viewvc?rev=784758&view=rev
> Log:
> LUCENE-1407: move RemoteSearchable out of core into contrib/remote (add
> javadocs to develo
[
https://issues.apache.org/jira/browse/LUCENE-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Hempel updated LUCENE-1691:
--
Fix Version/s: (was: 2.4.1)
Affects Version/s: 2.4.1
> An index copied over anothe
[
https://issues.apache.org/jira/browse/LUCENE-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-1688:
Attachment: StopWords.patch
Attached a patch that marks the ENGLISH_STOP_WORDS as deprecat
[
https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719555#action_12719555
]
Mark Miller commented on LUCENE-1595:
-
Okay, how about something like this:
we docume
[
https://issues.apache.org/jira/browse/LUCENE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719558#action_12719558
]
Mark Miller commented on LUCENE-1518:
-
This issue is marked as part of LUCENE-1345, wh
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719560#action_12719560
]
Mark Miller commented on LUCENE-1606:
-
This is a cool issue, but it hasn't found an as
[
https://issues.apache.org/jira/browse/LUCENE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719561#action_12719561
]
Mark Miller commented on LUCENE-1313:
-
Whats the verdict on this one Mike? Got the imp
[
https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719565#action_12719565
]
Mark Miller commented on LUCENE-1595:
-
bq. Does this make sense?
Okay, sounds good.
[
https://issues.apache.org/jira/browse/LUCENE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719567#action_12719567
]
Uwe Schindler commented on LUCENE-1518:
---
Push to 3.1! -- Uwe
> Merge Query and Filt
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-1606:
-
Assignee: Uwe Schindler
> Automaton Query/Filter (scalable regex)
>
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719570#action_12719570
]
Uwe Schindler commented on LUCENE-1606:
---
I take it, I think it is almost finished. T
[
https://issues.apache.org/jira/browse/LUCENE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1518:
Fix Version/s: (was: 2.9)
3.1
> Merge Query and Filter classes
> --
[
https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719563#action_12719563
]
Shai Erera commented on LUCENE-1595:
ok I agree. I've already documented CHANGES. I'll
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719571#action_12719571
]
Mark Miller commented on LUCENE-1606:
-
I don't think there is a problem with BSD. I kn
[
https://issues.apache.org/jira/browse/LUCENE-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1595:
---
Attachment: LUCENE-1595.patch
Patch adds a checkObsoleteSettings to PerfTask to alert on the use of
[
https://issues.apache.org/jira/browse/LUCENE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1313:
---
Fix Version/s: (was: 2.9)
3.1
OK let's push it to 3.1. It's
Super, thanks Uwe!
Mike
On Mon, Jun 15, 2009 at 8:46 AM, Uwe Schindler wrote:
> Committed into general site docs (developer-resources) and into trunk's docs
> (large patch, because navigation changed).
>
> -
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMa
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719602#action_12719602
]
Uwe Schindler commented on LUCENE-1606:
---
Robert: I applied the patch locally, one te
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719605#action_12719605
]
Robert Muir commented on LUCENE-1606:
-
Uwe, you are correct, I just took a glance at t
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719606#action_12719606
]
Uwe Schindler commented on LUCENE-1606:
---
Doesn't seem to work, I will check the sour
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719607#action_12719607
]
Uwe Schindler commented on LUCENE-1606:
---
So I tend to move this to 3.0 or 3.1, becau
By the way:
I compiled core and corresponding tests with an old JDK 1.4 version, I found
locally on my machine. Works fine!
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: [email protected]
> -Original Message-
> From: Uwe Schindler (JIRA) [mailt
:)
But those days are numbered!
Mike
On Mon, Jun 15, 2009 at 11:55 AM, Uwe Schindler wrote:
> By the way:
> I compiled core and corresponding tests with an old JDK 1.4 version, I found
> locally on my machine. Works fine!
>
> Uwe
>
> -
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
>
It would help if we have a target date, then I'll know how many more X's I
need to mark on the Calendar :)
On Mon, Jun 15, 2009 at 6:56 PM, Michael McCandless <
[email protected]> wrote:
> :)
>
> But those days are numbered!
>
> Mike
>
> On Mon, Jun 15, 2009 at 11:55 AM, Uwe Schindler wro
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719612#action_12719612
]
Robert Muir commented on LUCENE-1606:
-
Uwe, sorry about this.
I did just verify autom
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1606:
--
Fix Version/s: (was: 2.9)
3.0
I move this to 3.0 (and not 3.1), because
[
https://issues.apache.org/jira/browse/LUCENE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719619#action_12719619
]
Mark Miller commented on LUCENE-1599:
-
Something is modifying the original query itsel
[
https://issues.apache.org/jira/browse/LUCENE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reassigned LUCENE-1599:
---
Assignee: Mark Miller
> SpanRegexQuery and SpanNearQuery is not working with MultiSearcher
>
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719623#action_12719623
]
Robert Muir commented on LUCENE-1606:
-
Uwe, ok.
Not to try to complicate things, but
Why do you hate 1.6 Uwe?
Mike
On Mon, Jun 15, 2009 at 12:10 PM, Uwe Schindler (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Uwe Schindler updated LUCENE-1606:
> --
I thought the primary goal of switching to AttributeSource (yes, the
name is very generic...) was to allow extensibility to what's created
per-Token, so that an app could add their own attrs without costly
subclassing/casting per Token, independent of other other "things"
adding their tokens, etc.
[
https://issues.apache.org/jira/browse/LUCENE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reassigned LUCENE-1650:
---
Assignee: Mark Miller
> Small fix in CustomScoreQuery JavaDoc
>
[
https://issues.apache.org/jira/browse/LUCENE-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reassigned LUCENE-1583:
---
Assignee: Mark Miller
I guess I'll do this one.
You out there reading Paul Elschot? This lo
[
https://issues.apache.org/jira/browse/LUCENE-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719630#action_12719630
]
Mark Miller commented on LUCENE-1688:
-
If no one else claims this for 2.9, I guess I'l
[
https://issues.apache.org/jira/browse/LUCENE-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719635#action_12719635
]
Mark Miller commented on LUCENE-973:
You guys looking for this for 2.9?
If so, any vol
On Jun 15, 2009, at 12:19 PM, Michael McCandless wrote:
I don't think anything was "held back" in this effort. Grant, are you
referring to LUCENE-1458? That's "held back" simply because the only
person working on it (me) got distracted by other things to work on.
I'm sorry, I didn't mean to
[
https://issues.apache.org/jira/browse/LUCENE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-1630:
---
Attachment: LUCENE-1630.patch
ok - let's start iterating on the patch. Anyone volunteer to accept it
[
https://issues.apache.org/jira/browse/LUCENE-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719639#action_12719639
]
Mark Miller commented on LUCENE-1486:
-
Should this go in contrib rather than core? Tha
[
https://issues.apache.org/jira/browse/LUCENE-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1486:
Attachment: LUCENE-1486.patch
Reformatted to lucene formatting, removed author tag, removed a coup
[
https://issues.apache.org/jira/browse/LUCENE-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719653#action_12719653
]
Richard Marr commented on LUCENE-1690:
--
Sounds reasonable although that'll take a lit
On Jun 14, 2009, at 8:05 PM, Michael Busch wrote:
I'm not sure why this (currently having to implement next() too) is
such an issue for you. You brought it up at the Lucene meetup too.
No user will ever have to implement both (the new API and the old)
in their streams/filters. The only reas
The high-level description of the new API looks good (being able to
add arbitrary properties to tokens), unfortunately, I've never had the
time to try and use it and give any constructive feedback.
As far as difficulty of use, I assume this only applies to
implementing your own TokenFilter? It see
Yonik Seeley wrote:
The high-level description of the new API looks good (being able to
add arbitrary properties to tokens), unfortunately, I've never had the
time to try and use it and give any constructive feedback.
As far as difficulty of use, I assume this only applies to
implementing your o
>
> As Lucene's contrib hasn't been fully converted either (and its been quite
> some time now), someone has probably heard that groan before.
hope this doesn't sound like a complaint, but in my opinion this is
because many do not have any tests.
I converted a few of these and its just grunt work
Contrib analyzers need tests
Key: LUCENE-1692
URL: https://issues.apache.org/jira/browse/LUCENE-1692
Project: Lucene - Java
Issue Type: Test
Components: contrib/analyzers
Reporter: Robert Mu
[
https://issues.apache.org/jira/browse/LUCENE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Rutherglen updated LUCENE-1313:
-
Summary: Near Realtime Search (was: Realtime Search)
> Near Realtime Search
> -
[
https://issues.apache.org/jira/browse/LUCENE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719665#action_12719665
]
Jason Rutherglen commented on LUCENE-1313:
--
Just wanted to give an update on this
On Jun 14, 2009, at 8:05 PM, Michael Busch wrote:
I'd be happy to discuss other API proposals that anybody brings up
here, that have the same advantages and are more intuitive. We could
also beef up the documentation and give a better example about how
to convert a stream/filter from the
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1673:
--
Attachment: LUCENE-1673.patch
Updated patch:
- now with extended JavaDocs
- additional tests f
Robert Muir wrote:
As Lucene's contrib hasn't been fully converted either (and its been quite
some time now), someone has probably heard that groan before.
hope this doesn't sound like a complaint,
Complaints are fine in any case. Every now and then, it might cause a
little rant from me o
Mark, I created an issue for this.
I just think you know, converting an analyzer to the new api is really
not that bad.
reverse engineering what one of them does is not necessarily obvious,
and is completely unrelated but necessary if they are to be migrated.
I'd be willing to assist with some o
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719689#action_12719689
]
Michael McCandless commented on LUCENE-1673:
bq. So one using new code must al
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719692#action_12719692
]
Michael McCandless commented on LUCENE-1673:
bq. The only open point is the na
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719699#action_12719699
]
Yonik Seeley commented on LUCENE-1673:
--
bq. This will apply to int/long/float/double
Robert Muir wrote:
Mark, I created an issue for this.
Thanks Robert, great idea.
I just think you know, converting an analyzer to the new api is really
not that bad.
I don't either. I'm really just complaining about the initial
readability. Once you know whats up, its not too much differ
> Also, what about the case where one might have attributes that are meant
> for downstream TokenFilters, but not necessarily for indexing? Offsets
> and type come to mind. Is it the case now that those attributes are not
> automatically added to the index? If they are ignored now, what if I
On Mon, Jun 15, 2009 at 3:00 PM, Uwe Schindler wrote:
> There is a new Attribute called ShiftAttribute (or NumericShiftAttribute),
> when trie range is moved to core. This attribute contains the shifted-away
> bits from the prefix encoded value during trie indexing.
I was wondering about this
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719726#action_12719726
]
Uwe Schindler commented on LUCENE-1673:
---
{quote}
bq. This will apply to int/long/flo
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719729#action_12719729
]
Uwe Schindler commented on LUCENE-1673:
---
bq. Did you think about / decide against ma
> On Mon, Jun 15, 2009 at 3:00 PM, Uwe Schindler wrote:
> > There is a new Attribute called ShiftAttribute (or
> NumericShiftAttribute),
> > when trie range is moved to core. This attribute contains the shifted-
> away
> > bits from the prefix encoded value during trie indexing.
>
> I was wonderin
> If you understood that, you'd be able to look
> at the actual token value if you were interested in what shift was
> used. So it's redundant, has a runtime cost, it's not currently used
> anywhere, and it's not useful to fields other than Trie. Perhaps it
> shouldn't exist (yet)?
You are right
Mark, I'll see if I can get tests produced for some of those analyzers.
as a new user of the new api myself, I think I can safely say the most
confusing thing about it is having the old deprecated API mixed in the
javadocs with it :)
On Mon, Jun 15, 2009 at 2:53 PM, Mark Miller wrote:
> Robert Mu
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719738#action_12719738
]
Uwe Schindler commented on LUCENE-1673:
---
I think, I remove the ShiftAttribute in com
let me try some slightly more constructive feedback:
new user looks at TokenStream javadocs:
http://hudson.zones.apache.org/hudson/job/Lucene-trunk/javadoc/org/apache/lucene/analysis/TokenStream.html
immediately they see deprecated, text in red with the words
"experimental", warnings in bold, the
> there's also a stray bold tag gone haywire somewhere, possibly
> .incrementToken()
I fixed this. This was going me on my nerves the whole day when I wrote
javadocs for NumericTokenStream...
Uwe
-
To unsubscribe, e-mail: java-
Some great points - especially the decision between a deprecated API,
and a new experimental one subject to change. Bit of a rock and a hard
place for a new user.
Perhaps we should add a little note with some guidance.
- Mark
Robert Muir wrote:
let me try some slightly more constructive fee
This is excellent feedback, Robert!
I agree this is confusing; especially having a deprecated API and only a
experimental one that replaces the old one. We need to change that.
And I don't like the *useNewAPI*() methods either. I spent a lot of time
thinking about backwards compatibility for th
By the way, there is an empty "de" subdir in SVN inside analysis. Can this
be removed?
And, in tests: test/o/a/l/index/store is somehow wrong placed. The class
inside should be in test/o/a/l/store. Should I move?
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMai
> And I don't like the *useNewAPI*() methods either. I spent a lot of time
> thinking about backwards compatibility for this API. It's tricky to do
> without sacrificing performance. In API patches I find myself spending
> more time for backwards-compatibility than for the actual new feature! :(
Michael, again I am terrible with such things myself...
Personally I am impressed that you have the back compat, even if you
don't change any code at all I think some reformatting of javadocs
might make the situation a lot friendlier. I just listed everything
that came to my mind immediately.
I g
[
https://issues.apache.org/jira/browse/LUCENE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719761#action_12719761
]
Michael McCandless commented on LUCENE-1673:
OK let's open a new issue for how
I have implemented most of that actually (the interface part and Token
implementing all of them).
The problem is a paradigm change with the new API: the assumption is
that there is always only one single instance of an Attribute. With the
old API, it is recommended to reuse the passed-in token
On Mon, Jun 15, 2009 at 4:21 PM, Uwe Schindler wrote:
> And, in tests: test/o/a/l/index/store is somehow wrong placed. The class
> inside should be in test/o/a/l/store. Should I move?
Please do!
Mike
-
To unsubscribe, e-mail: j
I agree. It's my fault, the task of changing the contribs (LUCENE-1460)
is assigned to me for a while now - I just haven't found the time to do
it yet.
It's great that you started the work on that! I'll try to review the
patch in the next couple of days and help with fixing the remaining
ones
Michael McCandless (JIRA) wrote:
We're forking off new 2.9 issues left and
right here!!
Evil :) You guys are like small team working against me.
We still have 29+- issue to wrap up though, so probably plenty of time.
I hope we can set a rough target date soon though - it really feels like
Michael OK, I plan on adding some tests for the analyzers that don't have any.
I didn't try to migrate things such as highlighter, which are
definitely just as important, only because I'm not familiar with that
territory.
But I think I can figure out what the various language analyzers are
trying
Maybe change the deprecation wrapper around next() and next(Token) [the
default impl of incrementToken()] to check, if the retrieved token is not
identical to the attribute and then just copy the contents to the
instance-Token? This would be a slowdown, but only be the case for very rare
TokenStrea
[
https://issues.apache.org/jira/browse/LUCENE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719766#action_12719766
]
Michael McCandless commented on LUCENE-1541:
Uwe, what's the plan on this issu
On Mon, Jun 15, 2009 at 4:42 PM, Mark Miller wrote:
> Remember the last time we started to push for 2.9 in Dec/Jan :)
Yes this is very much on my mind too!!
So maybe, it's a race between the trie* "group" of issues, and the other 28 ;)
Mike
-
[
https://issues.apache.org/jira/browse/LUCENE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719767#action_12719767
]
Jason Rutherglen commented on LUCENE-1313:
--
TestThreadedOptimize is throwing a en
[
https://issues.apache.org/jira/browse/LUCENE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719769#action_12719769
]
Uwe Schindler commented on LUCENE-1541:
---
I see no real use in it, it does not affect
Sorry,
I think these new issues may also be in 3.1 (not all), but I want to have
this trie stuff with a clean API before 2.9 and not deprecate parts of it
again in 3.1, shortly after release :-(
This issues are no hard changes, its just a little bit API cleanup you can
do in your freetime :-] --
1 - 100 of 130 matches
Mail list logo
