Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Naoto Sato
On Tue, 30 Jul 2024 22:52:24 GMT, Justin Lu wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties >> line 283: >> >>> 281: doclet.record_equals_doc.fullbody.tail.both=参照コンポーネントは{@link >>> java.util.Objects#equals(Object,Object) >>> Object

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Naoto Sato
On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen wrote: > Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties line 281

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Justin Lu
On Tue, 30 Jul 2024 22:45:03 GMT, Naoto Sato wrote: >> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties > l

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Naoto Sato
On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen wrote: > Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties line 283

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Justin Lu
On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen wrote: > Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ LGTM src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties line 96: > 94

[jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Damon Nguyen
Localization update for JDK23 RDP2 Please view for enhanced diffs on affected files: https://cr.openjdk.org/~dnguyen/output/ - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/20394/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20394&range=00

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v6]

2024-07-30 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-30 Thread Jonathan Gibbons
On Tue, 30 Jul 2024 18:02:32 GMT, Jonathan Gibbons wrote: >> I'll look to upgrade these. In the original impl of DocLint, it was >> something of a conscious decision to avoid supporting input elements. >> >> I'm surprised LINK is phrasing content: I thought it could only appear in >> HEAD elem

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-30 Thread Jonathan Gibbons
On Tue, 30 Jul 2024 17:50:43 GMT, Jonathan Gibbons wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/html/HtmlTag.java line 87: >> >>> 85: attrs(AttrKind.HTML4, CLEAR)), >>> 86: >>> 87: BUTTON(BlockType.OTHER, EndKind.REQUIRED, >> >> Several tag constants that use `B

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v5]

2024-07-30 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v4]

2024-07-30 Thread Jonathan Gibbons
On Fri, 26 Jul 2024 10:52:22 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Cleanup use of HtmlStyle and HtmlStyles > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/html/HtmlTag.jav