Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Damon Nguyen
On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen wrote: >> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc [v7]

2024-07-31 Thread Jonathan Gibbons
> Please review a change to reorganize the internal low-level support for HTML > in the jdk.javadoc module. > > Hitherto, there are two separate sets of classes for low-level support for > HTML in the `jdk.javadoc` module: one, in doclint, focused on reading and > checking classes, the other, i

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Justin Lu
On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen wrote: >> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Naoto Sato
On Wed, 31 Jul 2024 10:58:46 GMT, Damon Nguyen wrote: >> Cannot suggest the translation for the second line on GitHub (complaining >> "Applying suggestions on deleted lines is not supported."), but the same >> diff can be applied here > >> Cannot suggest the translation for the second line on G

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Naoto Sato
On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen wrote: >> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Pavel Rappo
On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen wrote: >> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Damon Nguyen
On Tue, 30 Jul 2024 23:03:40 GMT, Naoto Sato wrote: > Cannot suggest the translation for the second line on GitHub (complaining > "Applying suggestions on deleted lines is not supported."), but the same diff > can be applied here I think I handled the issue you mentioned here. I replaced line

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Damon Nguyen
> Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Update another translation - Changes:

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v2]

2024-07-31 Thread Damon Nguyen
On Tue, 30 Jul 2024 23:00:13 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update translation > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v2]

2024-07-31 Thread Damon Nguyen
> Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Update translation - Changes: - all: