Re: [jdk25] RFR: 8364089: JDK 25 RDP2 L10n resource files update [v2]

2025-07-30 Thread Naoto Sato
rg/jdk) repository. >> >> The commit being backported was authored by Alisen Chung on 30 Jul 2025 and >> was reviewed by Justin Lu, Naoto Sato, Damon Nguyen and Alexey Semenyuk. >> >> Thanks! > > Alisen Chung has updated the pull request incrementally with one

Re: RFR: 8364089: JDK 25 RDP2 L10n resource files update

2025-07-25 Thread Naoto Sato
On Fri, 25 Jul 2025 00:25:01 GMT, Alisen Chung wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/2646

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-26 Thread Naoto Sato
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-23 Thread Naoto Sato
On Mon, 23 Jun 2025 16:32:21 GMT, Alisen Chung wrote: >> I am wondering the same thing. Perhaps because it is not intended for >> general public, it's not in the [JDK tools >> specifications](https://docs.oracle.com/en/java/javase/24/docs/specs/man/index.html). >> If that was intentionally left

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Naoto Sato
On Wed, 18 Jun 2025 09:47:57 GMT, Joel Sikström wrote: > Should the other localizations for the launcher help text (in > `launcher_.properties`) also be updated? I see that only the German, > Japanese and Chinese localizations have been updated so far. Those languages (de/ja/zh-CN) are the one

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-17 Thread Naoto Sato
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8356977: UTF-8 cleanups [v3]

2025-06-03 Thread Naoto Sato
On Tue, 3 Jun 2025 17:42:37 GMT, Magnus Ihse Bursie wrote: >> I found a few other places in the code that can be cleaned up after the >> conversion to UTF-8. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-27 Thread Naoto Sato
On Mon, 26 May 2025 07:44:30 GMT, Magnus Ihse Bursie wrote: >> test/jdk/sun/text/resources/LocaleDataTest.java line 106: >> >>> 104: *FormatData/fr_FR/MonthNames/0=janvier >>> 105: *FormatData/fr_FR/MonthNames/1=février >>> 106: *LocaleNames/fr_FR/US=États-Unis >> >>

Re: RFR: 8356977: UTF-8 cleanups

2025-05-15 Thread Naoto Sato
On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote: > I found a few other places in the code that can be cleaned up after the > conversion to UTF-8. test/jdk/sun/text/resources/LocaleDataTest.java line 106: > 104: *FormatData/fr_FR/MonthNames/0=janvier > 105: *FormatD

Re: [jdk24] RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-17 Thread Naoto Sato
> The commit being backported was authored by Justin Lu on 16 Dec 2024 and was > reviewed by Naoto Sato, Damon Nguyen, Joe Wang, Alexander Matveev, Severin > Gehwolf, Jan Lahoda, Pavel Rappo and Alexey Semenyuk. > > Thanks! Backport LGTM - Marked as reviewed by na

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v3]

2024-12-16 Thread Naoto Sato
On Mon, 16 Dec 2024 19:20:54 GMT, Justin Lu wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> corr

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-15 Thread Naoto Sato
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Naoto Sato
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-17 Thread Naoto Sato
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote: > Please review this PR which removes occurrences of 'applet' within the > corelibs specification. Applet has been deprecated since JDK9, and may be a > confusing term for new Java developers, so it should be removed from the > documentation.

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2024-08-20 Thread Naoto Sato
On Tue, 20 Aug 2024 09:07:54 GMT, Pavel Rappo wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace InputStreamReader with BufferedReader > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_pt_BR.propertie

Re: RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-08-02 Thread Naoto Sato
On Fri, 2 Aug 2024 18:20:40 GMT, Damon Nguyen wrote: > Forwardport for JDK-8337054 from JDK23 of RDP2 L10N, fix applied cleanly. > > Forward-porting to add translated files from JDK23 RDP2 into mainline and > prevent re-translating these files in the next L10N drop. Marked as reviewed by naoto

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Naoto Sato
On Wed, 31 Jul 2024 10:58:46 GMT, Damon Nguyen wrote: >> Cannot suggest the translation for the second line on GitHub (complaining >> "Applying suggestions on deleted lines is not supported."), but the same >> diff can be applied here > >> Cannot suggest the translation for the second line on G

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update [v3]

2024-07-31 Thread Naoto Sato
On Wed, 31 Jul 2024 11:02:06 GMT, Damon Nguyen wrote: >> Localization update for JDK23 RDP2 >> >> Please view for enhanced diffs on affected files: >> https://cr.openjdk.org/~dnguyen/output/ > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Naoto Sato
On Tue, 30 Jul 2024 22:52:24 GMT, Justin Lu wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties >> line 283: >> >>> 281: doclet.record_equals_doc.fullbody.tail.both=参照コンポーネントは{@link >>> java.util.Objects#equals(Object,Object) >>> Object

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Naoto Sato
On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen wrote: > Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties line 281

Re: [jdk23] RFR: 8337054: JDK 23 RDP2 L10n resource files update

2024-07-30 Thread Naoto Sato
On Tue, 30 Jul 2024 20:17:28 GMT, Damon Nguyen wrote: > Localization update for JDK23 RDP2 > > Please view for enhanced diffs on affected files: > https://cr.openjdk.org/~dnguyen/output/ src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties line 283

Re: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-13 Thread Naoto Sato
> > The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and > was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, > Chris Plummer, Alexey Semenyuk and Phil Race. > > Thanks! Marked as reviewed by naoto (Reviewer). - PR Re

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-11 Thread Naoto Sato
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert updated translation > > Did not look at each for translation accuracy (did some fo

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-11 Thread Naoto Sato
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote: >> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties >> line 278: >> >>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements >>> "{0}" verweist auf das nicht deklarierte El

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Naoto Sato
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote: > This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translati

Re: RFR: 8324571: JDK 22 RDP2 L10n resource files update

2024-01-24 Thread Naoto Sato
On Tue, 23 Jan 2024 22:49:04 GMT, Alisen Chung wrote: > l10n update for jdk22 rdp2 Good catch @hns This PR should not have been created against the mainline, but JDK22 stabilization repository (w/o mainline changes). Retracting the approval. - Changes requested by naoto (Reviewer)

Re: RFR: 8324571: JDK 22 RDP2 L10n resource files update

2024-01-23 Thread Naoto Sato
On Tue, 23 Jan 2024 22:49:04 GMT, Alisen Chung wrote: > l10n update for jdk22 rdp2 Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17542#pullrequestreview-1840103270

Re: [jdk22] RFR: 8322041: JDK 22 RDP1 L10n resource files update

2023-12-20 Thread Naoto Sato
On Wed, 20 Dec 2023 19:00:50 GMT, Alisen Chung wrote: > Backport of JDK-8322041 Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/22#pullrequestreview-1791633961

Re: RFR: 8322041: JDK 22 RDP1 L10n resource files update

2023-12-14 Thread Naoto Sato
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote: > Translation drop for JDK22 RDP1 src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties line 111: > 109: doclet.Factory=ファクトリ: > 110: doclet.UnknownTag=不明なタグ。未登録のカスタム・タグ? > 111: doclet.UnknownTag

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-09-13 Thread Naoto Sato
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: [jdk21] RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-08-02 Thread Naoto Sato
On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote: > Please review this PR (L10N translation update), which is a backport of > commit > [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >

Re: RFR: 8312572: JDK 21 RDP2 L10n resource files update

2023-07-27 Thread Naoto Sato
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote: > Please review this PR which contains the translations for updates to > localized resources in the JDK since RDP1. > > Included in this change are improved translations for certain values, which > also includes global updates for translations

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Naoto Sato
On Fri, 16 Jun 2023 04:39:42 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Naoto Sato
On Fri, 16 Jun 2023 15:06:30 GMT, Jonathan Gibbons wrote: >> Left some comments on the translations mainly in Japanese. It is now very >> easy to look at the l10n changes in the generated HTML. One small comment to >> the tool is that it would be nice if the order in HTML (alphabetically >> so

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v4]

2023-06-13 Thread Naoto Sato
On Tue, 13 Jun 2023 22:09:40 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Naoto Sato
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-13 Thread Naoto Sato
On Mon, 12 Jun 2023 22:32:14 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2023-05-11 Thread Naoto Sato
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]

2023-03-31 Thread Naoto Sato
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v4]

2023-03-17 Thread Naoto Sato
On Fri, 17 Mar 2023 20:31:27 GMT, Andy Goryachev wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjust CF test to read in with UTF-8 to fix failing test > > make/jdk/src/classes/build/tools/compileproperties/CompileP

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Naoto Sato
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]

2023-01-25 Thread Naoto Sato
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revisi

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v3]

2023-01-24 Thread Naoto Sato
On Tue, 24 Jan 2023 22:40:55 GMT, Justin Lu wrote: >> OK, I can make the manual edit for this > > This change was made because it was compared to the original > messages.properties. In that file, the respective line is given as > `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v2]

2023-01-24 Thread Naoto Sato
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revisi

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]

2022-12-16 Thread Naoto Sato
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes There is another translation drop scheduled

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well Marked as reviewed by naoto (Reviewer). src/jdk.jdeps

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix https and changed URL back Thanks for the update, Damon. Looks good for this d

Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]

2022-12-15 Thread Naoto Sato
On Thu, 15 Dec 2022 02:45:48 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Removed trailing whitespace Changes requested by naoto (Reviewer). src/jdk.compil

Re: RFR: 8296546: Add @spec tags to API [v4]

2022-12-01 Thread Naoto Sato
On Thu, 1 Dec 2022 19:37:28 GMT, Jonathan Gibbons wrote: >> src/java.base/share/classes/java/lang/Character.java line 172: >> >>> 170: * occur. For example, in a future release, synchronization may fail. >>> 171: * >>> 172: * @spec https://www.unicode.org/reports/tr27 Unicode 3.1.0 >> >> Thi

Re: RFR: 8296546: Add @spec tags to API

2022-11-10 Thread Naoto Sato
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Naoto Sato
On Tue, 25 Oct 2022 13:43:56 GMT, Weijun Wang wrote: > I wonder if this means even if we get everything right now the tool might add > trailing spaces again later. Good catch, Max. Yes, that should be dealt with in the translation process. > I suggest we focus on the English files this time an

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Naoto Sato
On Mon, 24 Oct 2022 20:08:02 GMT, Andy Goryachev wrote: > Good idea! I wonder if this should be done as a unit test. go through all the > bundles and check leading/trailing whitespace. Right. Definitely not a job for `jcheck`, but it should be considered somewhere in the l10n process. ---

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Naoto Sato
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files

2022-10-20 Thread Naoto Sato
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8289562: Change bugs.java.com and bugreport.java.com URL's to https

2022-08-16 Thread Naoto Sato
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote: > 8289562: Change bugs.java.com and bugreport.java.com URL's to https Those `.properties` bundle changes look good. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.org/jdk/pull/9445

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v4]

2022-08-01 Thread Naoto Sato
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added comments in CurrencyNames root in base, moved US CurrencyNames back > t

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v3]

2022-07-28 Thread Naoto Sato
On Tue, 26 Jul 2022 20:31:44 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed localized files from base - src/jdk.localedata/share/classes/sun/uti

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

2022-07-25 Thread Naoto Sato
On Sat, 23 Jul 2022 03:03:25 GMT, Alisen Chung wrote: > open l10n msg drop > All tests passed. Changes requested by naoto (Reviewer). src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties line 63: > 61: # written authorization of the copyright holder. > 62: > 63: ADP=ADP