Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

2024-06-05 Thread Hannes Wallnöfer
On Wed, 5 Jun 2024 11:04:06 GMT, Pavel Rappo wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review feedback > > test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java line 161: > >> 159:

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

2024-06-05 Thread Pavel Rappo
On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

2024-06-03 Thread Chen Liang
On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

2024-05-31 Thread Hannes Wallnöfer
On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

2024-05-31 Thread Hannes Wallnöfer
> Please review a simple patch to exclude preview visitor classes meant to > support future preview features from the Preview API page. > > The test adds an sample element annotated with the new > `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a > `@JEP` annotation) to m

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v3]

2024-05-30 Thread Chen Liang
On Thu, 23 May 2024 13:59:19 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v3]

2024-05-23 Thread Hannes Wallnöfer
On Thu, 23 May 2024 13:59:19 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v3]

2024-05-23 Thread Hannes Wallnöfer
> Please review a simple patch to exclude preview visitor classes meant to > support future preview features from the Preview API page. > > The test adds an sample element annotated with the new > `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a > `@JEP` annotation) to m

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v2]

2024-05-23 Thread Hannes Wallnöfer
> Please review a simple patch to exclude preview visitor classes meant to > support future preview features from the Preview API page. > > The test adds an sample element annotated with the new > `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a > `@JEP` annotation) to m

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature

2024-05-22 Thread Hannes Wallnöfer
On Wed, 22 May 2024 08:39:12 GMT, Hannes Wallnöfer wrote: > Please review a simple patch to exclude preview visitor classes meant to > support future preview features from the Preview API page. > > The test adds an sample element annotated with the new > `PreviewFeature.Feature.LANGUAGE_MODEL

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature

2024-05-22 Thread Hannes Wallnöfer
On Wed, 22 May 2024 11:26:02 GMT, Chen Liang wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_MODEL`

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature

2024-05-22 Thread Chen Liang
On Wed, 22 May 2024 08:39:12 GMT, Hannes Wallnöfer wrote: > Please review a simple patch to exclude preview visitor classes meant to > support future preview features from the Preview API page. > > The test adds an sample element annotated with the new > `PreviewFeature.Feature.LANGUAGE_MODEL

RFR: 8331947: Preview creates checkbox for JEP-less preview feature

2024-05-22 Thread Hannes Wallnöfer
Please review a simple patch to exclude preview visitor classes meant to support future preview features from the Preview API page. The test adds an sample element annotated with the new `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a `@JEP` annotation) to make sure it