RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2002-02-11 Thread marc fleury
remove the cache key altogether if you want marcf |-Original Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of Scott |M Stark |Sent: Thursday, February 07, 2002 11:50 PM |To: [EMAIL PROTECTED] |Subject: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2002-02-07 Thread Scott M Stark
User: starksm Date: 02/02/07 23:49:40 Modified:src/main/org/jboss/ejb Tag: Branch_2_4 CacheKey.java Log: Fix problem with cast in equals Revision ChangesPath No revision No revision 1.12.2.2 +157 -138

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2002-02-07 Thread Scott M Stark
User: starksm Date: 02/02/08 00:00:19 Modified:src/main/org/jboss/ejb CacheKey.java Log: Until CacheKey is dropped, have it use the bean key equals and hashCode methods if they are implemented by the bean key class. Revision ChangesPath 1.20 +56 -48

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2002-01-12 Thread Adrian Brock
User: ejort Date: 02/01/12 13:14:26 Modified:src/main/org/jboss/ejb CacheKey.java Log: Remove directory reference to log4j Category in preparation for log4j 1.2 Revision ChangesPath 1.19 +3 -3 jboss/src/main/org/jboss/ejb/CacheKey.java Index:

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-11-13 Thread marc fleury
User: mnf999 Date: 01/11/13 15:41:20 Modified:src/main/org/jboss/ejb CacheKey.java Log: The performance of the copy semantics is just too expensive, if we want to enforce the copy semantics in the future (commented out here) then we should put that in some cache class that can

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-11-13 Thread marc fleury
User: mnf999 Date: 01/11/13 17:19:40 Modified:src/main/org/jboss/ejb CacheKey.java Log: Warming up :) Revision ChangesPath 1.18 +7 -6 jboss/src/main/org/jboss/ejb/CacheKey.java Index: CacheKey.java

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-07-12 Thread Jason Dillon
User: user57 Date: 01/07/12 17:45:26 Modified:src/main/org/jboss/ejb CacheKey.java Log: o re-indent Revision ChangesPath 1.15 +113 -113 jboss/src/main/org/jboss/ejb/CacheKey.java Index: CacheKey.java

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-07-09 Thread Jason Dillon
User: user57 Date: 01/07/09 21:42:58 Modified:src/main/org/jboss/ejb CacheKey.java Log: o using log4j when initalization failes, this is not a field so it will not affect serialization... but it should probably be replaced by a nested runtime exception. Revision

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-14 Thread Micheal J
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of marc fleury Sent: 13 June 2001 22:26 To: [EMAIL PROTECTED] Subject: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] also add yourself as author

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-06-13 Thread patriot1burke
User: patriot1burke Date: 01/06/13 11:48:15 Modified:src/main/org/jboss/ejb CacheKey.java Log: made member variable immutable and protected Constructor now copies id, to avoid users that re-use instances of their primary keys. (Like we did) Revision Changes

RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-06-13 Thread marc fleury
| +// Make a copy just in case somebody re-uses the instance | +this.id = mo.get(); Bill that comment you just commited is absolutely obscure. Reuses the instance... what instance. Please say // Make a copy of the id to enforce copy semantics and allow reuse of the original

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-06-13 Thread patriot1burke
User: patriot1burke Date: 01/06/13 14:15:23 Modified:src/main/org/jboss/ejb CacheKey.java Log: comment change Revision ChangesPath 1.11 +3 -2 jboss/src/main/org/jboss/ejb/CacheKey.java Index: CacheKey.java

Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread marc fleury
Of |[EMAIL PROTECTED] |Sent: Wednesday, June 13, 2001 5:15 PM |To: [EMAIL PROTECTED] |Subject: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb |CacheKey.java | | | User: patriot1burke | Date: 01/06/13 14:15:23 | | Modified:src/main/org/jboss/ejb CacheKey.java | Log: | comment change

[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java

2001-06-13 Thread patriot1burke
User: patriot1burke Date: 01/06/13 14:51:15 Modified:src/main/org/jboss/ejb CacheKey.java Log: added myself as author... Revision ChangesPath 1.12 +4 -1 jboss/src/main/org/jboss/ejb/CacheKey.java Index: CacheKey.java

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Bill Burke
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of marc fleury Sent: Wednesday, June 13, 2001 5:26 PM To: [EMAIL PROTECTED] Subject: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] also add yourself

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Schaefer, Andreas
Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of |[EMAIL PROTECTED] |Sent: Wednesday, June 13, 2001 5:15 PM |To: [EMAIL PROTECTED] |Subject: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb |CacheKey.java | | | User: patriot1burke | Date: 01/06/13 14:15:23

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread marc fleury
|Hey, I wouldn't mind if you restricted commit access to CVS to only core |JBOSS team members as long as the core team religiously reviewed and |commited patch submittals. Although I do enjoy having rw access, |this would |keep some of the purity you're talking about. I wasn't clear and the

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Bill Burke
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Schaefer, Andreas Sent: Wednesday, June 13, 2001 6:25 PM To: '[EMAIL PROTECTED]' Subject: RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] Yes

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Schaefer, Andreas
Message- From: Bill Burke [mailto:[EMAIL PROTECTED]] Sent: Wednesday, June 13, 2001 3:42 PM To: [EMAIL PROTECTED] Subject: RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] -Original Message- From: [EMAIL PROTECTED] [mailto

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Bill Burke
-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] I am strongly in favor of javadoc/comments. beside that, we should select some coding standard and stick to it. Open source evolution demands it (as people do come go) but code has to stay forever (atleast we should wish that). I

RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread marc fleury
update: |jboss/src/main/org/jboss/ejb CacheKey.java] | | |Yes, we can include the cvs commit msg in the code but I'm not in favor of |it. At best it reproduces the comments that should be in the code |out of context. |In general it gives a higher level description of a change that |was made across

Re: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Andreas Schaefer
really simple Mad Andy - Original Message - From: marc fleury [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, June 13, 2001 6:30 PM Subject: RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] So we are back to putting the comments

Re: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java]

2001-06-13 Thread Scott M Stark
I'm fine with that. - Original Message - From: marc fleury [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, June 13, 2001 6:30 PM Subject: RE: Commit Messages was [RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java] So we are back to putting the comments