> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]]On Behalf Of marc
> fleury
> Sent: 13 June 2001 22:26
> To: [EMAIL PROTECTED]
> Subject: Commit Messages was [RE: [JBoss-dev] CVS update:
> jboss/src/main/org/jboss/ejb CacheKey.java]
>
>
> also add yourself as author.
>
> Finally guys, I believe that as the "purity" of the code drops down i.e.
> that it goes way beyond the original team (it is happening *right now*) I
> believe we should really enforce "the comments in the code". Yes I know
> that the logs are what are supposed to keep that but frankly I
> would rather
> see it all in one place, ie. at the top of the file to see who has done
> what, since it gets very confusing and you have to be online to get that
> information through cvs.
>
> I am open to that one, how do you guys feel? (do you feel strongly against
> it? I remember one of you feeling strongly) but frankly more than once I
> read code and I go, huh? where does that come from... that would be very
> useful.
I don't feel particularly strongly either way but, it seems that the info
you seek (who did what and when) is best left where it should be. In the CVS
history for the file and the commit comments.
As long as the developers can be encouraged/persuaded to
a) provide solid comments of what their code does inside the source files,
b) ensure that they document any "optimizations or hacks" explicitly with
reasons and,
c) optionally [and ideally] produce unit tests for the code they
add/change/understand,
then, there is no need for additional info in the source files IMO.
I understand the problem you have with CVS and access to history info while
offline and, perhaps because I rarely have a need for that info, I honestly
don't have a solution for it.
Given the rate at which such info is likely to grow on many files, I can
forsee problems with the naive approach of just having CVS add the info to
sourcefiles automatically. For some files, that info is already larger than
the real sourcecode + comments.
>
> Is there a way to have cvs include the commits messages automatically?
Yes.
Cheers!,
Micheal
>
> marcf
>
> |-----Original Message-----
> |From: [EMAIL PROTECTED]
> |[mailto:[EMAIL PROTECTED]]On Behalf Of
> |[EMAIL PROTECTED]
> |Sent: Wednesday, June 13, 2001 5:15 PM
> |To: [EMAIL PROTECTED]
> |Subject: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb
> |CacheKey.java
> |
> |
> | User: patriot1burke
> | Date: 01/06/13 14:15:23
> |
> | Modified: src/main/org/jboss/ejb CacheKey.java
> | Log:
> | comment change
> |
> | Revision Changes Path
> | 1.11 +3 -2 jboss/src/main/org/jboss/ejb/CacheKey.java
> |
> | Index: CacheKey.java
> | ===================================================================
> | RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/CacheKey.java,v
> | retrieving revision 1.10
> | retrieving revision 1.11
> | diff -u -r1.10 -r1.11
> | --- CacheKey.java 2001/06/13 18:48:15 1.10
> | +++ CacheKey.java 2001/06/13 21:15:23 1.11
> | @@ -21,7 +21,7 @@
> | *
> | * @see org.jboss.ejb.plugins.NoPassivationInstanceCache.java
> | * @author <a href="[EMAIL PROTECTED]">Marc Fleury</a>
> | -* @version $Revision: 1.10 $
> | +* @version $Revision: 1.11 $
> | */
> | public class CacheKey
> | implements java.io.Externalizable
> | @@ -68,7 +68,8 @@
> | try {
> | // Equals rely on the MarshalledObject itself
> | mo = new MarshalledObject(id);
> | - // Make a copy just in case somebody re-uses the instance
> | + // Make a copy of the id to enforce copy semantics and
> | + // allow reuse of the original primary key
> | this.id = mo.get();
> | // Precompute the hashCode (speed)
> | hashCode = mo.hashCode();
> |
> |
> |
> |
> |_______________________________________________
> |Jboss-development mailing list
> |[EMAIL PROTECTED]
> |http://lists.sourceforge.net/lists/listinfo/jboss-development
>
>
>
> _______________________________________________
> Jboss-development mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/jboss-development
>
_______________________________________________
Jboss-development mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/jboss-development
