Re: Need help testing the EA builds

2016-03-07 Thread Volker Simonis
On Mon, Mar 7, 2016 at 8:58 PM, Alan Bateman wrote: > > On 07/03/2016 18:23, Volker Simonis wrote: >> >> : >> >> So while the tools are not being refactored, how can we fix the build >> on non-SA platforms if moving the SA dependency to >> module-info.java.extra is no viable solution? I've tried y

Re: Initial webrev with changes for JDK 9

2016-03-07 Thread Mandy Chung
> On Mar 3, 2016, at 6:38 AM, Alan Bateman wrote: > > I've pushed webrevs with the initial changes for JDK 9 here: >http://cr.openjdk.java.net/~alanb/8142968/0/ I have reviewed changes for java.management and java.logging module. src/java.management/share/classes/sun/management/ThreadInfoC

Re: [9-jake] Review request: 8151320: Remove unnecessary addReads from JavaFX

2016-03-07 Thread Kevin Rushforth
Yes, I'll deal with all of the "FIXME" comments (and not just the ones you see in the webrev) separately. Thanks. -- Kevin Mandy Chung wrote: On Mar 5, 2016, at 3:31 PM, Kevin Rushforth wrote: Please review the following: https://bugs.openjdk.java.net/browse/JDK-8151320 http://cr.openjdk.

Re: [9-jake] Review request: 8151320: Remove unnecessary addReads from JavaFX

2016-03-07 Thread Mandy Chung
> On Mar 5, 2016, at 3:31 PM, Kevin Rushforth > wrote: > > Please review the following: > > https://bugs.openjdk.java.net/browse/JDK-8151320 > http://cr.openjdk.java.net/~kcr/8151320/webrev.00/ > > Now that addReads are no longer necessary in cases where we use core > reflection [1] we will

hg: jigsaw/jake/jdk: Minor test cleanup

2016-03-07 Thread mandy . chung
Changeset: 19a309a4477e Author:mchung Date: 2016-03-07 15:16 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/19a309a4477e Minor test cleanup ! test/jdk/jigsaw/etc/JdkModules.java

hg: jigsaw/jake/hotspot: Fix typo

2016-03-07 Thread mandy . chung
Changeset: ada509821490 Author:mchung Date: 2016-03-07 14:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ada509821490 Fix typo ! src/share/vm/prims/jvmti.xml

hg: jigsaw/jake/hotspot: Fix merge issue for JDK-8144996 and JDK-8067194

2016-03-07 Thread mandy . chung
Changeset: c7d5a9549f3b Author:mchung Date: 2016-03-07 13:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c7d5a9549f3b Fix merge issue for JDK-8144996 and JDK-8067194 - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegionSetCount.java

hg: jigsaw/jake/jdk: 4 new changesets

2016-03-07 Thread alan . bateman
Changeset: 077b8ac4a27a Author:alanb Date: 2016-03-07 12:29 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/077b8ac4a27a Clean-up to ModuleReader javadoc ! src/java.base/share/classes/java/lang/module/ModuleReader.java Changeset: 0ac544460a1a Author:sdrach Date:

hg: jigsaw/jake/jdk: Clarify spec for Class::forName

2016-03-07 Thread mandy . chung
Changeset: 0403537f7032 Author:mchung Date: 2016-03-07 13:22 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0403537f7032 Clarify spec for Class::forName ! src/java.base/share/classes/java/lang/Class.java

Re: Need help testing the EA builds

2016-03-07 Thread Alan Bateman
On 07/03/2016 18:23, Volker Simonis wrote: : So while the tools are not being refactored, how can we fix the build on non-SA platforms if moving the SA dependency to module-info.java.extra is no viable solution? I've tried your suggestion to add `-addmods ALL-SYSTEM` to the jcmd launchers. It s

Re: Need help testing the EA builds

2016-03-07 Thread Volker Simonis
Hi Alan, I think you're right. Although I'm not familiar with the module system at all, I can see the following: - default build with jdk.hotspot.agent dependency in module-info.java ./images/jdk/bin/jdeps -m jdk.jcmd module jdk.jcmd requires java.base requires jdk.attach requires jdk.hotspot

hg: jigsaw/jake/hotspot: JDK-8144730, make jdk.boot.class.path.append an internal system property and remove sun.boot.class.path support.

2016-03-07 Thread lois . foltan
Changeset: 7fc12c5280a2 Author:lfoltan Date: 2016-03-07 11:59 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/7fc12c5280a2 JDK-8144730, make jdk.boot.class.path.append an internal system property and remove sun.boot.class.path support. ! src/share/vm/classfile/classL

hg: jigsaw/jake/jdk: JDK-8144730, make jdk.boot.class.path.append and internal system property.

2016-03-07 Thread lois . foltan
Changeset: 22820da90ee1 Author:lfoltan Date: 2016-03-07 11:58 -0500 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/22820da90ee1 JDK-8144730, make jdk.boot.class.path.append and internal system property. ! src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java ! src/

hg: jigsaw/jake/nashorn: adding missing @modules declaration for 3 jtreg tests.

2016-03-07 Thread sundararajan . athijegannathan
Changeset: da3c0f81ef3d Author:sundar Date: 2016-03-07 22:41 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/da3c0f81ef3d adding missing @modules declaration for 3 jtreg tests. ! test/src/jdk/nashorn/internal/runtime/doubleconv/test/BignumTest.java ! test/src/jdk/nash

Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

2016-03-07 Thread David DeHaven
>> I've updated the webrev, hopefully one last time with feedback from Joe >> Darcy. >> http://cr.openjdk.java.net/~ddehaven/8132743/webrev.2/ >> >> - Relocated package Javadoc to above the package declaration in >> package-info.java >> - Reworded the Javadoc on the default JSObject ctor >> >>

Re: Ant break

2016-03-07 Thread Alan Bateman
On 07/03/2016 16:41, Stephen Felts wrote: I'm seeing a problem using ant that I suspect is related to the classloading. I think it came in build 107 or 108. This may be issue caused by the Multi-Release JAR file support that went into jdk-9+108. Uwe Schindler brought this up on core-libs-d

Ant break

2016-03-07 Thread Stephen Felts
I'm seeing a problem using ant that I suspect is related to the classloading. I think it came in build 107 or 108. The following Is failing with /mydir/build.xml:27: taskdef class "ignore"/> cannot be found using the classloader AntClassLoader[/mydir_build/ant-contrib-1.0b3.ja

hg: jigsaw/jake/nashorn: Uncommented invokeNoPermissions method of JavaAdapterServices.

2016-03-07 Thread sundararajan . athijegannathan
Changeset: d8989b28c7fe Author:sundar Date: 2016-03-07 21:58 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/d8989b28c7fe Uncommented invokeNoPermissions method of JavaAdapterServices. ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/Java

Re: [9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

2016-03-07 Thread Kevin Rushforth
Dave, Just to tie up the loose end about the default JSObject constructor: No it cannot be package private. JavaFX WebView extends this class. -- Kevin Alan Bateman wrote: On 05/03/2016 18:54, David DeHaven wrote: I've updated the webrev, hopefully one last time with feedback from Joe Da

hg: jigsaw/jake/hotspot: Update spec for JVM TI VMStart event

2016-03-07 Thread alan . bateman
Changeset: 9a29ce81be87 Author:alanb Date: 2016-03-07 15:10 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9a29ce81be87 Update spec for JVM TI VMStart event ! src/share/vm/prims/jvmti.xml

hg: jigsaw/jake/nashorn: nasgen class writer getCommonSuperClass should use isScriptClass check to return ScriptObject as type.

2016-03-07 Thread sundararajan . athijegannathan
Changeset: 4ec6dc731b3a Author:sundar Date: 2016-03-07 20:00 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/4ec6dc731b3a nasgen class writer getCommonSuperClass should use isScriptClass check to return ScriptObject as type. ! buildtools/nasgen/src/jdk/nashorn/intern

Re: modulepath and classpath mixture

2016-03-07 Thread Alan Bateman
On 07/03/2016 13:53, Sander Mak wrote: : I was playing around with exactly this yesterday, and this is what I ended up with: javac -Xmodule:javamodularity.easytext.algorithm.naivesyllablecounter \ -XaddReads:javamodularity.easytext.algorithm.naivesyllablecounter=org.junit \ -mp

Re: Need help testing the EA builds

2016-03-07 Thread Alan Bateman
On 07/03/2016 13:53, Volker Simonis wrote: Hi Alan, Dmitry, thanks a lot for your help. Alan's suggestion to move the dependency from src/jdk.jcmd/share/classes/module-info.java to src/jdk.jcmd/$OS/classes/module-info.java.extra works fine. After doing that change I could successfully build on A

Re: Need help testing the EA builds

2016-03-07 Thread Volker Simonis
Hi Alan, Dmitry, thanks a lot for your help. Alan's suggestion to move the dependency from src/jdk.jcmd/share/classes/module-info.java to src/jdk.jcmd/$OS/classes/module-info.java.extra works fine. After doing that change I could successfully build on AIX. I'll open a bug for this and post a webre

Re: modulepath and classpath mixture

2016-03-07 Thread Sander Mak
> I don't think I understand the issue here. Using -Xpatch doesn't change the > module declaration or export. It can be used to override or augment the > module content, it just can't override the module declaration. It can be used > in conjunction with -XaddReads and -XaddExports to read addit

Re: modulepath and classpath mixture

2016-03-07 Thread Alan Bateman
On 06/03/2016 14:01, Robert Scholte wrote: Hi, I've asked for some feedback and there seems to be concerns with split packages when there are two or more modules on the module path that export the same package. Unless I misunderstand the issue, I'd say you have the same problem with -addmods.

Re: Need help testing the EA builds

2016-03-07 Thread Alan Bateman
On 07/03/2016 09:38, Dmitry Samersoff wrote: Volker, Currently tmtools (jstack, jmap, jinfo, ... ) has two modes of operations - one is cooperative (attach API based) other one is non-cooperative (SA based). Long term plan is completely separate these two modes, with jhsdb as the only entry poi

hg: jigsaw/jake/jdk: Build cleanup

2016-03-07 Thread erik . joelsson
Changeset: a0071ded705e Author:erikj Date: 2016-03-07 11:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a0071ded705e Build cleanup ! make/launcher/LauncherCommon.gmk

hg: jigsaw/jake: Build cleanup

2016-03-07 Thread erik . joelsson
Changeset: deba19bdeddf Author:erikj Date: 2016-03-07 11:25 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/deba19bdeddf Build cleanup ! common/autoconf/boot-jdk.m4 ! common/autoconf/generated-configure.sh ! make/CompileJavaModules.gmk ! make/Main.gmk ! make/common/JavaCompil

Re: Need help testing the EA builds

2016-03-07 Thread Dmitry Samersoff
Volker, Currently tmtools (jstack, jmap, jinfo, ... ) has two modes of operations - one is cooperative (attach API based) other one is non-cooperative (SA based). Long term plan is completely separate these two modes, with jhsdb as the only entry point to SA. This work is partially done - SA bas