Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

On 14/12/2016 06:49, Mandy Chung wrote: JDK-8171201: Drop java.compact$N aggregator modules JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java letters http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171201%2b8171202/webrev.00/ The hg moves are showing up as new files in t

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

On 14/12/2016 07:30, Peter Levart wrote: Hi David, On 12/14/2016 07:17 AM, David Holmes wrote: But let me explain why .setAccessible(true) can't be allowed for protected members in general. I'm confused as to what is being argued for/against here. Rony asked why .setAccessible(true) can'

Re: hg: jigsaw/jake/langtools: enable -Xlint:module by default

A fine idea. Rémi - Mail original - > De: "jonathan gibbons" > À: jigsaw-dev@openjdk.java.net > Envoyé: Mercredi 14 Décembre 2016 04:23:12 > Objet: hg: jigsaw/jake/langtools: enable -Xlint:module by default > Changeset: 4a200166396d > Author:jjg > Date: 2016-12-13 19:23 -0800 >

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

Hi Peter, On 14/12/2016 5:30 PM, Peter Levart wrote: Hi David, On 12/14/2016 07:17 AM, David Holmes wrote: But let me explain why .setAccessible(true) can't be allowed for protected members in general. I'm confused as to what is being argued for/against here. Rony asked why .setAccessible(

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

On 14/12/2016 09:56, David Holmes wrote: Sorry I don't follow. Calling setAccessible(true), logically does nothing except set a flag that controls whether reflective use of the member will need to pass an access check -it doesn't (or shouldn't) perform the access check! Best to read the java

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

On 14/12/2016 8:15 PM, Alan Bateman wrote: On 14/12/2016 09:56, David Holmes wrote: Sorry I don't follow. Calling setAccessible(true), logically does nothing except set a flag that controls whether reflective use of the member will need to pass an access check -it doesn't (or shouldn't) perfor

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

Webrev updated in-place. http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/ -Chris. On 13/12/16 21:18, Peter Levart wrote: I think this is OK. Just a couple of nits in test: 1. You create a static Path bob = Paths.get("bob") field, but then you don't use it in: 56 try (File

hg: jigsaw/jake/langtools: Missing target modules of qualified exports should produce a warning rather than an error.

Changeset: 5c6049f251e7 Author:jlahoda Date: 2016-12-14 12:51 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/5c6049f251e7 Missing target modules of qualified exports should produce a warning rather than an error. ! src/jdk.compiler/share/classes/com/sun/tools/java

Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

Build changes look good to me. /Erik On 2016-12-14 07:49, Mandy Chung wrote: JDK-8171201: Drop java.compact$N aggregator modules JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java letters http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171201%2b8171202/webrev.00/ Compact

RFR 8171070: Test ModuleNamesOrderTest.java fails

Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8171070 Thanks, -Sundar

Re: RFR 8171070: Test ModuleNamesOrderTest.java fails

On 14/12/2016 13:44, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8171070 Looks okay. -Alan

Re: RFR 8171070: Test ModuleNamesOrderTest.java fails

+1 > On Dec 14, 2016, at 9:37 AM, Alan Bateman wrote: > > On 14/12/2016 13:44, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8171070/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8171070 > Looks okay. > > -Alan

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

On 13.12.2016 23:17, Peter Levart wrote: [...] You might have access to a protected method, but you can not delegate that access to a 3rd party unless you make the Method object .setAccessible(true) and pass it to the 3rd party as a capability. (I recommend using MethodHandle(s) for such delega

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

On 14/12/2016 14:30, Jochen Theodorou wrote: : I don't intend to get access to hidden API after all... just exported. If you only interested in accessing the types and members that you have access to in these exported packages then you don't need setAccessible of course. We have seen a few ca

hg: jigsaw/jake/jdk: Additional test coverage in ImageModules.java

Changeset: ae2572dcd89a Author:chegar Date: 2016-12-14 16:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ae2572dcd89a Additional test coverage in ImageModules.java ! test/jdk/modules/incubator/ImageModules.java

Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

> On Dec 14, 2016, at 12:03 AM, Alan Bateman wrote: > > On 14/12/2016 06:49, Mandy Chung wrote: > >> JDK-8171201: Drop java.compact$N aggregator modules >> JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java >> letters >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8

hg: jigsaw/jake/jdk: 3 new changesets

Changeset: 47dc888f6f6c Author:alanb Date: 2016-12-14 16:08 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/47dc888f6f6c javadoc clarification ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java Changeset: c2f37a058fac Author:alanb Date: 2016-12

Re: Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

On 14/12/2016 16:19, Mandy Chung wrote: : Fixed. All looks good to me. -Alan

RFR 8171138: Remove FileCopierPlugin

Please review http://cr.openjdk.java.net/~sundar/8171138/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8171138 Piggybacking cleanup: release file generation ("TOP" entry type handling) moved to accept(ResourcePoolEntry) Thanks, -Sundar

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

Thanks to everyone who commented and/or shed some light about the situation for objects that need to invoke/access protected members in superclasses. The conclusion is, that nothing will change as protected members are still regarded to be public members for subclasses or objects of subclasses.

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

On 14/12/2016 16:51, Rony G. Flatscher wrote: Thanks to everyone who commented and/or shed some light about the situation for objects that need to invoke/access protected members in superclasses. The conclusion is, that nothing will change as protected members are still regarded to be public m

Re: RFR 8171138: Remove FileCopierPlugin

> On Dec 14, 2016, at 9:02 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8171138/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8171138 > > Piggybacking cleanup: release file generation ("TOP" entry type handling) > moved to accept(

--add-opens on an automatic module ?

I have yet another gradle exception: java.lang.IllegalAccessException: class org.gradle.groovy.scripts.internal.GradleResolveVisitor cannot access a member of class org.codehaus.groovy.control.ClassNodeResolver with modifiers "protected static final" Gradle is trying to use a jar it is packa

Re: RFR 8171138: Remove FileCopierPlugin

+1 > On Dec 14, 2016, at 1:02 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8171138/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8171138 > > Piggybacking cleanup: release file generation ("TOP" entry type handling) > moved to acce

Re: --add-opens on an automatic module ?

Hi, is this something that is logged when you are using -Dsun.reflect.debugModuleAccessChecks=true? In that case this could be a pre-existing exception that is/was being swallowed. (I might be wrong, but my assumption it that automatic modules - if such are involved - are implicitly open) Tha

Re: --add-opens on an automatic module ?

On 14/12/2016 17:21, David Hill wrote: I have yet another gradle exception: java.lang.IllegalAccessException: class org.gradle.groovy.scripts.internal.GradleResolveVisitor cannot access a member of class org.codehaus.groovy.control.ClassNodeResolver with modifiers "protected static final"

RE: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

Hi Chris, looks good to me. I already created a patch / branch of Apache Lucene that uses your proposed API and removes the Runnable hack. You can see it and check it out on Github: For your info the issue description and descripti

hg: jigsaw/jake/jdk: DEBUG_ADD_OPENS: s/RESOLVED/ALL-RESOLVED/; tweak warning messages

Changeset: b2442ace41dd Author:mr Date: 2016-12-14 11:15 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b2442ace41dd DEBUG_ADD_OPENS: s/RESOLVED/ALL-RESOLVED/; tweak warning messages ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java ! src/java.base/sh

Re: --add-opens on an automatic module ?

Alan Bateman wrote: On 14/12/2016 17:21, David Hill wrote: I have yet another gradle exception: java.lang.IllegalAccessException: class org.gradle.groovy.scripts.internal.GradleResolveVisitor cannot access a member of class org.codehaus.groovy.control.ClassNodeResolver with modifiers "pr

hg: jigsaw/jake/jdk: Improve warnings for invalid module names at jlink/run time

Changeset: d9e238be50b9 Author:alanb Date: 2016-12-14 19:25 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d9e238be50b9 Improve warnings for invalid module names at jlink/run time ! src/java.base/share/classes/jdk/internal/module/Checks.java ! src/java.base/share/classes

hg: jigsaw/jake/jdk: DEBUG_ADD_OPENS: Further message tweaks

Changeset: d435ff62fe7e Author:mr Date: 2016-12-14 11:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d435ff62fe7e DEBUG_ADD_OPENS: Further message tweaks ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

hg: jigsaw/jake/jdk: ModuleReference equals/hc should not use reader and hash suppliers

Changeset: 78a3778bd7b2 Author:alanb Date: 2016-12-14 20:55 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/78a3778bd7b2 ModuleReference equals/hc should not use reader and hash suppliers ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java ! src/java.base

hg: jigsaw/jake/langtools: Add javap support for ModuleResolution attribute

Changeset: 7b6b9fd8d26d Author:jjg Date: 2016-12-14 13:22 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/7b6b9fd8d26d Add javap support for ModuleResolution attribute ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java ! src/jdk.jdeps/share/classes

8170987: Module system implementation refresh (12/2016)

Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the changes to jdk9/dev to make jdk-9+150. The changes in this update are mostly for JSR 376 issues #VersionedDependences and #Mo

Re: 8170987: Module system implementation refresh (12/2016)

On 12/14/2016 4:46 PM, Alan Bateman wrote: Folks on jigsaw-dev will be aware that we are on yet another mission to bring the changes accumulated in the jake forest to jdk9/dev. The plan this time is to bring the changes to jdk9/dev to make jdk-9+150. The changes in this update are mostly for

hg: jigsaw/jake/langtools: fix javac command line help for --module-version

Changeset: 334e62436026 Author:jjg Date: 2016-12-14 14:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/334e62436026 fix javac command line help for --module-version ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties

Re: 8170987: Module system implementation refresh (12/2016)

Hi, I took a quick pass over the jdk changes. It generally looks very good, but I've got some comments: MethodHandles.Lookup.dropLookupMode: The javadoc doesn't really roll of the tongue here. Maybe "Creates a new lookup from the current one where the given lookup mode has been dropped. ..." for

hg: jigsaw/jake/jdk: fix formatting nit

Changeset: e0558b224fdf Author:mchung Date: 2016-12-14 16:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e0558b224fdf fix formatting nit ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

hg: jigsaw/jake/jdk: Fix up @modules in incubator and jlink plugin tests

Changeset: 3d3212804cd8 Author:mchung Date: 2016-12-14 17:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3d3212804cd8 Fix up @modules in incubator and jlink plugin tests ! test/jdk/modules/incubator/ImageModules.java ! test/tools/jlink/plugins/SystemModuleDescriptors/

hg: jigsaw/jake/langtools: Add support for reading module resolution flags

Changeset: 63af48cfc1c9 Author:jjg Date: 2016-12-14 17:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/63af48cfc1c9 Add support for reading module resolution flags ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/clas

Re: 8170987: Module system implementation refresh (12/2016)

> > The webrevs with the changes for this update are here: > > http://cr.openjdk.java.net/~alanb/8170987/1 I have pushed the change to rename jdk.crypto.pkcs11 and jdk.pack200 and dropped java.compact$N. So module-info.java changes will not be needed when you sync with jdk9/dev. I reviewed

Re: RFR 8171138: Remove FileCopierPlugin

Hi Mandy, Thanks for your review. I updated to handle TOP entries in accept callback uniformly: http://cr.openjdk.java.net/~sundar/8171138/webrev.01/index.html Thanks, -Sundar On 14/12/16, 10:51 PM, Mandy Chung wrote: On Dec 14, 2016, at 9:02 AM, Sundararajan Athijegannathan wrote: Pleas

Re: RFR 8171138: Remove FileCopierPlugin

> On Dec 14, 2016, at 8:35 PM, Sundararajan Athijegannathan > wrote: > > Hi Mandy, > > Thanks for your review. I updated to handle TOP entries in accept callback > uniformly: http://cr.openjdk.java.net/~sundar/8171138/webrev.01/index.html 395 // Copy TOP files of the "jav