Re: Modules with platform specific parts

2021-09-15 Thread Samuel Audet
We can publish JMODs, or any other binaries for that matter, on Maven repositories, for example, here's a random one I've just pulled out: https://search.maven.org/artifact/com.github.nullterminated/trylambda/1.4/jmod But why do we need to maintain 2 different sets of archives containing essen

Re: Modules with platform specific parts

2021-09-15 Thread Kevin Rushforth
We do have jmods available for download, but not in maven central. I'm not well-versed enough with maven / gradle support for jmods to know whether it would even be an option, but even we do have them, we still need the modular jars for the cases where the developer doesn't end up running jlink

Re: Modules with platform specific parts

2021-09-15 Thread Kevin Rushforth
If we do eventually have to go with multiple, differently-named modules, this would seem a sensible approach. I think it's roughly what Johan was alluding to when he spoke of extending option 2 to use an SPI. In this case, we would refactor the platform-specific code into different named module

Re: Modules with platform specific parts

2021-09-15 Thread Kevin Rushforth
Thanks for starting this discussion. One thing to point out is that for JavaFX we actually use two different approaches depending on whether you are talking about the maven artifacts or the downloadable artifacts. The maven artifacts, which is what Johan was primarily referring to, use optio

Re: Modules with platform specific parts

2021-09-15 Thread Hervé Guillemet
Hi, Thank you Johan for starting this discussion. The current situation is indeed problematic and a (de facto or not) standard should emerge. IMO, beyond being easy to use, the selected mechanism should allow to build multi-platform images (for instance for MacOSX on both aarch64 and x86_64). >

Re: Modules with platform specific parts

2021-09-15 Thread Alan Bateman
On 15/09/2021 09:45, Johan Vos wrote: Hi, There have been discussions in the past about how to deal with platform-specific parts (java code, native code, resources) in modules. There is no standard for this, and afaik no recommendation. In the OpenJFX project, we upload jars with module info to

Re: Modules with platform specific parts

2021-09-15 Thread Michał Kłeczek
Hi, Hi, There is another option: API module and multiple platform specific modules (different names like javafx.graphics.linux.aarch64) that require API module and provide services. API module does not “require” any platform specific module but uses ServiceLoader to find a proper implementati

Modules with platform specific parts

2021-09-15 Thread Johan Vos
Hi, There have been discussions in the past about how to deal with platform-specific parts (java code, native code, resources) in modules. There is no standard for this, and afaik no recommendation. In the OpenJFX project, we upload jars with module info to maven central, and we have plugins for m