Hi Igor,
small nit:
42 * @modules java.management
43 * jdk.attach
44 * jdk.management.agent/jdk.internal.agent
I don't think java.management needs to be specified as
a dependency when the test requires jdk.management.agent,
because jdk.management.agent already require
017, at 10:29 AM, Daniel Fuchs wrote:
Hi Mandy,
Some early comments:
GenGraphs.java
--
58 dir = Paths.get(args[++i]);
may produced ArrayOutOfBoundsException - should we have better
error reporting?
Or should it check && i < args.length - 1 so that it falls
Hi Mandy,
Some early comments:
GenGraphs.java
--
58 dir = Paths.get(args[++i]);
may produced ArrayOutOfBoundsException - should we have better
error reporting?
Or should it check && i < args.length - 1 so that it falls back
to having dir == null below?
93
.res
Hi Volker,
On 15/02/17 15:52, Volker Simonis wrote:
Hi Max,
I'm not an jigsaw either, but wouldn't your solution break a tool like jlink?
In other words, if an application uses your code and the developer
uses jlink to create a run-time image, wouldn't that image fail to
execute his applicatio
Hi Alan,
jaxp and stack walking class (and test) changes look OK to me.
best regards,
-- daniel
On 07/02/17 13:23, Alan Bateman wrote:
We've been accumulating changes in the jake forest for the last few
weeks and it's time to bring the changes to jdk9/dev, to make jdk-9+157
if possible. JDK
On 02/11/16 19:11, Mandy Chung wrote:
Updated version:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.04/
+1.
I like that toString() is now consitent with toLoaderModuleClassName()
in the way both methods handle module name and version.
best regards,
-- daniel
Hi Mandy,
On 01/11/16 23:42, Mandy Chung wrote:
Hi Daniel,
Here is the updated webrev incorporating your feedback:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.03
ClassLoader.java:
345 if (name != null && name.isEmpty()) {
346 throw new IllegalArgume
On 01/11/16 15:10, Alan Bateman wrote:
There is an issue in JIRA to track change the HTTP protocol handler to
use services for authentication mechanism, I don't think anyone has had
time to work on that yet.
This is https://bugs.openjdk.java.net/browse/JDK-8038079
-- daniel
Hi Mandy,
I am sure I must be missing something:
322 if (s == null) {
323 // all elements will be included
324 s = "";
325 if (classLoaderName != null &&
!classLoaderName.isEmpty()) {
326 s += classLoaderName + "/";
327
On 21/03/16 18:02, huizhe wang wrote:
On 3/21/2016 9:56 AM, Alan Bateman wrote:
On 21/03/2016 16:49, huizhe wang wrote:
Then the module-info.java needs to be fixed. XMLReaderFactory is
supported along with SAX.
Are you sure this API is using ServiceLoader? I have a vague memory
that we'd n
Hi Alan,
I had a look at the jdeps changes and they look good.
I have a couple of minor comments:
http://cr.openjdk.java.net/~alanb/8142968/2/langtools/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Archive.java.frames.html
120 @Override
121 public int hashCode() {
122 int hash = 7;
123
On 02/03/16 18:48, Alexandre (Shura) Iline wrote:
Hi.
Could you please take a look on a fix to add missing module dependencies for
tests in java/lang.
JDK9 changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.01
Jake changes: http://cr.openjdk.java.net/~shurailine/8150998/webrev
Hi Alan,
On 29/01/16 17:00, Alan Bateman wrote:
On 29/01/2016 15:55, Daniel Fuchs wrote:
Hi,
Please find below a patch that slightly modifies
the JEP 264 initial implementation to take advantage
of the module system.
The change modifies the LoggerFinder abstract service
to take the Module of
Hi,
Please find below a patch that slightly modifies
the JEP 264 initial implementation to take advantage
of the module system.
The change modifies the LoggerFinder abstract service
to take the Module of the caller class as parameter
instead of the caller class itself.
The caller class was used
On 09/10/15 14:30, Jaroslav Bachorik wrote:
Would it be possible for javac to recognise a class is an MXBean and
turn-on -parameters for such classes only by default? Too hacky?
Definitely :) Hacky as heck :)
I agree with Jaroslav.
FWIW - The @CP is not used for the MXBean itself, but for th
Hi Jaroslav,
1. I think it would be good to change the synopsis of the issue
to match what the proposed change does.
It seems to me that something like:
Add a new javax.management.annotation.ConstructorProperties
annotation
would be a better description.
2. I agree with Alan th
Hi Jaroslav,
I'll look at the code in more details, but doesn't your
webrev miss some modifications to modules.xml?
oh - I see you have module-info.java - are you planning to
push that in jake repo first then?
best regards,
-- daniel
On 08/10/15 13:49, Jaroslav Bachorik wrote:
Please, review
> I now make @apiNote in CL::getPackage to @deprecated.
Hi Mandy, Alan,
Doesn't this leads to deprecate the method
static Package.getPackage(String name) too - as this is
based on CL.getPackage(String)?
best regards,
-- daniel
On 28/09/15 21:36, Mandy Chung wrote:
On 09/27/2015 01:29 AM,
Hi Chris,
I had a look at the changes in java.logging and java.management modules
(+ corresponding tests) and they look reasonable to me.
I also had a cursory look at the jdeps changes. It's difficult for me
to review that without importing the changes and playing with the
tool as this is a part
19 matches
Mail list logo
