Re: Why service provider method is called "provider", but not "provide"?

2020-11-24 Thread David Holmes
e good. I would name it either "service" or "provide". -- Best regards, Alex Orlov Вторник, 24 ноября 2020, 10:26 +03:00 от David Holmes : On 24/11/2020 4:46 pm, Alex Orlov wrote: > Could you then explain the difference between service and service > prov

Re: Why service provider method is called "provider", but not "provide"?

2020-11-23 Thread David Holmes
serviceProvider() or serviceImplementor() - but providor() suffices. Cheers, David - -- Best regards, Alex Orlov Вторник, 24 ноября 2020, 7:47 +03:00 от David Holmes : On 23/11/2020 6:28 pm, Alex Orlov wrote: > > The method does return a "provider". It r

Re: Why service provider method is called "provider", but not "provide"?

2020-11-23 Thread David Holmes
service. And that object is the service provider. David - -- Best regards, Alex Orlov Понедельник, 23 ноября 2020, 1:30 +03:00 от David Holmes : On 20/11/2020 9:48 pm, Alex Orlov wrote: > > Hello all, > > According to this tutorial https://

Re: Why service provider method is called "provider", but not "provide"?

2020-11-22 Thread David Holmes
On 20/11/2020 9:48 pm, Alex Orlov wrote: Hello all, According to this tutorial https://www.logicbig.com/tutorials/core-java-tutorial/modules/service-provider-method.html we can declare in module-info provider class with "provider" method. For example,  .. public class TheServicePr

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-13 Thread David Holmes
On 13/04/2018 5:12 PM, Doug Simon wrote: On 13 Apr 2018, at 07:15, David Holmes wrote: Hi Doug, Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this ??? These are the non-Graal code base changes needed to move the bean out of the jdk.internal.vm.compiler module

Re: RFR: 8187490: HotSpotRuntimeMBean should be moved to Graal management module

2018-04-12 Thread David Holmes
Hi Doug, Not a review. :) Just wondering what HotSpotRuntimeMBean has to do with this ??? Thanks, David On 13/04/2018 4:24 AM, Doug Simon wrote: Please review this change that removes the existing Graal service provider for hooking into the Platform MBean Server and makes jdk.internal.vm.c

Re: How does one handle a java method which returns a non-public sub-type via reflection?

2018-01-16 Thread David Holmes
ource? If so, why not expose it making it easier for others so those interested don't have to reinvent the wheel every time. Is there official documentation explaining the method resolution process somewhere? On Monday, January 15, 2018, 4:02:44 PM CST, David Holmes wrote: On 16

Re: How does one handle a java method which returns a non-public sub-type via reflection?

2018-01-15 Thread David Holmes
On 16/01/2018 4:27 AM, jeffrey kutcher wrote: Thanks for your thoughts Jochen. I have a section of code that does just that; function search and casting return values. Not easy ... nor as easy as it should be. You would think however, that if a function call would cause no issues, say vbox.ge

Re: Minimal and client VM for jlink?

2018-01-08 Thread David Holmes
Hi Nicolai, On 9/01/2018 6:30 AM, Nicolai Parlog wrote: Hi, every source I found indicates that jlink makes it possible to create a runtime image with a client, server, or minimal VM. However I can't make it work for client and minimal: Error: Selected VM client doesn't exist. I tri

Re: Module system and services directory in META-INF

2017-12-26 Thread David Holmes
On 27/12/2017 5:43 AM, Jochen Theodorou wrote: On 26.12.2017 19:30, Jochen Theodorou wrote: hi all, Do all files in META-INF/services now have to be well formed according to the SPI strucutres in Java, or is it still valid to have other files in there as well? Before the module system it was

Re: wscompile issues

2017-08-31 Thread David Holmes
Hi Peter, Moving this over to jigsaw-dev. David On 29/08/2017 3:45 PM, Peter Major wrote: Hi, I'm not quite sure if this is the right mailing list to ask, but I'm wondering whether there is a bug in wscompile in the build 9+181 version. In a project of mine, I have a java ant task calling c

Re: Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

2017-05-25 Thread David Holmes
Correction ... On 25/05/2017 5:00 PM, David Holmes wrote: Hi Mandy On 25/05/2017 8:10 AM, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI

Re: Review Request: JDK-8181033: Confusing message: A JNI error has occurred, please check your installation and try again

2017-05-25 Thread David Holmes
Hi Mandy On 25/05/2017 8:10 AM, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181033/webrev.00/ This fixes the launcher to print the exception being thrown rather than the confusing message "Error: A JNI error has occurred, please check your installation and try again”. A

Re: JPMS Access Checks, Verification and the Security Manager

2017-05-23 Thread David Holmes
On 23/05/2017 10:45 PM, Volker Simonis wrote: On Tue, May 23, 2017 at 10:51 AM, David Holmes wrote: On 23/05/2017 6:20 PM, Alan Bateman wrote: Volker - one suggestion for your experiments is to change your JDK 8 security properties file (java.security) to add "com.sun.crypto.provider

Re: JPMS Access Checks, Verification and the Security Manager

2017-05-23 Thread David Holmes
On 23/05/2017 6:20 PM, Alan Bateman wrote: Volker - one suggestion for your experiments is to change your JDK 8 security properties file (java.security) to add "com.sun.crypto.provider." to the value of the "package.access" property. That should mean you will get the same AccessControlException

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-21 Thread David Holmes
On 22/03/2017 8:09 AM, serguei.spit...@oracle.com wrote: Alan, The hotspot part looks good. I second that - but a few copyright years need updating. It was unfortunate that yet another version of vm_exit_during_initialization had to be added. Thanks, David Thanks, Serguei On 3/21/17 14

Re: RFR: 8175010: ImageReader is not thread-safe

2017-02-16 Thread David Holmes
Hi Claes, On 15/02/2017 11:22 PM, Claes Redestad wrote: Hi, a few intermittent but rare test failures[1] that has appeared since the latest jake integration, and since one of the changes in there was to make initialization of the system ImageReader lazy there appears to be cases where ImageRead

Re: Extending java.base module

2017-02-15 Thread David Holmes
On 15/02/2017 8:03 PM, Langer, Christoph wrote: Hi Chris, Max, thanks for your quick answers. So the service approach seems to fit quite well. But can I assume that my service implementation will be available already at "bootstrap time" of the JDK? E.g. if I need to register/reach my service

Re: -Xlog and the module system

2017-02-02 Thread David Holmes
On 2/02/2017 8:59 PM, Nicolai Parlog wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Alan. The trace messages emitted by -Xdiag:resolver are printed as the resolver runs. I'm sorry for being such a noob but my Google Foo failed at telling me how to turn trace on for -Xdiag. :( Can

Re: -Xlog and the module system

2017-02-01 Thread David Holmes
On 2/02/2017 7:49 AM, Nicolai Parlog wrote: Hi Alan, `-Xdiag:resolver` is awesome! :) I think these messages are great candidates for info-level messages with the "modules" tag via unified logging. You are dealing with two completely separate pieces of the platform. -Xdiag is a launcher opti

Re: Fwd: resource location problem in JDK 9 from build 148 onward

2017-01-16 Thread David Holmes
Typo: ResourceAllocationProblem.class -> ResourceLocationProblem.class David On 17/01/2017 11:15 AM, David Holmes wrote: Hi Rick, On 17/01/2017 10:55 AM, Rick Hillegas wrote: Resending since the moderator rejected my initial post for want of a subscription to jigsaw-dev. Origi

Re: Fwd: resource location problem in JDK 9 from build 148 onward

2017-01-16 Thread David Holmes
Hi Rick, On 17/01/2017 10:55 AM, Rick Hillegas wrote: Resending since the moderator rejected my initial post for want of a subscription to jigsaw-dev. Original Message Subject: resource location problem in JDK 9 from build 148 onward Date: Mon, 16 Jan 2017 08:45:23 -

Re: Compact profile modules

2017-01-16 Thread David Holmes
Hi Mandy, On 17/01/2017 7:51 AM, Mandy Chung wrote: java.compact$N modules were removed in jdk-9+150 [1][2]. We revisited the need for java.compact$N aggregator. Compact Profiles were useful in SE 8 but are legacy in 9, as intended from the outset. Highlighting them in the standard SE 9 modul

Re: Review Request: JDK-8168836 Minor clean up on warning/error messages on --add-exports and --add-reads

2017-01-03 Thread David Holmes
Hi Mandy, http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168836/webrev.00/ This patch improves the warning/error message to include the option name, emit a warning if unknown module is specified with —-patch-module be consistent with the options. Mandy As a result of this change we now

Re: NCDFE on jdk.internal.reflect.SerializationConstructorAccessorImpl

2016-12-15 Thread David Holmes
Hi Andrew, I'm redirecting this to jigsaw-dev as it seems to be a modularity related problem. Additional comment below ... David On 16/12/2016 7:48 AM, Andrew Guibert wrote: Hello all, I've been doing some experimentation with WebSphere Liberty on Java 9 and ran into a problem that I bel

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-14 Thread David Holmes
On 14/12/2016 8:15 PM, Alan Bateman wrote: On 14/12/2016 09:56, David Holmes wrote: Sorry I don't follow. Calling setAccessible(true), logically does nothing except set a flag that controls whether reflective use of the member will need to pass an access check -it doesn't (or

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-14 Thread David Holmes
Hi Peter, On 14/12/2016 5:30 PM, Peter Levart wrote: Hi David, On 12/14/2016 07:17 AM, David Holmes wrote: But let me explain why .setAccessible(true) can't be allowed for protected members in general. I'm confused as to what is being argued for/against here. Rony asked why .set

Re: Question ad #AwkwardStrongEncapsulation (Re: Moving the changes in jake to jdk9/dev

2016-12-13 Thread David Holmes
On 14/12/2016 8:17 AM, Peter Levart wrote: Hi Jochen, On 12/13/2016 06:32 PM, Jochen Theodorou wrote: On 12.12.2016 20:56, Alex Buckley wrote: [...] The ability of protected members to be accessed from outside their package means they are essentially public members for the purposes of inher

Use cases for java.lang.Module.addExports

2016-12-11 Thread David Holmes
Does addExports only affect reflective access to the module, or does it change all access? I'm trying to determine what the set of actions X will be such that: try { ; } catch () { execute( () -> mod.addExports(...)); // address the problem ; // now it succeeds } Thanks, David

Re: Size difference of Java.base image between OSX and Linux

2016-10-28 Thread David Holmes
On 29/10/2016 3:32 AM, Waldek Kozaczuk wrote: I used jlink to create minimal custom JRE image on OSX and Linux and I noticed there is a significant difference in size. The Mac version takes 21M where the Linux one takes 30M which means Linux version is 50% bigger than Mac. Is it as you would

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

2016-10-28 Thread David Holmes
Hi Mandy, I know it's rather late in the game to notice this but I only just noticed this due to Serguei's comment ... On 28/10/2016 5:06 PM, serguei.spit...@oracle.com wrote: Hi Mandy, I have a few comments. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.00/jdk/src/java.ba

Re: is support for mips embedded platform

2016-10-20 Thread David Holmes
On 21/10/2016 12:41 PM, Diaz Soho wrote: hi, I have finish build jdk8u for mips embedded platform with zero VM. But the size of rt.jar is very big, it can not put into my embedded platform rootfs. I would like to find small set for embedded platform. I am not sure : is jigsaw suitable for mips e

Re: Exporting - the wrong default?

2016-08-01 Thread David Holmes
On 2/08/2016 1:58 AM, Stephane Epardaud wrote: I don't think public ever meant "public to the world". In Java 1->8 it means "visible to those who can see the containing scope". If you declare a public inner class in a private (or package-private) class, then those who cannot access the outer type

Re: Exporting - the wrong default?

2016-07-27 Thread David Holmes
esired, and that the set of packages a module exports is still known and limited (just automated by the compiler). Option (4) also mitigates the issue that David Holmes has repeatedly indicated, where jigsaw is currently planning on changing the meaning of "public". I think you meant Da

Re: Review request: JDK-8159596 Add java --dry-run

2016-07-03 Thread David Holmes
On 3/07/2016 8:09 AM, Mandy Chung wrote: On Jul 2, 2016, at 2:02 PM, Peter Levart wrote: What about extending the behavior of -version option so that when it is specified together with other startup options like -mp, -m, -cp, MainClass, ... it would behave just like --dry-run has been desig

Re: Review request: JDK-8159596 Add java --dry-run

2016-07-02 Thread David Holmes
On 2/07/2016 1:17 AM, Mandy Chung wrote: On Jul 1, 2016, at 12:48 AM, David Holmes wrote: Okay so back to my original statement - if all this does is ensure the main class is found does it really carry its weight as a new argument? Are you suggesting for java —-dry-run to run or not to

Re: Review request: JDK-8159596 Add java --dry-run

2016-07-01 Thread David Holmes
On 1/07/2016 4:11 PM, Mandy Chung wrote: On Jun 30, 2016, at 10:15 PM, David Holmes wrote: On 1/07/2016 3:00 PM, Mandy Chung wrote: On Jun 30, 2016, at 9:44 PM, David Holmes wrote: I had assumed that initialization was desirable as part of checking that everything was specified

Re: Review request: JDK-8159596 Add java --dry-run

2016-06-30 Thread David Holmes
On 1/07/2016 3:00 PM, Mandy Chung wrote: On Jun 30, 2016, at 9:44 PM, David Holmes wrote: I had assumed that initialization was desirable as part of checking that everything was specified correctly. If not then --dry-run would seem to do very little compared to just running -version, and

Re: Review request: JDK-8159596 Add java --dry-run

2016-06-30 Thread David Holmes
On 30/06/2016 5:37 PM, Peter Levart wrote: Hi Mandy, The following patch: --- old/src/java.base/share/native/libjli/java.c2016-06-30 09:32:59.519839770 +0200 +++ new/src/java.base/share/native/libjli/java.c2016-06-30 09:32:59.458839421 +0200 @@ -476,15 +476,6 @@ */ PostJVMI

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

2016-06-08 Thread David Holmes
Hi Mandy, On 9/06/2016 10:45 AM, Mandy Chung wrote: Adding jigsaw-dev where the code review is posted. See [1] for Coleen’s review comment. On Jun 8, 2016, at 4:53 PM, David Holmes wrote: On 9/06/2016 8:37 AM, Coleen Phillimore wrote: I have to ask why Hotspot convention was violated

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

2016-06-05 Thread David Holmes
Hi Mandy, On 4/06/2016 4:47 PM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.00/ -modulepath, -addmods, -limitmods, -XaddExports, -XaddReads, -Xpatch are java launcher options in the current implementation. Custom launchers will have to use -D t

Re: Review for 8130344

2015-07-13 Thread David Holmes
, at 11:16, David Holmes wrote: On 13/07/2015 6:06 PM, Jean-Francois Denise wrote: Thank you, I am removing the null check and throw. Why are you removing them ?? David JF On 13 Jul 2015, at 08:06, David Holmes wrote: On 11/07/2015 2:45 AM, Jean-Francois Denise wrote: Thanks Alan, I had

Re: Review for 8130344

2015-07-13 Thread David Holmes
On 13/07/2015 6:06 PM, Jean-Francois Denise wrote: Thank you, I am removing the null check and throw. Why are you removing them ?? David JF On 13 Jul 2015, at 08:06, David Holmes wrote: On 11/07/2015 2:45 AM, Jean-Francois Denise wrote: Thanks Alan, I had read the spec from https

Re: Review for 8130344

2015-07-12 Thread David Holmes
On 11/07/2015 2:45 AM, Jean-Francois Denise wrote: Thanks Alan, I had read the spec from https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#array_operations And it was not clear. FYI the spec has just been updated to clarify that the NewArray functions can throw OO

Re: jdk-server-image ?

2014-10-07 Thread David Holmes
Never mind. I thought this was something jigsaw specific but it isn't. Sorry for the noise. David On 7/10/2014 7:56 PM, David Holmes wrote: Can someone tell me what the jdk-server-image is please? Thanks, David

jdk-server-image ?

2014-10-07 Thread David Holmes
Can someone tell me what the jdk-server-image is please? Thanks, David

Re: need advice on module structure for ISA-specific sources and classes

2014-09-04 Thread David Holmes
Hi John, On 5/09/2014 7:13 AM, John Rose wrote: We have standard OpenJDK source locations for platform-specific code, as described in http://openjdk.java.net/jeps/201 . For example: http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/src/java.base/linux/classes/sun/nio/ch/LinuxAsynchronousChanne

Re: RFR [9] Modular Source Code

2014-08-18 Thread David Holmes
On 16/08/2014 1:58 AM, Erik Joelsson wrote: Hello Omair, No, as I tried to explain in my initial mail on this thread, since the modules are all compiled in parallel, and not sequentially like the current build does with the repositories, it doesn't make much sense timing each module. The numbers