Re: 8181087: Module system implementation refresh (6/2017 update)

Hi Alan, I looked at the hotspot and top changes. They look good. Thanks, Serguei On 6/14/17 09:52, Alan Bateman wrote: It's time to bring the changes accumulated in the jake forest into jdk9/dev. I'm hoping we are near the end of these updates and that we can close the jake forest soon.

Re: 8178380: Module system implementation refresh (5/2017 update)

Hi Alan, I reviewed the Hotspot changes and the Jdk changes related to java.instrument and jdk.attch (including a fragment in the LauncherHelper.java). The fixes look good to me. Thanks, Serguei On 5/1/17 13:28, Alan Bateman wrote: As I mentioned in another thread, we need to get the

Re: 8177530: Module system implementation refresh (4/2017)

Ok. Thanks, Alan Serguei On 4/4/17 23:52, Alan Bateman wrote: On 05/04/2017 07:42, serguei.spit...@oracle.com wrote: The hotspot part looks good to me. + It seems, all the modules are modifiable at this point. Is it right? That's right. On the copyright dates then Lana will be doing

Re: 8177530: Module system implementation refresh (4/2017)

The hotspot part looks good to me. Some copyright comments need update: http://cr.openjdk.java.net/~alanb/8177530/1/hotspot/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java.frames.html

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

Hi Igor, It looks good. Thanks, Serguei On 3/22/17 13:09, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8177374/webrev.00/index.html 40 lines changed: 26 ins; 13 del; 1 mod; Hi all, could you please review this changeset which fixes in a few jdk_svc tests which were missed

Re: 8174823: Module system implementation refresh (3/2017)

Alan, The hotspot part looks good. Thanks, Serguei On 3/21/17 14:42, Alan Bateman wrote: We have been accumulating changes in the jake forest for the last few weeks to align with the proposals in JSR 376 and also to pick up API changes and bug fixes. It's time to bring these changes into

Re: RFR(L) : 8176176 : fix @modules in jdk_svc tests

Hi Igor, This looks good to me. A couple of questions below. http://cr.openjdk.java.net/~iignatyev//8176176/webrev.01/test/com/sun/jdi/InvokeHangTest.java.udiff.html - * @modules jdk.jdi * @library /test/lib + * @modules java.management + * jdk.jdiShould the jdk.jdi be removed from

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

On 1/9/17 04:16, Claes Redestad wrote: Hi Serguei, On 2017-01-09 09:11, serguei.spit...@oracle.com wrote: Hi Claes, It looks pretty good. thanks, One question on the following fragment: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/src/java.base/share/native/libjava

Re: RFR: 8171855: Move package name transformations during module bootstrap into native code

Hi Claes, It looks pretty good. One question on the following fragment: http://cr.openjdk.java.net/~redestad/8171855/jdk.04/src/java.base/share/native/libjava/Module.c.udiff.html + int valid = 1; + for (idx = 0; idx < num_packages; idx++) { + jstring pkg = (*env)->GetObjectArrayElement(env,

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

Thank you for clarifications, Mandy! Serguei On 10/28/16 14:36, Mandy Chung wrote: On Oct 28, 2016, at 12:06 AM, serguei.spit...@oracle.com wrote: Can we give the bootstrap classloader the name "boot" or "bootstrap”? BootClassLoader is not the boostrap class loader b

Re: Request Review: JDK-6479237 (cl) Add support for classloader names

Hi Mandy, I have a few comments. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.00/jdk/src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java.udiff.html private static class BootClassLoader extends BuiltinClassLoader { BootClassLoader(URLClassPath bcp)

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

On 2/29/16 04:29, Alan Bateman wrote: On 29/02/2016 08:32, serguei.spit...@oracle.com wrote: : Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ This looks good and I

Re: Jake build failed

On 2/24/16 07:43, mark.reinh...@oracle.com wrote: 2016/2/24 7:33 -0800, serguei.spit...@oracle.com: I have the same issue. The network is very unstable: ... It's not the network. There was an intermittent problem with hg.openjdk.java.net, which has now been fixed. It works now. Thanks

Re: Jake build failed

Hi Deven, I have the same issue. The network is very unstable: hotspot: searching for changes corba: pulling from http://hg.openjdk.java.net/jigsaw/jake/corba corba: abort: HTTP Error 500: Internal Server Error jaxp:

Re: Round #3: RFR: 8049365 - Update JDI and JDWP for modules

Hi Alan, On 1/23/16 02:35, Alan Bateman wrote: On 22/01/2016 22:16, serguei.spit...@oracle.com wrote: : Jdk webrev: cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.3/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.3/ Good

Re: Round #4: RFR: 8049365 - Update JDI and JDWP for modules

Thanks, Alan! I'm Ok with the tweaks you suggest before the push. Thanks, Serguei On 1/26/16 04:45, Alan Bateman wrote: On 26/01/2016 11:48, serguei.spit...@oracle.com wrote: Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk

Re: Round #3: RFR: 8049365 - Update JDI and JDWP for modules

Hi Lois, Some comments below. On 1/25/16 11:42, Lois Foltan wrote: On 1/22/2016 5:16 PM, serguei.spit...@oracle.com wrote: Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

On 1/22/16 00:35, Alan Bateman wrote: On 22/01/2016 03:34, serguei.spit...@oracle.com wrote: I saw the discussion but have no strong opinion yet. Changing to JVMTI_VERSION_9 will make it more consistent though. Thanks. We can always revert it if it turns out that there is a good reason

Round #3: RFR: 8049365 - Update JDI and JDWP for modules

Please, review this initial fix for the M4 Jigsaw task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.3/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.3/ Summary:

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

On 1/21/16 04:51, Alan Bateman wrote: On 20/01/2016 22:35, serguei.spit...@oracle.com wrote: : Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.2/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.2/ jvmti.xml

Round #2: RFR: 8049365 - Update JDI and JDWP for modules

Please, review this initial fix for the Jigsaw Bill milestone task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.2/ Hotspot webrev:

Re: Round #1: RFR: 8049365 - Update JDI and JDWP for modules

On 12/29/15 23:52, Alan Bateman wrote: On 28/12/2015 20:13, serguei.spit...@oracle.com wrote: It would be nice to get rid of this JVM TI capability. But my question is if new JVMTI functionality is mandatory for all VM's out there. I think we need to look at aligning the next version of JVM

Re: Round #1: RFR: 8049365 - Update JDI and JDWP for modules

On 12/30/15 06:57, Alan Bateman wrote: On 30/12/2015 11:37, serguei.spit...@oracle.com wrote: Do you mean to make a clean up and get rid of all occurrences of since="1.1"? I meant JDK 1.1 rather than JVM TI 1.1. There are a few functions like GetThreadInfo where it has spec lik

Re: Round #1: RFR: 8049365 - Update JDI and JDWP for modules

. Please, see my comments below. On 12/28/15 08:22, Alan Bateman wrote: On 23/12/2015 06:24, serguei.spit...@oracle.com wrote: Please, review this initial fix for the Jigsaw Bill milestone task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn

Re: Round #1: RFR: 8049365 - Update JDI and JDWP for modules

On 12/22/15 22:24, serguei.spit...@oracle.com wrote: Please, review this initial fix for the Jigsaw Bill milestone task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8049365-Jigsaw-jdk.1/ Hotspot webrev: http

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

Thanks, Mandy! Yes, the SA JDI connectors need an update for modules too. Thanks, Serguei On 12/11/15 18:07, Mandy Chung wrote: On Dec 11, 2015, at 12:40 AM, Alan Bateman wrote: We just need to make sure that they build and I can't recall if they are compiled

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

On 12/11/15 00:40, Alan Bateman wrote: On 10/12/2015 20:44, serguei.spit...@oracle.com wrote: : 3. In the Module command set then we'll need to decide the reply to the Name command for the case that the module is an unnamed module. There is also an open issue for the runtime API too

Re: preliminary RFR: 8049365 - Update JDI and JDWP for modules

Alan, Thanks for the comments and suggestions! On 12/10/15 04:04, Alan Bateman wrote: On 10/12/2015 08:03, serguei.spit...@oracle.com wrote: Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8049365-Jigsaw-jdk.0/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs