Re: 8177530: Module system implementation refresh (4/2017)

Hi Alan, The changes to jdk.internal.vm.compiler will need to go to https://github.com/graalvm/graal-core as well. For jdk10 we’re not doing two-way merges when we pull a fresh version of graal. For jdk9 it’s ok because we’re not going to refresh Graal

Re: 8177530: Module system implementation refresh (4/2017)

On 06/04/2017 15:30, Kevin Rushforth wrote: FX build for jdk9+164 already was promoted last Friday. The changeset to use that build was pushed to jdk9/dev on Saturday (as per usual), but probably wasn't synced down to jdk9/jake. Thanks. I will sync up jake once the jdk-9+164 tags have been

Re: 8177530: Module system implementation refresh (4/2017)

FX build for jdk9+164 already was promoted last Friday. The changeset to use that build was pushed to jdk9/dev on Saturday (as per usual), but probably wasn't synced down to jdk9/jake. -- Kevin Mandy Chung wrote: FXLauncherTest.java should fail until FX change [1] is integrated and promoted

Re: 8177530: Module system implementation refresh (4/2017)

Got it. Thank you Mandy! /Amy On 4/6/17 12:38 PM, Mandy Chung wrote: FXLauncherTest.java should fail until FX change [1] is integrated and promoted (target for jdk-9+164). I suggest to rerun the test after jdk-9+164 is promoted and sync down to jdk9/dev and jake. Mandy

Re: 8177530: Module system implementation refresh (4/2017)

FXLauncherTest.java should fail until FX change [1] is integrated and promoted (target for jdk-9+164). I suggest to rerun the test after jdk-9+164 is promoted and sync down to jdk9/dev and jake. Mandy [1] https://bugs.openjdk.java.net/browse/JDK-8177751 > On Apr 5, 2017, at 7:35 PM, Amy Lu

Re: 8177530: Module system implementation refresh (4/2017)

Hi, Alan I noticed test tools/launcher/FXLauncherTest.java fails with jigsaw-nightly-h6277-20170404 (on Windows platform). Is that because related OpenJFX changes are not yet in the mentioned build? Thanks, Amy On 4/5/17 12:28 AM, Alan Bateman wrote: As I mentioned on jigsaw-dev yesterday,

Re: 8177530: Module system implementation refresh (4/2017)

On 04/04/2017 20:03, Lois Foltan wrote: Hi Alan, Hotspot changes look good. One minor comment, can you move the definition of java/lang/Module at line #93 in hotspot/src/share/vm/classfile/vmSymbols.hpp up to a new line after #58 which is java/lang/Package? I wouldn't need to see another

Re: 8177530: Module system implementation refresh (4/2017)

Ok. Thanks, Alan Serguei On 4/4/17 23:52, Alan Bateman wrote: On 05/04/2017 07:42, serguei.spit...@oracle.com wrote: The hotspot part looks good to me. + It seems, all the modules are modifiable at this point. Is it right? That's right. On the copyright dates then Lana will be doing a

Re: 8177530: Module system implementation refresh (4/2017)

On 05/04/2017 07:42, serguei.spit...@oracle.com wrote: The hotspot part looks good to me. + It seems, all the modules are modifiable at this point. Is it right? That's right. On the copyright dates then Lana will be doing a bulk update soon. I expect it will update hundreds of files. I

Re: 8177530: Module system implementation refresh (4/2017)

The hotspot part looks good to me. Some copyright comments need update: http://cr.openjdk.java.net/~alanb/8177530/1/hotspot/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java.frames.html

Re: 8177530: Module system implementation refresh (4/2017)

Hi Alan, Hotspot changes look good. One minor comment, can you move the definition of java/lang/Module at line #93 in hotspot/src/share/vm/classfile/vmSymbols.hpp up to a new line after #58 which is java/lang/Package? I wouldn't need to see another webrev for this. Thank you, Lois On

8177530: Module system implementation refresh (4/2017)

As I mentioned on jigsaw-dev yesterday, we have accumulated a number of changes in the jake forest and would like to bring the changes into jdk9/dev for jdk-9+165. Most of the changes in this update are the move of Module and friends from java.lang.reflect to java.lang. This is mostly a