Hi,
This is one of the ways to fix 8139430:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.03
Could you please take a look on it?
A few comments.
The biggest dependency on java.management was in
jdk.testlibrary.ProcessTools.getProcessId() method. I have changed the method
to use the
Hi
I have just realized that an NPE could also be possible in
test/lib/testlibrary/jdk/testlibrary/Platform.java so it should be updated also:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.04/
Shura
> On Nov 9, 2015, at 8:54 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> This is o
Hi,
On 9.11.2015 19:12, Alexandre (Shura) Iline wrote:
Hi
I have just realized that an NPE could also be possible in
test/lib/testlibrary/jdk/testlibrary/Platform.java so it should be updated also:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.04/
As for the original (03) webrev - I
> On Nov 10, 2015, at 9:04 PM, Mandy Chung wrote:
>
> Hi Shura,
>
> Thanks for doing it and it’s good to see the unnecessary dependency to
> java.management eliminated.
>
> The new jdk.testlibrary.management package name is fine. It’s okay to keep
> the class name InputArguments as Jaroslav
> On Nov 10, 2015, at 10:11 AM, Alexandre (Shura) Iline
> wrote:
>
>>
>> On Nov 10, 2015, at 9:04 PM, Mandy Chung wrote:
>>
>> Hi Shura,
>>
>> Thanks for doing it and it’s good to see the unnecessary dependency to
>> java.management eliminated.
>>
>> The new jdk.testlibrary.management pac
Hi Shura,
Thanks for doing it and it’s good to see the unnecessary dependency to
java.management eliminated.
The new jdk.testlibrary.management package name is fine. It’s okay to keep the
class name InputArguments as Jaroslav suggests and it’s easier to tell what
this class is about.
There i
On 09/11/2015 19:12, Alexandre (Shura) Iline wrote:
Hi
I have just realized that an NPE could also be possible in
test/lib/testlibrary/jdk/testlibrary/Platform.java so it should be updated also:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.04/
Shura
I skimmed through the webrev and
> On Nov 10, 2015, at 12:42 PM, Alan Bateman wrote:
>
> Would it break many tests if getProcessId were changed to return long to
> match ProcessHandle::getPid?
There are not small number of tests doing
Integer.toString(ProcessTools.getProcessId()));
Most of them are in hotspot and there a
On 10 Nov 2015, at 12:21, Jaroslav Bachorik
wrote:
> Hi,
>
> On 9.11.2015 19:12, Alexandre (Shura) Iline wrote:
>> Hi
>>
>> I have just realized that an NPE could also be possible in
>> test/lib/testlibrary/jdk/testlibrary/Platform.java so it should be updated
>> also:
>> http://cr.openjdk.j
> On Nov 10, 2015, at 11:42 PM, Alan Bateman wrote:
>
>
>
> On 09/11/2015 19:12, Alexandre (Shura) Iline wrote:
>> Hi
>>
>> I have just realized that an NPE could also be possible in
>> test/lib/testlibrary/jdk/testlibrary/Platform.java so it should be updated
>> also:
>> http://cr.openjdk.
> On Nov 10, 2015, at 9:04 PM, Mandy Chung wrote:
>
> Hi Shura,
>
> Thanks for doing it and it’s good to see the unnecessary dependency to
> java.management eliminated.
>
> The new jdk.testlibrary.management package name is fine. It’s okay to keep
> the class name InputArguments as Jaroslav
V6:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.06/
Thank you.
Shura
> On Nov 11, 2015, at 7:41 PM, Alexandre (Shura) Iline
> wrote:
>
>
>> On Nov 10, 2015, at 11:42 PM, Alan Bateman wrote:
>>
>>
>>
>> On 09/11/2015 19:12, Alexandre (Shura) Iline wrote:
>>> Hi
>>>
>>> I have j
On 16.11.2015 14:01, Alexandre (Shura) Iline wrote:
V6:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.06/
Looks good!
Thanks,
-JB-
Thank you.
Shura
On Nov 11, 2015, at 7:41 PM, Alexandre (Shura) Iline
wrote:
On Nov 10, 2015, at 11:42 PM, Alan Bateman wrote:
On 09/11/20
On 16/11/2015 13:01, Alexandre (Shura) Iline wrote:
V6:
http://cr.openjdk.java.net/~shurailine/8139430/webrev.06/
This looks okay to me. For completeness then I assume the
THreadMXBeanTool.waitUntilXXX methods should re-assert the interrupt
status if interrupted when waiting.
-Alan
> On Nov 16, 2015, at 5:38 AM, Alan Bateman wrote:
>
>
>
> On 16/11/2015 13:01, Alexandre (Shura) Iline wrote:
>> V6:
>> http://cr.openjdk.java.net/~shurailine/8139430/webrev.06/
>>
>>
> This looks okay to me. For completeness then I assume the
> THreadMXBeanTool.waitUntilXXX methods should
Yes, sorry.
Since the methods do not have any work to complete before interrupting and also
methods are not used anywhere currently, I assume re-throwing the
InterruptedException is a better choice.
http://cr.openjdk.java.net/~shurailine/8139430/webrev.07/test/lib/testlibrary/jdk/testlibrary/ma
On 19/11/2015 16:40, Alexandre (Shura) Iline wrote:
Yes, sorry.
Since the methods do not have any work to complete before interrupting and also
methods are not used anywhere currently, I assume re-throwing the
InterruptedException is a better choice.
http://cr.openjdk.java.net/~shurailine/8
Hi Shura,
I have pushed the changeset to jdk9/dev.
Mandy
> On Nov 19, 2015, at 8:40 AM, Alexandre (Shura) Iline
> wrote:
>
> Yes, sorry.
>
> Since the methods do not have any work to complete before interrupting and
> also methods are not used anywhere currently, I assume re-throwing the
>
18 matches
Mail list logo
