Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Nov 1, 2016, at 2:44 PM, Steve Drach wrote: > > I’ve put out another webrev, http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses Mandy’s concerns. In particular I demonstrate that the resultant image is “runnable” and that a Main class in the image

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>>> I’ve put out another webrev, >>> http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses >>> Mandy’s concerns. In particular I demonstrate that the resultant image is >>> “runnable” and that a Main class in the image can/cannot find the >>> java.logging module when the modul

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>>> I’ve put out another webrev, >>> http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses >>> Mandy’s concerns. In particular I demonstrate that the resultant image is >>> “runnable” and that a Main class in the image can/cannot find the >>> java.logging module when the module

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Oct 31, 2016, at 8:26 PM, Mandy Chung wrote: > > >> On Oct 27, 2016, at 5:22 PM, Steve Drach wrote: >> >> I’ve put out another webrev, >> http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses >> Mandy’s concerns. In particular I demonstrate that the resultant image is

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Oct 27, 2016, at 5:22 PM, Steve Drach wrote: > > I’ve put out another webrev, > http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses Mandy’s > concerns. In particular I demonstrate that the resultant image is “runnable” > and that a Main class in the image can/cannot fi

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 28/10/2016 01:22, Steve Drach wrote: I’ve put out another webrev, http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/ , that addresses Mandy’s concerns. In particular I demonstrate that the resultant image is “runnable” and that

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

I’ve put out another webrev, http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/ , that addresses Mandy’s concerns. In particular I demonstrate that the resultant image is “runnable” and that a Main class in the image can/cannot find the

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 19/10/2016 23:35, Steve Drach wrote: : Argh! Sorry about that. Here’s the correct link http://cr.openjdk.java.net/~sdrach/8156499/webrev.04/ Thanks for the updates, the changes to jlink look correct in this version. -Alan.

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Oct 19, 2016, at 1:59 PM, Steve Drach wrote: > In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not sure that that is right (think modular JAR on the module path with a manifest, it's just a resource file). >>> I took that out and it still works as ex

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Oct 19, 2016, at 1:59 PM, Steve Drach wrote: > In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not sure that that is right (think modular JAR on the module path with a manifest, it's just a resource file). >>> I took that out and it still works as ex

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>>> In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not >>> sure that that is right (think modular JAR on the module path with a >>> manifest, it's just a resource file). >> I took that out and it still works as expected. >> >>> Are directories the only case where toEntry

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>>> In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not >>> sure that that is right (think modular JAR on the module path with a >>> manifest, it's just a resource file). >> I took that out and it still works as expected. >> >>> Are directories the only case where toEntry

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 19/10/2016 20:15, Steve Drach wrote: In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not sure that that is right (think modular JAR on the module path with a manifest, it's just a resource file). I took that out and it still works as expected. Are directories the

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>> Hi, >> >> Please review the latest webrev for this issue. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-8156499 >> >> webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.03/ >>

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 13/10/2016 00:00, Steve Drach wrote: Hi, Please review the latest webrev for this issue. issue: https://bugs.openjdk.java.net/browse/JDK-8156499 webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.03/

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

Hi, Please review the latest webrev for this issue. issue: https://bugs.openjdk.java.net/browse/JDK-8156499 webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.03/ I believe this ch

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 22/08/2016 21:43, Steve Drach wrote: You’re right. Apparently when I read the code this morning, I hadn’t had enough coffee yet ;-) One thing we need to do is capture all the details on how modular JAR should work as multi-release JARs and get this written down in JEP 235 or JEP 261. I'm

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 22, 2016, at 2:56 PM, Steve Drach wrote: > > Is a jar tool that takes a -d option lurking somewhere? The latest one I > have does not have that option. It’s in jdk-9+132 and has been in jdk9/dev for 1.5 weeks (see JDK-8136930). It was -p previously. $ jar -h Usage: jar [OPTION.

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

Er, I thought the plan was for the set of concealed packages to be the same. It's okay for the ConcealedPackages in the base section to include "empty" packages. >>> >>> I wasn’t involved with that decision. Chris wrote that code, perhaps he >>> can comment. >> >> This surprise

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 22/08/2016 22:04, Mandy Chung wrote: : If a JAR file contains an empty directory, should `q` be considered as a concealed package in the base section? $ jar -t --file hi.jar META-INF/ META-INF/MANIFEST.MF module-info.class p/Hi.class q/ currently not: $ jar -d --file mr.jar hi requi

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 22, 2016, at 1:35 PM, Chris Hegarty wrote: > > >> On 22 Aug 2016, at 19:24, Steve Drach wrote: >>> >>> Er, I thought the plan was for the set of concealed packages to be the >>> same. It's okay for the ConcealedPackages in the base section to include >>> "empty" packages. >> >> I

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

It exists purely because another class in the same versioned directory depends on it. If we are creating a versionedStream for the version that the non-public class is in, it will be in finalNames, otherwise it won’t be. I believe the code is correct here. New co

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On 22 Aug 2016, at 19:24, Steve Drach wrote: >> ... >>> It exists purely because another class in the same versioned directory >>> depends on it. If we are creating a versionedStream for the version that >>> the non-public class is in, it will be in finalNames, otherwise it won’t >>> be. I

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>> If there is a class in a versioned directory that is not in the base >> directory, then that class must not be public or protected. It’s not part >> of the public interface of the multi-release jar. > It's also a modular JAR and so if the class is not in an exported package > then it's okay

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 22/08/2016 18:47, Steve Drach wrote: : If there is a class in a versioned directory that is not in the base directory, then that class must not be public or protected. It’s not part of the public interface of the multi-release jar. It's also a modular JAR and so if the class is not in an e

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

>> I didn’t have it right ;-) It turns out a JarFile stream of versioned >> entries was more interesting than I initially thought. Here’s another >> webrev. It’s not clear to me if I should include the change to JarFile in >> this changeset or if it should be in a stand alone changeset. Advi

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 21/08/2016 03:49, Mandy Chung wrote: I think it’s time to enumerate several test cases of a multi-release Jar content, e.g. a MRJAR with a new concealed package in versioned entries but not in the base entry (I believe that’s allowed?? version 9 & 10 entries that makes sure versioned 10 e

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 12, 2016, at 5:33 PM, Steve Drach wrote: > > I didn’t have it right ;-) It turns out a JarFile stream of versioned > entries was more interesting than I initially thought. Here’s another > webrev. It’s not clear to me if I should include the change to JarFile in > this changeset o

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

I didn’t have it right ;-) It turns out a JarFile stream of versioned entries was more interesting than I initially thought. Here’s another webrev. It’s not clear to me if I should include the change to JarFile in this changeset or if it should be in a stand alone changeset. Advice appreciat

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 8, 2016, at 12:46 PM, Alan Bateman wrote: >> > I think we can do this in phases, starting out with jlink picking up the > runtime version and using that to select the resources from the modular JAR > would be a good start. At some point we will have an update module path > implementa

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 08/08/2016 17:34, Steve Drach wrote: : Back to the old drawing board ;-) I think we can do this in phases, starting out with jlink picking up the runtime version and using that to select the resources from the modular JAR would be a good start. At some point we will have an update module

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 8, 2016, at 1:57 AM, Alan Bateman wrote: > > On 06/08/2016 00:43, Steve Drach wrote: > >> Hi, >> >> Please review this changset that makes jlink multi-release jar aware. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-8156499 >>

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

On 06/08/2016 00:43, Steve Drach wrote: Hi, Please review this changset that makes jlink multi-release jar aware. issue: https://bugs.openjdk.java.net/browse/JDK-8156499 webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.00/index.html

RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

Hi, Please review this changset that makes jlink multi-release jar aware. issue: https://bugs.openjdk.java.net/browse/JDK-8156499 webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.00/index.html