Re: RFR 8193033 remove terminally deprecated sun.misc.Unsafe.defineClass

2018-03-15 Thread Chris Hegarty
> On 15 Mar 2018, at 17:06, Paul Sandoz wrote: > > Hi, > > Please review this patch to remove sun.misc.Unsafe.defineClass in 11. > > There has been much outreach, by Alan and the Jigsaw team, about its public > replacement MethodHandles.Lookup.defineClass. > > CSR is here: > > https://bugs

Re: 8233922: Service binding augments module graph with observable incubator modules

2019-11-19 Thread Chris Hegarty
> On 18 Nov 2019, at 12:34, Alan Bateman wrote: > > ... > http://cr.openjdk.java.net/~alanb/8233922/webrev/ I think this looks ok. The original patch that added incubator module support had similar changes ( to exclude incubator modules from service binding ), but it impacted on the publi

Re: 8233922: Service binding augments module graph with observable incubator modules

2019-11-19 Thread Chris Hegarty
> On 19 Nov 2019, at 13:51, Alan Bateman wrote: > > ... > The warn-incubating flag is used in all phases to indicate that a module is > an incubator module and to warn when the module is resolved. Technically > these two concerns could be separated but this need hasn't arisen to date. > > Th

Re: 8233922: Service binding augments module graph with observable incubator modules

2019-11-19 Thread Chris Hegarty
> On 18 Nov 2019, at 17:54, Alex Buckley wrote: >> .. > An incubator module's service providers will now be unavailable by default > even if a module on the module path says `uses`. I believe that JEP 11 should > say the following: > > - > Incubator modules are part of the JDK run-time i

Re: Ugly things done to support multiple ContentHandlerFactory and URLStreamHandlerFactory

2016-10-17 Thread Chris Hegarty
Alan, Tom, On 13/10/16 19:59, Alan Bateman wrote: .. Speaking of net-dev, then maybe this thread should move there as this topic is really more of a URL issue rather than module system issue. I have replied to this over on net-dev [1] ( I hope that is ok ). We can continue the discussion ther

hg: jigsaw/jake/jdk: Import of 8168980: Reinstate sun.reflect.ReflectionFactory.newConstructorForSerialization(Class, Constructor)

2016-11-01 Thread chris . hegarty
Changeset: 7992a052c7fa Author:chegar Date: 2016-11-01 12:37 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7992a052c7fa Import of 8168980: Reinstate sun.reflect.ReflectionFactory.newConstructorForSerialization(Class,Constructor) Reviewed-by: alanb ! src/java.base/share

hg: jigsaw/jake/jdk: Replace exported-private with open

2016-11-23 Thread chris . hegarty
Changeset: 3750898360d0 Author:chegar Date: 2016-11-23 09:55 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3750898360d0 Replace exported-private with open ! src/java.base/share/classes/java/lang/Class.java

Re: Code review for jigsaw/jake -> jdk9/dev sync up

2016-11-28 Thread Chris Hegarty
On 24 Nov 2016, at 15:25, Alan Bateman wrote: > > ... > To get going, I've put the webrevs with a snapshot of the changes in jake > here: >http://cr.openjdk.java.net/~alanb/8169069/0/ Overall this look very good. I ran through most of the changes in the jdk repo, just a few small comments.

Fwd: RFR [9] 8166568 & 8169492 jmod extract and bug fix

2016-12-06 Thread Chris Hegarty
[ forwarding to a more appropriate list to review this change ] > Begin forwarded message: > > From: Chris Hegarty > Subject: RFR [9] 8166568 & 8169492 jmod extract and bug fix > Date: 6 December 2016 at 10:46:08 GMT > To: core-libs-dev > > This change adds a basi

Re: RFR [9] 8166568 & 8169492 jmod extract and bug fix

2016-12-08 Thread Chris Hegarty
> On 8 Dec 2016, at 00:44, Mandy Chung wrote: > > >> On Dec 6, 2016, at 2:46 AM, Chris Hegarty wrote: >> >> This change adds a basic option to the jmod tool to extract all its contents >> to >> the current working directory, 8166568 [1]. Additionally,

RFR [9] 8170859 : Run time and tool support for ModuleResolution

2016-12-08 Thread Chris Hegarty
This is a review request for the link time and run time support for the mechanism to support incubator modules [1]. More specifically, the addition of options to the jmod and jar tools to pass through the relevant values, as per JEP 11, and support for these in the form of a new ModuleResolution a

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

2016-12-08 Thread Chris Hegarty
gt; > - Mail original - >> De: "Chris Hegarty" >> À: "jigsaw-dev" >> Envoyé: Jeudi 8 Décembre 2016 14:49:38 >> Objet: RFR [9] 8170859 : Run time and tool support for ModuleResolution > >> This is a review request for the link time

Re: RFR [9] 8166568 & 8169492 jmod extract and bug fix

2016-12-08 Thread Chris Hegarty
jmod("extract", + "--dir", "extractTestDir", + MODS_DIR.resolve("fooExtractDir.jmod").toString()) .assertSuccess() .resultChecker(r -> { // check a sample of the extracted files When the dir is

Re: RFR [9] 8170859 : Run time and tool support for ModuleResolution

2016-12-09 Thread Chris Hegarty
I'll work with Alan to get these changes re-based on top of the refactoring in jake. Consider this review request withdrawn. -Chris. On 09/12/16 14:09, Remi Forax wrote: Thanks Alan, so I withdraw my snarky comment. Rémi On December 9, 2016 12:25:19 PM GMT+01:00, Alan Bateman wrote: On 08

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-10 Thread Chris Hegarty
I think it best to keep whatever we do here simple and straight forward. It is, after all, just a stop gap until a public API can be put in place in a future release ( which I believe is a realistic possibility given some of the discussions that I have heard about, but that is for another day). If

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-11 Thread Chris Hegarty
> On 10 Dec 2016, at 19:47, Peter Levart wrote: > > Hi Chris, > > On 12/10/2016 06:11 PM, Chris Hegarty wrote: >> How about: Unsafe::deallocate(ByteBuffer directBuffer)? >> >> http://cr.openjdk.java.net/~chegar/Unsafe_deallocate/ > > Apart from the

hg: jigsaw/jake/jdk: 8170859: Run time and tool support for ModuleResolution

2016-12-13 Thread chris . hegarty
Changeset: 7096176b5e14 Author:chegar Date: 2016-12-12 14:40 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7096176b5e14 8170859: Run time and tool support for ModuleResolution ! src/java.base/share/classes/jdk/internal/module/ClassFileAttributes.java ! src/java.base/sha

hg: jigsaw/jake: 8170859: Run time and tool support for ModuleResolution

2016-12-13 Thread chris . hegarty
Changeset: 1be9ce97598d Author:chegar Date: 2016-12-13 14:22 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/1be9ce97598d 8170859: Run time and tool support for ModuleResolution ! make/CreateJmods.gmk

hg: jigsaw/jake/jdk: Move tests to jdk/modules

2016-12-13 Thread chris . hegarty
Changeset: 55586b951ae1 Author:chegar Date: 2016-12-13 14:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/55586b951ae1 Move tests to jdk/modules + test/jdk/modules/incubator/DefaultImage.java + test/jdk/modules/incubator/ImageModules.java + test/jdk/modules/incubator/s

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-13 Thread Chris Hegarty
Taking into account the feedback so far, and changing the method name ( since it is an attractive nuisance ), here is where I think we ended up. http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/ If this is agreeable, I’ll file an issue in JIRA to track the code changes, and update JEP 26

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-14 Thread Chris Hegarty
st for Unsafe::deallocate Regards, Peter On 12/13/2016 08:47 PM, Chris Hegarty wrote: Taking into account the feedback so far, and changing the method name ( since it is an attractive nuisance ), here is where I think we ended up. http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/ If this i

hg: jigsaw/jake/jdk: Additional test coverage in ImageModules.java

2016-12-14 Thread chris . hegarty
Changeset: ae2572dcd89a Author:chegar Date: 2016-12-14 16:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ae2572dcd89a Additional test coverage in ImageModules.java ! test/jdk/modules/incubator/ImageModules.java

hg: jigsaw/jake/jdk: Review comments and cleanup

2016-12-15 Thread chris . hegarty
Changeset: eb56db7b3aaa Author:chegar Date: 2016-12-15 14:10 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/eb56db7b3aaa Review comments and cleanup ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java ! src/java.base/share/classes/jdk/internal/module/M

Re: 8170987: Module system implementation refresh (12/2016)

2016-12-15 Thread Chris Hegarty
> On 15 Dec 2016, at 01:17, Mandy Chung wrote: > ... > > src/java.base/share/classes/jdk/internal/module/ModuleResolution.java > > 64 throw new RuntimeException("cannot add deprecated to " + > value); > > This comment applies to ModuleResoluton::with* methods. This should > prob

Re: 8170987: Module system implementation refresh (12/2016)

2016-12-15 Thread Chris Hegarty
> On 15 Dec 2016, at 09:17, Alan Bateman wrote: >> ... >> When we use —-module-version for user modules, the runtime will load >> regex. The system modules jlink plugin uses the cached version if >> JDK modules to be compiled with —0module-version in the future. >> This might be something we sho

hg: jigsaw/jake/jdk: jmod/jar tool: Document extra options in help

2016-12-15 Thread chris . hegarty
Changeset: 1bd62b2bc515 Author:chegar Date: 2016-12-15 21:28 + URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1bd62b2bc515 jmod/jar tool: Document extra options in help ! src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java ! src/jdk.jartool/share/classes/sun/t

Re: RFR: 8171373: Reduce copying during initialization of ModuleHashes

2016-12-16 Thread Chris Hegarty
> On 16 Dec 2016, at 16:00, Claes Redestad wrote: > > Hi, > > recent changes to split out ModuleHashes from ModuleDescriptor caused a > small/tiny increase in HashMap creation, resize and copying: > > Webrev: http://cr.openjdk.java.net/~redestad/8171373/webrev.01/ > Bug: https://bugs.openjdk.

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-16 Thread Chris Hegarty
Pushed to jdk9/dev. Should make b150. https://bugs.openjdk.java.net/browse/JDK-8171377 -Chris. > On 14 Dec 2016, at 11:58, Chris Hegarty wrote: > > Webrev updated in-place. > http://cr.openjdk.java.net/~chegar/Unsafe_invokeCleaner/ > > -Chris. > > On 13/12/16 2

Re: Java 9 build 148 causes trouble in Apache Lucene/Solr/Elasticsearch

2016-12-19 Thread Chris Hegarty
ommitter > Bremen, Germany > http://lucene.apache.org/ > >> -Original Message- >> From: Chris Hegarty [mailto:[email protected]] >> Sent: Friday, December 16, 2016 6:39 PM >> To: Peter Levart ; Core-Libs-Dev > [email protected]>; jigsaw-dev ; Uwe >>

Re: RFR 8170618: jmod should validate if any exported or open package is missing

2016-12-21 Thread Chris Hegarty
On 21/12/16 12:08, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8170618/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8170618 Looks good Sundar. -Chris.

RFR [9] 8168149: Examine the behavior of jmod command-line options - repeating vs last one wins

2016-12-22 Thread Chris Hegarty
Most options for the jmod tool should be last one wins, to be consistent with the JDK tool convention, 8168149 [1]. Excludes is the only repeatable option. Given the existing usage of JOpt Simple, the most straight forward way to achieve the last-one-wins behaviour is to drop the withValuesSeparat

Re: RFR [9] 8168149: Examine the behavior of jmod command-line options - repeating vs last one wins

2017-01-05 Thread Chris Hegarty
> On 4 Jan 2017, at 21:03, Mandy Chung wrote: > > >> On Dec 22, 2016, at 9:11 AM, Chris Hegarty wrote: >> >> Most options for the jmod tool should be last one wins, to be consistent >> with the JDK tool convention, 8168149 [1]. Excludes is the only >&

Re: Review Request JDK-8160286: jmod hash is creating unlinkable modules.

2017-01-12 Thread Chris Hegarty
> On 11 Jan 2017, at 23:47, Mandy Chung wrote: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8160286/webrev.00/ Looks fine. It’s good to share as much of this code as possible between these packaging tools. I didn’t look too hard at Graph and TopoSorter, these look similar to

RFR 8171380: Remove exports from jdk.jlink

2017-01-16 Thread Chris Hegarty
The Jlink Plugin API is not going to be supported in 9, so should not be exported [1], for use by third parties. Besides the removal of the export, most of the changes are adding @modules tags to existing tests. http://cr.openjdk.java.net/~chegar/8171380.00/ Note: Sundar will follow up with 8172

Re: RFR 8171380: Remove exports from jdk.jlink

2017-01-16 Thread Chris Hegarty
On 16/01/17 16:26, Alan Bateman wrote: This looks okay except CustomPluginTest where I assume you mean to add it to the ProblemList file. Ok, I'll remove the @ignore and put the test on the ProblemList before pushing. Thanks. -Chris.

Re: RFR 8171380: Remove exports from jdk.jlink

2017-01-17 Thread Chris Hegarty
> On 17 Jan 2017, at 00:02, Remi Forax wrote: > > Cris, > it seems that there is a mechanism for API that are experimental in the jdk, > by example java.net.http uses this mechanism, is it possible to reuse the > same mechanism for the jlink plugin API ? I did look at the possibility exposing

Re: Review request: JDK-8172870 test/tools/jmod/JmodTest.java fails on windows with AccessDeniedException

2017-01-18 Thread Chris Hegarty
> On 18 Jan 2017, at 07:38, Alan Bateman wrote: > > On 17/01/2017 21:23, Mandy Chung wrote: > >> This test case attempts to verify that the temp file created by jmod is >> cleaned up and removed if jmod create command fails. It first cleans up any >> temp files matching the prefix and suffix

RFR [9] 8172982: tools/jlink/ResourceDuplicateCheckTest.java requires jdk.tools.jlink.plugin to be exported

2017-01-18 Thread Chris Hegarty
Since the jlink plugin package is no longer exported this test should add the appropriate @modules tag. diff -r 5b75946223fb test/tools/jlink/ResourceDuplicateCheckTest.java --- a/test/tools/jlink/ResourceDuplicateCheckTest.java Wed Jan 18 13:56:50 2017 + +++ b/test/tools/jlink/ResourceDupli

Re: Review Request: JDK-8173096 jmod files are not world-readable

2017-01-23 Thread Chris Hegarty
On 21/01/17 02:32, Mandy Chung wrote: Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 Looks fine. Trivially, the test can now drop "-Djava.io.tmpdir=." . -Chris. I want to fix

Re: Extending java.base module

2017-02-15 Thread Chris Hegarty
> On 15 Feb 2017, at 08:51, Weijun Wang wrote: > > Disclaimer: I am not a jigsaw expert. > > The provides/uses mechanism is certainly more formal, but you can also do > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d282c1a8d20b. This is, at best, a hack. The use of Services is a better approach

Re: RFR: 8175010: ImageReader is not thread-safe

2017-02-15 Thread Chris Hegarty
> On 15 Feb 2017, at 13:22, Claes Redestad wrote: > > Hi, > > a few intermittent but rare test failures[1] that has appeared > since the latest jake integration, and since one of the changes > in there was to make initialization of the system ImageReader > lazy there appears to be cases where I

Re: sun.nio.ch.DirectBuffer and jdk9/jigsaw

2017-02-23 Thread Chris Hegarty
> On 23 Feb 2017, at 11:30, Vitaly Davidovich wrote: >> ... > The buffers are reused by having them point to different native memory > block addresses; those blocks are managed by native code. As mentioned, > the ByteBuffer (DirectByteBuffer concretely) is used as the Java level > interface/view

RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Chris Hegarty
It would be useful for the jar tool to report the automatic module name that would be used if a regular jar file was put on the module path ( so there is an easy way for developers to determine the derived name ). One way to achieve this is to repurpose the somewhat finger-some '--print-module-de

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Chris Hegarty
> On 15 Mar 2017, at 14:42, Alan Bateman wrote: > > On 15/03/2017 14:21, Chris Hegarty wrote: > >> : >> >> Webrev: >> >> http://cr.openjdk.java.net/~chegar/8176772.00/ >> https://bugs.openjdk.java.net/browse/JDK-817677

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-15 Thread Chris Hegarty
> On 15 Mar 2017, at 16:54, Mandy Chung wrote: > >> >> On Mar 15, 2017, at 8:31 AM, Chris Hegarty wrote: >> >> >>> On 15 Mar 2017, at 14:42, Alan Bateman wrote: >>> >>> On 15/03/2017 14:21, Chris Hegarty wrote: >>> >&

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-16 Thread Chris Hegarty
> On 15 Mar 2017, at 17:30, Mandy Chung wrote: > > ... > provides and main class, if present. > > The modifier of ModuleDescriptor will have AUTOMATIC and so all packages are > exported and open implicitly and not shown in the output which is okay. This is a good idea. Here’s an example: ja

Re: RFR [9] 8176772: jar tool support to report automatic module names

2017-03-16 Thread Chris Hegarty
On 16 Mar 2017, at 13:09, Chris Hegarty wrote: > >> On 15 Mar 2017, at 17:30, Mandy Chung wrote: >> >> ... >> provides and main class, if present. >> >> The modifier of ModuleDescriptor will have AUTOMATIC and so all packages are >> exported an

Re: 8174823: Module system implementation refresh (3/2017)

2017-03-22 Thread Chris Hegarty
> On 21 Mar 2017, at 21:42, Alan Bateman wrote: > > We have been accumulating changes in the jake forest for the last few weeks > to align with the proposals in JSR 376 and also to pick up API changes and > bug fixes. It's time to bring these changes into jdk9/dev. The issue to bring > these

Re: 8177474: Do not emit warnings when illegal access is allowed by --add-exports/--add-opens

2017-03-23 Thread Chris Hegarty
> On 23 Mar 2017, at 19:16, Alan Bateman wrote: > > I'd like to get jdk9/dev updated to align with the latest proposal for > --add-exports/--add-opens to not emit warnings. I've put the webrev with the > changes here: > >http://cr.openjdk.java.net/~alanb/8177474/webrev/index.html These c

Re: Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

2017-03-24 Thread Chris Hegarty
> On 23 Mar 2017, at 23:55, Mandy Chung wrote: > > Jon and I work on this patch as the first step to enable module > graphs for inclusion in the javadoc. It includes a @moduleGraph > taglet, an updated GenGraphs tool, and also updates javadoc of > module-info.java to include @moduleGraph. I a

hg: jigsaw/jake/jdk: 2 new changesets

2017-04-12 Thread chris . hegarty
Changeset: 3277e976d3c4 Author:chegar Date: 2017-04-12 12:13 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3277e976d3c4 bug fix in jar Validator comparator ! src/jdk.jartool/share/classes/sun/tools/jar/Validator.java + test/tools/jar/multiRelease/whitebox/Driver.java +

hg: jigsaw/jake/jdk: jar tool: remove superflous newlines in describe output

2017-04-12 Thread chris . hegarty
Changeset: 245e5e5c0c8e Author:chegar Date: 2017-04-12 13:51 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/245e5e5c0c8e jar tool: remove superflous newlines in describe output ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java

hg: jigsaw/jake/jdk: jmod tool describe module consistency with launcher

2017-04-12 Thread chris . hegarty
Changeset: 222e1d0b5f91 Author:chegar Date: 2017-04-12 14:46 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/222e1d0b5f91 jmod tool describe module consistency with launcher ! src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java ! test/tools/jmod/JmodTest.java

Re: 8178380: Module system implementation refresh (5/2017 update)

2017-05-02 Thread Chris Hegarty
Mandy, On 02/05/17 03:47, Mandy Chung wrote: ... src/jdk.jartool/share/classes/sun/tools/jar/Main.java 619 if (dflag) { 620 // "--describe-module/-d" does not require file argument(s), 621 // but does accept -

hg: jigsaw/jake/jdk: 8023460: OPENJDK build fails due to missing jfr.jar

2013-08-29 Thread chris . hegarty
Changeset: c442171f1d17 Author:dholmes Date: 2013-08-21 05:56 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c442171f1d17 8023460: OPENJDK build fails due to missing jfr.jar Reviewed-by: alanb ! makefiles/Profiles.gmk

Re: CFV: New Jigsaw Committer: Erik Joelsson

2014-08-05 Thread Chris Hegarty
Vote: yes -Chris > On 6 Aug 2014, at 00:13, Mandy Chung wrote: > > I hereby nominate Erik Joelsson (aka erikj) to Jigsaw Committer. > > Erik is one of the main contributors to the new build system > in JDK 8 and he has reviewer role in jdk8, jdk8u, and jdk9 project. > Erik has already contribu

Re: CFV: New Jigsaw Committer: Mike Duigou

2014-08-05 Thread Chris Hegarty
Vote: yes -Chris > On 6 Aug 2014, at 00:14, Mandy Chung wrote: > > I hereby nominate Mike Duigou (aka mduigou) to Jigsaw Committer. > > Mike has been a long time contributor to the JDK, making changes > and reviewing in jdk8, jdk9, lambda projects. Mike has also been > contributing many patche

hg: jigsaw/stage/jdk: Move package descriptions to their correct location

2014-08-08 Thread chris . hegarty
Changeset: ffc07c4dc2fd Author:chegar Date: 2014-08-07 13:02 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/jdk/rev/ffc07c4dc2fd Move package descriptions to their correct location - src/java.base/share/classes/java/lang/instrument/package.html - src/java.base/share/classes/jav

hg: jigsaw/stage/hotspot: Restore original jcheck configuration

2014-08-08 Thread chris . hegarty
Changeset: 58ecb26d3514 Author:chegar Date: 2014-08-08 11:27 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/hotspot/rev/58ecb26d3514 Restore original jcheck configuration ! .jcheck/conf

hg: jigsaw/stage: Script to aid back-porting of patches from JDK 9 to 8u

2014-08-08 Thread chris . hegarty
Changeset: 7b9fd78f2381 Author:chegar Date: 2014-08-08 16:19 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/rev/7b9fd78f2381 Script to aid back-porting of patches from JDK 9 to 8u + common/bin/unshuffle_list.txt + common/bin/unshuffle_patch.sh

hg: jigsaw/stage: 7 new changesets

2014-08-10 Thread chris . hegarty
Changeset: d2c492570bd9 Author:mikael Date: 2014-07-16 15:04 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/rev/d2c492570bd9 8050802: Update jprt runthese test suite to jck-8 Reviewed-by: dholmes, kvn ! make/jprt.properties Changeset: a3350d68c12f Author:sspitsyn Date:

hg: jigsaw/stage/jaxp: 6 new changesets

2014-08-10 Thread chris . hegarty
Changeset: 86f7146ceafe Author:henryjen Date: 2014-07-02 14:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jaxp/rev/86f7146ceafe 8049109: Add @since 1.9 to new packages added in jaxp Reviewed-by: darcy, joehw ! src/org/w3c/dom/ranges/DocumentRange.java ! src/org/w3c/dom/rang

hg: jigsaw/stage/jaxws: 3 new changesets

2014-08-10 Thread chris . hegarty
Changeset: 1b90914c37b8 Author:henryjen Date: 2014-06-19 15:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jaxws/rev/1b90914c37b8 8047724: @since tag cleanup in jaxws Reviewed-by: alanb, mkos ! src/share/jaf_classes/javax/activation/CommandMap.java ! src/share/jaf_classes/ja

hg: jigsaw/stage/langtools: 7 new changesets

2014-08-10 Thread chris . hegarty
Changeset: af5e8c248039 Author:mcimadamore Date: 2014-07-24 13:11 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/langtools/rev/af5e8c248039 8048890: Add option to keep track of symbol completion dependencies Summary: Generate dot file with representation of javac on-demand symbo

hg: jigsaw/stage/jdk: 70 new changesets

2014-08-10 Thread chris . hegarty
Changeset: 1254df1151d2 Author:mduigou Date: 2014-07-24 09:01 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jdk/rev/1254df1151d2 8048209: Collections.synchronizedNavigableSet().tailSet(Object,boolean) synchronizes on wrong object Reviewed-by: psandoz, chegar ! src/share/class

hg: jigsaw/stage/nashorn: 11 new changesets

2014-08-10 Thread chris . hegarty
Changeset: 0787fe044ee6 Author:lagergren Date: 2014-07-29 14:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/nashorn/rev/0787fe044ee6 8048869: Reduce compile time by about 5% by removing the Class.casts from the AST nodes Summary: Removed the native casts that slow down the c

hg: jigsaw/stage/hotspot: 36 new changesets

2014-08-10 Thread chris . hegarty
Changeset: cf51cd09a99a Author:simonis Date: 2014-07-18 19:56 +0200 URL: http://hg.openjdk.java.net/jigsaw/stage/hotspot/rev/cf51cd09a99a 8051378: AIX: Change "8030763: Validate global memory allocation" breaks the HotSpot build Reviewed-by: kvn ! src/os/aix/vm/os_aix.cpp Changes

hg: jigsaw/stage: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: a5c324e6f840 Author:lana Date: 2014-08-10 19:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/rev/a5c324e6f840 Added tag jdk9-b26 for changeset d3ec8d048e6c ! .hgtags Changeset: d1a324623a41 Author:chegar Date: 2014-08-11 11:32 +0100 URL: http://hg.o

hg: jigsaw/stage/jaxp: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 98a1a9025fd0 Author:lana Date: 2014-08-10 19:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jaxp/rev/98a1a9025fd0 Added tag jdk9-b26 for changeset a5aea8318ae4 ! .hgtags Changeset: 35d68bb88146 Author:chegar Date: 2014-08-11 11:32 +0100 URL: http:/

hg: jigsaw/stage/corba: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 0113206a8c8e Author:lana Date: 2014-08-10 19:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/corba/rev/0113206a8c8e Added tag jdk9-b26 for changeset 6c777df597bb ! .hgtags Changeset: a279cdbe1f14 Author:chegar Date: 2014-08-11 11:32 +0100 URL: http:

hg: jigsaw/stage/hotspot: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 184aac46be1f Author:lana Date: 2014-08-10 19:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/hotspot/rev/184aac46be1f Added tag jdk9-b26 for changeset 48b95a073d75 ! .hgtags Changeset: 747483da0279 Author:chegar Date: 2014-08-11 11:32 +0100 URL: htt

hg: jigsaw/stage/langtools: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 84d1fb7670fa Author:lana Date: 2014-08-10 19:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/langtools/rev/84d1fb7670fa Added tag jdk9-b26 for changeset 5b20a93f8db0 ! .hgtags Changeset: 3f964f7ec528 Author:chegar Date: 2014-08-11 11:32 +0100 URL: h

hg: jigsaw/stage/jdk: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 88856f58680f Author:lana Date: 2014-08-10 19:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jdk/rev/88856f58680f Added tag jdk9-b26 for changeset dde9f5cfde5f ! .hgtags Changeset: 54a747db48c7 Author:chegar Date: 2014-08-11 11:32 +0100 URL: http://

hg: jigsaw/stage/jaxws: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 879b5cc3ce32 Author:lana Date: 2014-08-10 19:38 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/jaxws/rev/879b5cc3ce32 Added tag jdk9-b26 for changeset 9b43f3993b96 ! .hgtags Changeset: edca714118ac Author:chegar Date: 2014-08-11 11:32 +0100 URL: http:

hg: jigsaw/stage/nashorn: 2 new changesets

2014-08-11 Thread chris . hegarty
Changeset: 7404f40a22e1 Author:lana Date: 2014-08-10 19:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/stage/nashorn/rev/7404f40a22e1 Added tag jdk9-b26 for changeset ed60a4e9dd35 ! .hgtags Changeset: 9be31791b8cf Author:chegar Date: 2014-08-11 11:32 +0100 URL: htt

RFR [9] Modular Source Code

2014-08-12 Thread Chris Hegarty
This is a review request for the Initial changes for JEP 201: Modular Source Code [1]. There are a number of individuals responsible for these changes. Some, possibly not all, are explicitly listed in the To section of this mail, and they will help address any comments arising from this review

Re: RFR [9] Modular Source Code

2014-08-13 Thread Chris Hegarty
tly because the build output is still in large parts repository oriented. This is something we hope to improve later. /Erik On 2014-08-12 16:10, Chris Hegarty wrote: This is a review request for the Initial changes for JEP 201: Modular Source Code [1]. There are a number of individuals respon

hg: jigsaw/stage: Revert default JPRT release

2014-08-13 Thread chris . hegarty
Changeset: 9feef5e086a4 Author:chegar Date: 2014-08-13 20:07 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/rev/9feef5e086a4 Revert default JPRT release ! make/jprt.properties

hg: jigsaw/stage/jdk: Fix libjavajpeg headers

2014-08-14 Thread chris . hegarty
Changeset: 7dbded285381 Author:erikj Date: 2014-08-14 17:57 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/jdk/rev/7dbded285381 Fix libjavajpeg headers ! make/lib/Awt2dLibraries.gmk

hg: jigsaw/stage/hotspot: Update expand_entries_to_path comment

2014-08-15 Thread chris . hegarty
Changeset: 091d5820c70d Author:chegar Date: 2014-08-15 17:43 +0100 URL: http://hg.openjdk.java.net/jigsaw/stage/hotspot/rev/091d5820c70d Update expand_entries_to_path comment ! src/share/vm/runtime/os.cpp

Re: RFR 8056141: Move com.sun.security.jgss into a new module

2014-08-28 Thread Chris Hegarty
On 28 Aug 2014, at 11:28, Wang Weijun wrote: > This is the sub-task of "8042900: Allow com.sun.security.jgss to be in > different module than org.ietf.jgss" that actually moves the files. > > Code changes include 2 parts: > > 1. For jdk9/dev repo: > > http://cr.openjdk.java.net/~weijun/8056

RFR 8058117: Missing jdk.deploy.osx from modules.xml

2014-09-10 Thread Chris Hegarty
While looking at the parsing of modules.xml, I came across a potential issue; jdk.deploy.osx is not listed in modules.xml. This was just an oversight in the original generation of modules.xml, as it will only appear on Mac. Note: This is not an issue for the build as jdk.deploy.osx is in modu

Re: RFR: JDK-8058118: Generate modules.list during the build

2014-09-13 Thread Chris Hegarty
On 12 Sep 2014, at 20:04, Mandy Chung wrote: > On 9/12/14 7:03 AM, Erik Joelsson wrote: >> Hello, >> >> The checked in modules.list file defines the dependencies between modules >> for the build. The dependency information in this file is already captured >> in the modules.xml. Rather than ke

hg: jigsaw/m2/jdk: Relax jcheck

2014-09-15 Thread chris . hegarty
Changeset: 05c312c7a272 Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/05c312c7a272 Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/jdk: A build tool for creating images

2014-09-18 Thread chris . hegarty
Changeset: 6d3e4a478cbd Author:chegar Date: 2014-09-18 14:10 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/6d3e4a478cbd A build tool for creating images ! make/Tools.gmk ! make/src/classes/build/tools/module/GenJdepsModulesXml.java + make/src/classes/build/tools/module/Im

hg: jigsaw/m2: Fix JDK modules list

2014-09-18 Thread chris . hegarty
Changeset: d9e973d6d3b9 Author:chegar Date: 2014-09-18 16:33 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/d9e973d6d3b9 Fix JDK modules list ! make/Images.gmk

hg: jigsaw/m2/nashorn: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: a736c118e1ef Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/nashorn/rev/a736c118e1ef Relax jcheck ! .jcheck/conf

hg: jigsaw/m2: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: 5bf741388c0b Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/5bf741388c0b Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/hotspot: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: a987298e1967 Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/a987298e1967 Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/corba: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: 123637ab8d40 Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/corba/rev/123637ab8d40 Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/jaxp: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: 7ad0246d6995 Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jaxp/rev/7ad0246d6995 Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/langtools: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: ea5cbac05444 Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/langtools/rev/ea5cbac05444 Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/jaxws: Relax jcheck

2014-09-19 Thread chris . hegarty
Changeset: 7d715e94e0cb Author:chegar Date: 2014-09-15 11:08 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jaxws/rev/7d715e94e0cb Relax jcheck ! .jcheck/conf

hg: jigsaw/m2/jdk: ImageBuidler: Fatal error if module unknown

2014-09-19 Thread chris . hegarty
Changeset: e2b08347e27a Author:chegar Date: 2014-09-19 14:17 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/e2b08347e27a ImageBuidler: Fatal error if module unknown ! make/src/classes/build/tools/module/ImageBuilder.java

hg: jigsaw/m2: Fix module definitions, as per jdk9

2014-09-19 Thread chris . hegarty
Changeset: 75fd07699dde Author:chegar Date: 2014-09-19 14:22 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/75fd07699dde Fix module definitions, as per jdk9 ! modules.xml

hg: jigsaw/m2: Fix Windows build

2014-09-19 Thread chris . hegarty
Changeset: a692db94d51b Author:chegar Date: 2014-09-19 15:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/a692db94d51b Fix Windows build ! make/StripBinaries.gmk

hg: jigsaw/m2/jdk: Fix Windows Image

2014-09-22 Thread chris . hegarty
Changeset: 7a6ccc1167fd Author:chegar Date: 2014-09-22 14:44 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/7a6ccc1167fd Fix Windows Image ! make/src/classes/build/tools/module/ModuleArchive.java

hg: jigsaw/m2/jdk: Set execute permission on jspawnhelper

2014-09-23 Thread chris . hegarty
Changeset: 770ac7f9cedd Author:chegar Date: 2014-09-23 11:15 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/770ac7f9cedd Set execute permission on jspawnhelper ! make/src/classes/build/tools/module/ImageBuilder.java

hg: jigsaw/m2/jdk: Image creation tool needs to generate jimage in endianness of target platform.

2014-10-09 Thread chris . hegarty
Changeset: 0ecba7b109ab Author:chegar Date: 2014-10-09 11:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/0ecba7b109ab Image creation tool needs to generate jimage in endianness of target platform. ! make/src/classes/build/tools/module/ImageBuilder.java ! src/java.base/s

hg: jigsaw/m2: Image creation tool needs to generate jimage in endianness of target platform.

2014-10-09 Thread chris . hegarty
Changeset: 121d5400c2d2 Author:chegar Date: 2014-10-09 11:20 +0100 URL: http://hg.openjdk.java.net/jigsaw/m2/rev/121d5400c2d2 Image creation tool needs to generate jimage in endianness of target platform. ! make/Images.gmk

  1   2   3   >